Gerrit/New repositories/Requests

From MediaWiki.org
Jump to navigation Jump to search

Tracking and archive of requests for space in Gerrit for new extensions and other repositories

Completed (and old) requests can be found in the archive.



You'll be telling us your wikitech/LDAP username, what code review model you want and what you want the project name in gerrit to be. Click request, then fill in the fields on the page creation screen:


Extension Developer Preferred model Comments Status
Example Alison Merge review Early stages of development. Yes Done --Admin user 09:56, 14 February 2012 (UTC)
mediawiki/gadgets/convenient-discussions Jack who built the house, Iniquity Open push only for repo maintainers Hi, we need to create a mirrow of CD repository (https://github.com/jwbth/convenient-discussions) on gerrit to work with localization directly from the Wikiproject. --Iniquity (talk) 01:55, 3 June 2020 (UTC) @Iniquity: By mirror, you mean "clone the repo once and then development will happen on Gerrit" or you mean "development happens on GitHub and Gerrit should keep itself updated from that repo"? (We can do the first, but not the second)

Also, although there are currently only 2 repos underneath mediawiki/gadgets they follow the CamelCase name conventions from mediawiki/extensions. So would you be ok if I CamelCase the repo name to mediawiki/gadgets/ConvenientDiscussions? --QChrisNonWMF (talk) 20:00, 3 June 2020 (UTC)

  • @QChrisNonWMF: Yes, I meant the second variant. It's a pity. Nothing can be done? :( Iniquity (talk) 11:22, 4 June 2020 (UTC)
@Iniquity: Too bad :-( Unfortunately, nothing can be done. Gerrit is only good at pushing changes forward (e.g.: to GitHub), not so much with pulling changes from another remote. --QChrisNonWMF (talk) 12:47, 4 June 2020 (UTC)
@QChrisNonWMF: A little clarification, I'm not talking about automatic updates by gerrit. We can do this on our own :) Iniquity (talk) 13:04, 4 June 2020 (UTC)
@QChrisNonWMF, Iniquity: Maybe I got this whole thread wrong, but it is possible to develop code on GitHub and get it mirrored on Gerrit via Phabricator Diffusion "push" functionality. Granted, this is not encouraged because it's a weird setup. —MarcoAurelio (talk) 21:23, 4 June 2020 (UTC)
@MarcoAurelio: You're of course right. The setup you describe is technically possible. But while technically possible, this setup is not only "not encouraged" as you write, it's discouraged. The documentation for ORES setup even contains the word "dangerous", which might be over the top :-D The whole thing is a bit interwoven with many other things, so let me reach out a bit farther. Probably we should add this to a page about repo creation. Not sure. Regardless: The text below is not meant to lecture anyone, but just to provide more detail and context why we're typically not doing such setups (although they would technically be possible). The big picture is that at some point, each team in WMF decided which task tracker they wanted to use. There was a wide mix between Bugzilla, Trello, Mingle and what not. It was hard to find who did what and when, because everyone used a different system. Some teams even used more than one tracker. This was considered a serious enough issue that after some discussion, this was all switched to Phabricator (Phabricator RFC). Since we wanted all things at one place, one of they key arguments for many was that Phabricator will also include Code Reviews. That last part never materialized for several reasons. We ended up with not a single tool for Code Review, but two. Phabricator for the early adopters, and Gerrit for the rest--although we switched to Phabricator to have everything in one place. In order to get Code Review back into a single place another RFC was done to fully migrate Code Review to Phabricator. And it was declined. So we arrived at the point where we want to stop using Differential for code review (task T191182). We want all in one place so people can easily find the authorative repo. People can easily find the place where to submit patches etc. Whether we like it or not, (at least for now) this single place is Gerrit for WMF. Not sure if I like that or not, but it is what it is. And if we end up having exceptions again and again, we end up having code in so many different places again, just as we did with Bugtrackers before. This is the very thing our community does not want :-) But even when ignoring all these social requirements, having repos elsewhere does also come with a support burden. For example, if the authorative repo is, say GitHub, and we get the code into Gerrit automatically through some means, what happens to localization updates that get applied automagically on Gerrit? Either Phabricator fails to push some commit due to a merge conflict sooner or later or it force pushes and thereby rewriting history. We've been there. We've received tickets for such breakage and we've seen accusations of undoing someone's commits etc. Although it was just a simple automated pull/push. So for all these reasons, I'll not set-up a GitHub repo pull/push to Gerrit. But as Iniquity said that it need not be automatic updates we can push the problem onto Inquity's shoulders (see below) --QChrisNonWMF (talk) 09:39, 5 June 2020 (UTC)
@Iniquity: If you want to do the updates manually (You pull the code from GitHub yourself and you push onto Gerrit yourself), that's something you can do. Not that that's our prefered setup, but we definitely grant you push access, and then you can do what you suggested (And we already have plenty such repos, so there's no point in denying it :-) ). Then we're back to the naming question. Would mediawiki/gadgets/ConvenientDiscussions work for you as repo name? --QChrisNonWMF (talk) 09:39, 5 June 2020 (UTC)
@QChrisNonWMF: Yes, this is not a problem, we can work with mediawiki/gadgets/ConvenientDiscussions. And thanks for the detailed comment above :) Iniquity (talk) 14:53, 6 June 2020 (UTC)

Yes Done Created as mediawiki/gadgets/ConvenientDiscussions

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 19:59, 7 June 2020 (UTC)

mediawiki/extensions/Expressions xxmarijnw Merge review Please import https://github.com/26/Expressions/ Thanks! --Xxmarijnw (talk) 17:14, 3 June 2020 (UTC) Yes Done and imported as requested. —MarcoAurelio (talk) 17:40, 3 June 2020 (UTC)
mediawiki/extensions/CatTalk naypta Merge review Thank you! --Naypta (talk) 15:45, 4 June 2020 (UTC) Yes Done Created as mediawiki/extensions/CatTalk. —MarcoAurelio (talk) 21:21, 4 June 2020 (UTC)
mediawiki/extensions/GlobalWatchlist DannyS712 Merge review Thanks, --DannyS712 (talk) 05:21, 11 June 2020 (UTC) @DannyS712: Just to make sure: This request is not about extension Collab(orative)Watchlist that was once called Extension:GlobalWatchlist and that we should import it from SVN, but this is for a new extension. Right? (To avoid confusion, we'd normally not allow to re-use extension names and would hence deny repo creation. But in this case, I only found use of the name “GlobalWatchlist” on wiki, not in code. In code, I could only find use of the extension's “new” 2011 name “CollabWatchlist”.) --QChrisNonWMF (talk) 06:27, 11 June 2020 (UTC)

Also, just to double-check, as you wrote the GlobalWatchlist gadget, you really want the repo name to be .../extenions/... and not .../gadgets/.... Right? --QChrisNonWMF (talk) 06:27, 11 June 2020 (UTC)

@QChrisNonWMF: yes, this is for a brand-new extension (didn't know there was a previous one) And yes, I want this to be under extensions - I have a grant to write an extension, see m:Grants:Project/DannyS712/Create a global watchlist extension --DannyS712 (talk) 06:49, 11 June 2020 (UTC)
@DannyS712: Regardless of grant or not: Thanks for clarifying, repo created as noted below. That said ... Congrats on the grant! :-) --QChrisNonWMF (talk) 09:19, 11 June 2020 (UTC)

Yes Done Created as mediawiki/extensions/GlobalWatchlist

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 09:19, 11 June 2020 (UTC)

labs/tools/rust-hello-world legoktm Merge review thank you! --Legoktm (talk) 10:59, 17 June 2020 (UTC) Yes Done Created as labs/tools/rust-hello-world

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 12:58, 17 June 2020 (UTC)

mediawiki/extensions/WSOAuth Xxmarijnw Merge review Please import https://github.com/WikibaseSolutions/WSOAuth/. Thanks! --Xxmarijnw (talk) 14:30, 1 July 2020 (UTC) Yes Done Created as mediawiki/extensions/WSOAuth

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 14:07, 3 July 2020 (UTC)

Flex Diagrams Yaron_Koren Merge review Please import this extension's code from https://github.com/yaronkoren/FlexDiagrams . Yaron Koren (talk) 18:03, 7 July 2020 (UTC) Yes Done Created as mediawiki/extensions/FlexDiagrams

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 09:41, 9 July 2020 (UTC)

WD_HumanEdits GoranSMilovanovic Merge review (preferred) (1) This should go under analytics/wmde/WD/ (2) please just initialize an empty repository GoranSM (talk) 08:28, 8 July 2020 (UTC) Yes Done Created as analytics/wmde/WD/WD_HumanEdits

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 09:44, 9 July 2020 (UTC)

mediawiki-extensions-CognitiveProcessDesigner rvogel Merge review This is an existing, but unmaintained extension Extension:Cognitive_Process_Designer. I have not requested "ownership" in Phabricator, as the code is not hosted by WMF. I have tried to contact the author, but did not get an answer Topic:Vhw85xgumox8wn9m. I'd like to publish a bugfixed version of that extension. Thanks for trying to reach the author on-wiki. To be on the safe side, I've now also reached out to him by email. I'll create the repo once he confirmed. --QChrisNonWMF (talk) 10:01, 9 July 2020 (UTC)

@Osnard: Emailing the author did not produce a response either. So I'm assume it's really unmaintained. --QChrisNonWMF (talk) 07:47, 17 July 2020 (UTC)

Yes Done Created as mediawiki/extensions/CognitiveProcessDesigner

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 07:47, 17 July 2020 (UTC)

mediawiki/extensions/OAuthRateLimiter Ppchelko, Clarakosi Merge review For phab:T257607. Owners: Core Platform Team. Thank you. PPchelko (WMF) (talk) 15:51, 10 July 2020 (UTC) Yes Done Created as mediawiki/extensions/OAuthRateLimiter

(GitHub mirror)(Phabricator mirror)

I've added Ppchelko, Clarakosi and wikimedia-core-platform as owners. The latter does not contain the whole Core Platform Team, but I figured it was the best match. Please adjust as needed, or ping me if you want me to adjust things for you. --QChrisNonWMF (talk) 18:44, 12 July 2020 (UTC)

wikimedia/security/landing-page (I think, based on the rest of the wikimedia/security type repos) reedy Merge review For phab:T257830 phab:T257832. Please use wikimedia-security as owner/etc. Please don't create a .gitreview file etc, as I think we might be pushing an import of research/landing-page to create a fork from. Thanks! --Reedy (talk) 13:57, 13 July 2020 (UTC) Yes Done Created as wikimedia/security/landing-page

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 15:01, 13 July 2020 (UTC)

mediawiki/extensions/OnionsPorFavor legoktm and Arlolra Merge review thanks! --Legoktm (talk) 10:35, 14 July 2020 (UTC) @Legoktm: I'm creating repos for WMF since some years now, but this repo request clearly comes with the best name ever! I've no clue what it's gonna do, but the name gets me interested already! My Spanish is very weak, but shouldn't it be OnionsPorFavor (capital „F”) if we follow CamelCase? Respond quickly, I cannot wait to create this repo and see what it'll be about :-) --QChrisNonWMF (talk) 19:20, 14 July 2020 (UTC)
Hopefully it can live up to the name :D And you're right, the F should be capitalized. Thanks again! Legoktm (talk) 22:02, 14 July 2020 (UTC)

Yes Done Created as mediawiki/extensions/OnionsPorFavor

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 22:09, 14 July 2020 (UTC)

operations/envoy-ratelimiter hnowlan Merge review This repo is for the purposes of mirroring and (short term) tagging our own releases and Docker images of the Envoy ratelimiter. Please import https://github.com/envoyproxy/ratelimit --HNowlan (WMF) (talk) 13:50, 20 July 2020 (UTC) Just double-checking, since the repo-name operations/envoy-ratelimiter stands out a bit: The suggested name comes without /software/ as second name, while many mirrors under operations have /software/ as second component. Also, we already have the repo operations/debs/envoyproxy, where it's envoyproxy not envoy. Those two items would lead me to think that maybe operations/software/envoyproxy/ratelimiter or even operations/software/envoyproxy-ratelimiter would better fit the hierarchy. But I'm of course fine with a plain operations/envoy-ratelimiter too. Just double-checking since we cannot move repos in Gerrit --QChrisNonWMF (talk) 07:58, 21 July 2020 (UTC)
I think you're right - operations/software/envoyproxy/ratelimiter is probably the best option, thanks for checking! --HNowlan (WMF) (talk) 09:30, 21 July 2020 (UTC)

Yes Done Created as operations/software/envoyproxy/ratelimiter

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 21:42, 21 July 2020 (UTC)

mediawiki/services/wikispeech/wikispeech_mockup Karl Wettin (WMSE), Merge review This is a request to delete the repository, not create it. I couldn't find where to go for this. Request is a continuation of requesting repo ./wikispeech-server which is the new name of the project, to which we have pushed the history from ./wikispeech_mockup. Karl Wettin (WMSE) (talk) 13:48, 22 July 2020 (UTC) Yes Done We normally don't delete projects, but archive them. There's a form on phabricator to kick off the process https://phabricator.wikimedia.org/maniphest/task/edit/form/33/ I've filed it at task T259550 and did all the tasks directly related to the repo itself. I'm not sure of some of the other items on that ticket (E.g.: translation integration) and I'll leave them to you as I assume you know more about that than I do. If you run into issues with that, need help or whatever, feel free to ping me again. --QChrisNonWMF (talk) 20:13, 3 August 2020 (UTC)
analytics/wmde/TW/template-survey awight Merge review Please import the initial repository from git@gitlab.com:adamwight/template-survey.git --Adamw (talk) 12:17, 28 July 2020 (UTC) Yes Done Created as analytics/wmde/TW/template-survey

(GitHub mirror)(Phabricator mirror)

As the repo lacks a master branch, I assume things will still shift around a bit, and I did not create a .gitreview file for now to avoid the file being in the way. If you want me to add one, just let me know. But I of course imported the repo's local_dev branch. --QChrisNonWMF (talk) 19:29, 3 August 2020 (UTC)


mediawiki-extensions-DrawioEditor rvogel Merge review This is an existing unmaintained extension. I have requested maintainership of this extension on the official origin some month ago: https://github.com/mgeb/mediawiki-drawio-editor/issues/19

Please import from https://github.com/hallowelt/mediawiki-extensions-DrawioEditor

Yes Done Created as mediawiki/extensions/DrawioEditor

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 19:19, 3 August 2020 (UTC)


WD_referenceHunt GoranSMilovanovic Merge review (1) This should go under analytics/wmde/WD/ (2) please just initialize an empty repository GoranSM (talk) 18:07, 30 July 2020 (UTC) Yes Done Created as analytics/wmde/WD/WD_referenceHunt

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 19:31, 3 August 2020 (UTC)


operations/debs/karma Filippo Giunchedi Merge review Please inherit perms from operations/debs --Filippo Giunchedi (talk) 12:27, 31 July 2020 (UTC) Yes DoneMarcoAurelio (talk) 11:52, 2 August 2020 (UTC)
wikimedia-ch/wmch-infrastructure Valerio Bozzolan Merge review If you want you can do a first push from https://gitpull.it/source/wmch-infrastructure/. This request is the follow up of phab:T256455 (it seems not possible anymore to request a Diffusion repository). --Valerio Bozzolan (talk) 06:22, 4 August 2020 (UTC) @Valerio Bozzolan: We do not have a wmch hierarchy in our gerrit yet. IIRC, the only other chapter we have repos for is CZ, which are under wikimedia-cz, so I wondered if we could keep things alike in the hierarchy and start with wikimedia-ch at the top level instead of wmch? Underneath that, you can pick whatever you want. For example wikimedia-ch/wmch-infrastructure (so default clones would end up in a wmch-* directory as with the name you luggested), wikimedia-ch/wikimedia-ch-infrastructure (which would give the same duplication of the name as with the name you suggested), wikimedia-ch/infrastructure (no wikimedia-ch indicator, as it's part of the hierarchy), or some other scheme. --QChrisNonWMF (talk) 05:45, 6 August 2020 (UTC)
@QChrisNonWMF: Thank you. I've updated this request to reflect your suggestions. --Valerio Bozzolan (talk) 07:52, 6 August 2020 (UTC)

Yes Done Created as wikimedia-ch/wmch-infrastructure

(GitHub mirror)(Phabricator mirror)

I've granted Submit to both Project Owners and Jenkins-bot. If that's too permissive, either dial back yourself, or let me know and I'll make it more restrictive for you. --QChrisNonWMF (talk) 10:18, 6 August 2020 (UTC)

operations/debs/grafana-plugins Filippo Giunchedi Merge review Please inherit permissions from operations/debs --Filippo Giunchedi (talk) 14:40, 5 August 2020 (UTC) Yes Done Created as operations/debs/grafana-plugins

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 05:47, 6 August 2020 (UTC)

analytics/wmf-product/jobs bearloga Merge review T230743 --MPopov (WMF) (talk) 15:25, 5 August 2020 (UTC) Yes Done Created as analytics/wmf-product/jobs

(GitHub mirror)(Phabricator mirror) --QChrisNonWMF (talk) 05:51, 6 August 2020 (UTC)