User talk:Cscott

From mediawiki.org
Jump to navigation Jump to search

Language variants[edit]

Hi. I noticed some consistent problems, and had some thoughts, and collated them all at Talk:Localisation statistics#en-GB and en-CA - notes, after bouncing them off some helpful folks in IRC (thanks Reedy and MatmaRex!). It was further suggested that yourself and liangent would be the best people to bounce it off next (as this is potentially related to Language Converter), hence I'm requesting your input there.

(Disclosure: My personal bias, as a UK-grown, Canadia-residing, US-media absorbing individual, is that w:WP:ENGVAR works well, and these 2 interface-variants are silly.) Thanks for any thoughts you might have, at that thread! –Quiddity (talk) 23:33, 18 September 2013 (UTC)

git review -s[edit]

Hi, you wrote in Gerrit/Advanced usage:

Then you can use "gerrit" instead.
git review -s adds a gerrit remote to git which should make this step unnecessary. Cscott (talk)

which does not work for me: git: 'review' is not a git command. See 'git --help'. maybe, you can clarify? --Purodha Blissenbach (talk) 17:19, 15 October 2013 (UTC)

You need to install git-review as described in Gerrit/Tutorial#Installing_git-review. Once you've done that it will work. cscott (talk) 18:02, 15 October 2013 (UTC)

Requests for comment/Allow styling in templates[edit]

Hi, Requests for comment/Allow styling in templates is being considered as one of the RFCs to be discussed at the RFC review on 2013-11-06 via IRC. You are receiving this notification because you edited or discussed this RFC. We hope to see you there.--Qgil (talk) 00:42, 5 November 2013 (UTC)

Parsoid and VisualEditor[edit]

Hi Scott,

I saw you fixed some of my edits on Extension:VisualEditor. However, it does not seem to work the way you wrote it - at least not in my tests.

You say that Parsoid does not need to be installed in order for VisualEditor to work. However, this does not seem to be the case: For me, if Parsoid is not installed, MediaWiki cannot load the page content into VisualEditor. It ends up calling https://wiki.example.org/wiki/rest.php/wiki.example.org/v3/page/html/Main_Page?redirect=false&stash=true, which returns an error 404. With Parsoid loaded, this is working...

Am I configuring this incorrectly?

I am testing this with the 1.35 release version btw.

Jörg

Hi, Jörg. The way I've described it is the way it is intended to work in 1.35, as implemented in phab:T248343. It is possible there is some corner case that is missing; please file a phab task with more details of your LocalSettings.php and we can try to track it down. I suspect you have some existing $wgVirtualRestConfig settings which are causing VisualEditor to assume you have a separate Parsoid service installed. cscott (talk) 17:51, 5 October 2020 (UTC)
Thanks for the answer, Scott!
Before I installed VisualEditor, I did not have a configuration for $wgVirtualRestConfig in LocalSettigs.php. I have added this:
$wgVirtualRestConfig['modules']['parsoid'] = array(
    // URL to the Parsoid instance.
    'url' => $wgServer . $wgScriptPath . '/rest.php',
    // Parsoid "domain", see below (optional, rarely needed)
    // 'domain' => 'localhost',
);
Is that incorrect? --Jörgi123 (talk) 18:14, 5 October 2020 (UTC)
Yes, that is incorrect.
https://www.mediawiki.org/w/index.php?title=Extension:VisualEditor&type=revision&diff=4156348&oldid=4156337&diffmode=source
You should not set $wgVirtualRestConfig if you want to use the built-in Parsoid instance. I've updated the docs to make this clearer. cscott (talk) 20:19, 5 October 2020 (UTC)
Ok, I have fixed that now. I have removed $wgVirtualRestConfig['modules']['parsoid'] from my config and I am no longer loading Parsoid manually. The editor now shows up and is showing page content. I have set $wgVisualEditorRestbaseURL = $wgServer . $wgScriptPath . '/rest.php/wiki.example.org/v3/page/html/';. I hope that is more or less correct? ;-)
However, trying to save a page fails. In the NGINX access log I am seeing a request like this one:
POST /wiki/rest.php/wiki.example.org/v3/transform/html/to/wikitext/Main_Page/82704 HTTP/2.0" 403 69 "-" "VisualEditor-MediaWiki/1.35.0"
I am currently not sure, why I am getting an error 403 there... Thanks again for your input! --Jörgi123 (talk) 21:06, 5 October 2020 (UTC)
You should not need $wgVisualEditorRestbaseURL either. (What install instructions were you following?) You should literally need nothing but wfLoadExtension('VisualEditor') in your LocalSettings.php. cscott (talk) 21:12, 5 October 2020 (UTC)
I tried following Extension:VisualEditor, but when this did not work out, I started digging...
I now have also removed $wgVisualEditorRestbaseURL, wich I had set before. It seems to be working now, which is strange as this should be exactly the config I once started with and which did not work back then... --Jörgi123 (talk) 21:44, 5 October 2020 (UTC)
Glad you've got it working! I updated the docs for both Parsoid and VisualEditor --- looks like there were a number of edits since I originally wrote them that could have send you down the wrong path. But things look right now. Anyway, have fun w/ VE! cscott (talk) 23:01, 5 October 2020 (UTC)
Thank you very much! It is a neat tool, really makes editing a nicer experience. I am glad to be able to provide it to our users. --Jörgi123 (talk) 16:01, 6 October 2020 (UTC)