Jump to navigation Jump to search

Code review activity[edit]

MZMcBride, could you expand your reports to add something about code review activity including CR (with or without vote) of all revisions and not just the merged one? It should be possible with stuff like [1] ([2]) despite [3] [4]. --Nemo 08:26, 8 July 2013 (UTC)

I'm not sure the Gerrit Web API supports this. Do you know?
My reports build a local database and then query that. If it's possible to get code review information (-2, +1, etc.), that'd be a wonderful addition to the current database. --MZMcBride (talk) 13:33, 11 July 2013 (UTC)
It is, see above and [5]. Just not for all revisions (I was corrected [6]). --Nemo 13:41, 11 July 2013 (UTC)
In which report would you like to see this information incorporated? How would you like to see this information incorporated? --MZMcBride (talk) 15:43, 11 July 2013 (UTC)
I already created the very simple tools:~nemobis/crstats/, but I'd like 1) to exclude self-merges, 2) to have some on-wiki report that (thanks to history) allows to monitor CR activity over time (rather than just CR backlog like now). If you use a DB you could even fetch all the CR votes before they are hidden by new revisions, but this may be too much to ask. :)
As for existing reports, you could perhaps A) split the column "New" in Gerrit/Reports/Changesets by project to add totals of CR votes for each of them, B) the same for the two columns in Gerrit/Reports/Open changesets by owner. However A-B are less useful than 1-2, IMHO. --Nemo 20:36, 11 July 2013 (UTC)

I think it'd be good to have:

  • Open changesets by lowest number of reviewers (useful as every change needs at least one real reviewer, I think)
  • Changesets by highest number of reviewers (mostly for curiosity)
  • Changesets by highest number of patchsets (mostly for curiosity)

I'm still not sure what to do with code review points, particularly for changesets with multiple patchsets. Are you only interested in merges (what I'll consider to be +2) or are you interested in -1, -2, and +1 as well?

Also, the code is here: <>. Pull requests welcome. :-) --MZMcBride (talk) 05:06, 12 July 2013 (UTC)

Yes, those three reports would be curious. +2 are the only thing which is easy to measure reliably (the last patchset has it by necessity), +1/-1 would be nicer to capture in an on wiki report. Something else you could do is making Gerrit/Reports/Changesets by status more useful: columns could be split in mediawiki/core, mediawiki/* and all, and the row for the open commits be split in all and "NOT label:Code-Review<=-1" as with the query originally provided by Robla to measure status of CR backlog. --Nemo 06:44, 12 July 2013 (UTC)