Topic on Talk:Continuous integration/Codehealth Pipeline

Duplicated lines in Messages*.php files

3
Amire80 (talkcontribs)

Hi,

I make many patches that add support for new languages. Today I saw a "duplicated lines" notification for the first time at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/749150

Messages*.php files are repetitive by their nature. They should probably be changed to something more structured, that uses less raw repetitive code, but until then, can they be excluded from this check?

Jdforrester (WMF) (talkcontribs)

Not practically. Just ignore them. The CodeHealth pipeline is advisory for a reason.

Brooke Vibber (WMF) (talkcontribs)

I get this in TimedMediaHandler's WebVideoTranscodes.php which has an enormous array of data definitions. :D To be honest it wouln't hurt to redefine those in a more sensible way, it's just mildly annoying to make it backwards-compatible with static class constants :D

(For the time being I'm ignoring it but plan to refactor these when time permits.)

Reply to "Duplicated lines in Messages*.php files"