Skin talk:Minerva Neue
Add topic
Archives
|
|---|
Phabricator "MinervaNeue (Tracking)" column
[edit]I've recently noticed a couple of Phabricator tasks that got moved into the #MinervaNeue (Tracking) column (which states in its description that it's for issues affecting Minerva outside of the Minerva codebase), where the MinervaNeue repository does appear to contain code that affects the tasks in question. The examples I noticed were T373968, which seems like it's at least partially affected by a rule in skinStyles/mediawiki.diff.styles.less; & T372534, which seems like it's taking issue with a different rule in the same file.
I'm starting a discussion here as this involves multiple Phabricator tasks, and I'm not immediately aware of a better venue (please tell me if there is one, though!). Courtesy ping Jdlrobson, as I noticed you moving a few tasks to that column earlier this month, and so you may be able to advise on what best practice here is :)
All the best, —a smart kitten[meow] 12:56, 26 January 2025 (UTC)
- Typically we hide things in Minerva as a last resort where a feature was not made in a way that is friendly on mobile. The long term goal would be to remove this code altogether.
- The description for tracking is correct. In these two examples you provide, while it is correct that changes in Minerva would be required, these would only be to remove the 'display: none' in Minerva and thus allow any upstream styles to apply. The bulk of the work needs to be happening in the diff code first. If we were to remove the hiding rule in Minerva first we would be surfacing very bad experiences. Therefore the tag reflects the codebase where the majority of the work needs to take place. Does that make sense? Jdlrobson (talk) 23:30, 26 January 2025 (UTC)
- @Jdlrobson: Yep, that makes sense. I think for T373968, I might have been confused because (judging by T243235) the CSS in question was added to prevent an issue with two icons appearing on top of each other that I believe would now no longer occur; however, if it's been determined that having the icon visible would continue to present a worse experience, having it in the tracking column makes sense. Thank you for explaining :) —a smart kitten[meow] 22:34, 3 February 2025 (UTC)