Extension talk:GoogleLogin

Previous page history was archived for backup purposes at Extension talk:GoogleLogin/LQT Archive 1 on 2015-06-25.

Getting this error after successful authentication.

Full stacktrace below.

Using:

MediaWiki version 1.37.2

PHP 7.4.28 (fpm-fcgi)

GoogleLogin: REL1_38 2022-08-31T06:12:06

I have found references to this sort of error as relating to a PHP version problem, but I don't want to jump into attempting to upgrade to PHP 8.1 as that may cause other problems. I have looked at earlier versions of the plugin but still see the keyword `static` used there. Not sure how to proceed. Any advice will be appreciated.

p.s. it may be relevant that I am not an experienced PHP developer (in case the solution is obvious to someone who is).

**************************

[148aa09dbbe238d574188361] /wiki/Special:UserLogin ParseError: syntax error, unexpected 'static' (T_STATIC)

Backtrace:

from /bitnami/mediawiki/extensions/GoogleLogin/vendor/psr/cache/src/CacheItemInterface.php(75)

#0 /opt/bitnami/mediawiki/vendor/composer/ClassLoader.php(428): Composer\Autoload\includeFile()

#1 [internal function]: Composer\Autoload\ClassLoader->loadClass()

#2 /bitnami/mediawiki/extensions/GoogleLogin/vendor/google/auth/src/Cache/Item.php(29): spl_autoload_call()

#3 /opt/bitnami/mediawiki/vendor/composer/ClassLoader.php(571): include(string)

#4 /opt/bitnami/mediawiki/vendor/composer/ClassLoader.php(428): Composer\Autoload\includeFile()

#5 [internal function]: Composer\Autoload\ClassLoader->loadClass()

#6 /bitnami/mediawiki/extensions/GoogleLogin/vendor/google/auth/src/Cache/MemoryCacheItemPool.php(62): spl_autoload_call()

#7 /bitnami/mediawiki/extensions/GoogleLogin/vendor/google/auth/src/Cache/MemoryCacheItemPool.php(45): Google\Auth\Cache\MemoryCacheItemPool->getItems()

#8 /bitnami/mediawiki/extensions/GoogleLogin/vendor/google/apiclient/src/AccessToken/Verify.php(194): Google\Auth\Cache\MemoryCacheItemPool->getItem()

#9 /bitnami/mediawiki/extensions/GoogleLogin/vendor/google/apiclient/src/AccessToken/Verify.php(105): Google\AccessToken\Verify->getFederatedSignOnCerts()

#10 /bitnami/mediawiki/extensions/GoogleLogin/vendor/google/apiclient/src/Client.php(814): Google\AccessToken\Verify->verifyIdToken()

#11 /bitnami/mediawiki/extensions/GoogleLogin/includes/Auth/GooglePrimaryAuthenticationProvider.php(414): Google\Client->verifyIdToken()

#12 /bitnami/mediawiki/extensions/GoogleLogin/includes/Auth/GooglePrimaryAuthenticationProvider.php(55): GoogleLogin\Auth\GooglePrimaryAuthenticationProvider->getVerifiedToken()

#13 /opt/bitnami/mediawiki/includes/auth/AuthManager.php(598): GoogleLogin\Auth\GooglePrimaryAuthenticationProvider->continuePrimaryAuthentication()

#14 /opt/bitnami/mediawiki/includes/specialpage/AuthManagerSpecialPage.php(374): MediaWiki\Auth\AuthManager->continueAuthentication()

#15 /opt/bitnami/mediawiki/includes/specialpage/AuthManagerSpecialPage.php(502): AuthManagerSpecialPage->performAuthenticationStep()

#16 /opt/bitnami/mediawiki/includes/htmlform/HTMLForm.php(718): AuthManagerSpecialPage->handleFormSubmit()

#17 /opt/bitnami/mediawiki/includes/specialpage/AuthManagerSpecialPage.php(435): HTMLForm->trySubmit()

#18 /opt/bitnami/mediawiki/includes/specialpage/LoginSignupSpecialPage.php(318): AuthManagerSpecialPage->trySubmit()

#19 /opt/bitnami/mediawiki/includes/specialpage/SpecialPage.php(647): LoginSignupSpecialPage->execute()

#20 /opt/bitnami/mediawiki/includes/specialpage/SpecialPageFactory.php(1366): SpecialPage->run()

#21 /opt/bitnami/mediawiki/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath()

#22 /opt/bitnami/mediawiki/includes/MediaWiki.php(930): MediaWiki->performRequest()

#23 /opt/bitnami/mediawiki/includes/MediaWiki.php(564): MediaWiki->main()

#24 /opt/bitnami/mediawiki/index.php(53): MediaWiki->run()

#25 /opt/bitnami/mediawiki/index.php(46): wfIndexMain()

#26 {main}

Hello! The issue is because a dependency, psr-cache is being upgraded with PHP8 type annotation. To make it work, you can simply remove all these annotations. For reference, you can change the file to this version: /php-fig/cache/blob/1802493cb2032e070c30d6dbe091ce7edf5d5231/src/CacheItemInterface.php on GitHub

(I could not paste the full link since the spam filter won't let me post, sorry)

could you please elaborate on this. thank you

Hello! I turned on GoogleLogin capabilities shortly after creating a wiki. When I did so, the user I first created on install didn't have my email on it. Now I can't log in to that user while GoogleLogin is enabled, and my google user doesn't have admin privileges. I can't even use the UserRights special page because the @ symbol makes it think I'm going to a different wiki.

So even if I do turn off GoogleLogin for now, I still can't add that user as an Admin. And since the user was created I can't delete it and add the email to my user to "recreate"/link my google user to my admin account.

All of this to effectively say there is no admin on my wiki now as long as GoogleLogin is active. And one of the things I want to be able to do is restrict page creation for non admins.

Any help would be appreciated.

When $wgGroupPermissions['*']['read'] = false; is enabled the google Login extension is not working

Message : The public suffix array file does not exist at the expecte dlocation: /public_html/extensions/GoogleLogin/includes/AllowedDomains/../../publicSuffixArray.php. Have you forgotten to run the updatePublicSuffixArray.php maintenance script to create it?

I tried to execute the file updatePublicSuffixArray.php but this doesn't make change

Wikimedia version 1.37.1, GoogleLogin version 1.37 PHP version 7.4.29

I reported this with task T300163.

Hello,

Does this work with Mediawiki 1.37? I upgraded to 1.37 and it broke, saying:

/wiki/index.php/Special:UserLogin ParseError: syntax error, unexpected 'I,' expecting variable (T_VARIABLE)

I am using latest version of the plugin and PHP 7.4.

Never mind, I just saw the thread below and that fixed it. I changed the line

public function expiresAfter(int|\DateInterval|null $time);

to

public function expiresAfter($time);

all good!

Hello, I'm a newbie. Sorry for any formatting or bad behavior.

I faced the same issue as described here: Topic:Wf2n897r3c3apos6

Since MediaWiki 1.36 stable doesn't support PHP8, the version released for MediaWiki 1.36 shouldn't either, so if you want to make GoogleLogin's latest release work with MediaWiki 1.36, just make this change:

In <wiki-root>/extensions/GoogleLogin/vendor/psr/cache/src/CacheItemInterface.php,

Change the declaration of public function expiresAfter(...); to public function expiresAfter($time); . That's all. It seems to be working good so far for me. Can we patch the included dependency (psr-cache, which now says that it requires PHP >= 8.0 on some package describing website) to make the same change, just for these MediaWiki releases?

@Beautiful Pomegrenate - Thank you so much, that fixed my ParseError Issue for Topic:Wf2n897r3c3apos6!!

Hi. Thanks for all of your great work with this plugin. I want to share my experience while it is still fresh in my memory and on the back of installing a similar plugin on Wordpress as I think it may be beneficial.

Issues encountered:

Default login still works when clicking "Login with Google":

To reproduce: Enter username and password in login form & click "Login with Google". Expected: Redirect to Google for auth. Actual: logged in using local credentials. Use case: Form saved login details auto-populated but do not wish to login with those credentials or as that user.

Google Auth requires Google+ API:

My recent experience with a Wordpress plugin did not require this and used the email address only for the purpose of identifying a unique user. Is this required due to a limitation in Mediawiki authentication?

"The supplied credentials are not associated with any user on this wiki":

Even though my email address matches my Google email, I am not recognised after authenticating with Google. This suggests that the email address is not the unique identifier or there is some other error I am unaware of? There is nothing that I can see in the documentation to indicate what constitutes identification of a mediawiki user utilising the returned data from Google oauth/API.

Thank you.

You're right. The GoogleLoign extension requires the user to have a Google+ account. This is mainly used for account-creation, where the display name of the Google+ account is used as the username of the MediaWiki user. However, I also use the email address from the Google+ response for the login process, which means, that this will also fail, if the user does not have a Google+ account, even if we can get the email from the id_token only. I'm unsure how to proceed here, now, as a change seems to be somewhat a breaking change, that's why I opened task T198439 to track this issue :)

Ok, the task I mentioned above is resolved now, which removes the need of the profile scope (which should also remove a user to need a Google+ account).

To the other things:

> Default login still works when clicking "Login with Google":

This is part of the auto-configuration of GoogleLogin. When you enter the username and password, these credentials takes precendence over the GoogleLogin button click. Now when I think about it, that doesn't really makes sense, as the button click on the GoogleLogin button should take precedence in this case. I'll change the behaviour of the auto-configuration :) However, for now, you can change that yourself by manually adding the GoogleLogin auth provider to the authmanager config, just by adding the following code to your LocalSettings.php:

$wgAuthManagerAutoConfig['primaryauth'] += [ 'GoogleLogin\\Auth\\GooglePrimaryAuthenticationProvider' => [
	'class' => 'GoogleLogin\\Auth\\GooglePrimaryAuthenticationProvider',
	'sort' => 1
] ];

See task T199999

> "The supplied credentials are not associated with any user on this wiki":

Currently, GoogleLogin matches the userId of a MediaWiki account with the Google account ID instead of using the e-mail address. I created task T200000 so we can think about matching users by e-mail, too :) Let's see, what's the feedback there is :)

This was the key for me - on the patch page there were the following notes:

* The E-Mail address returned from Google needs to be the E-Mail in the MediaWiki account to match

* The E-Mail address returned from Google must not be assigned to multiple MediaWiki accounts

* The MediaWiki account e-mail address needs to be verified

The 3rd one was what was getting me - once I authenticated emails, it worked. You can do this manually directly against the database like this:

UPDATE mw_user SET user_email_authenticated = '20210907204043' WHERE user_email_authenticated IS NULL;

The "mw_" before user is just the value set in $wgDBprefix. That varchar value that is being updated is just the date in "YmdHis" format, so you could set it to the time you were running the query. Backup your database first, and potentially just try a single user account to start with!

Hi Florian,

These are my wiki specs below:

Product	Version
MediaWiki]	1.33.0
7.2.19-0ubuntu0.18.04.2 (apache2handler)
5.7.27-0ubuntu0.18.04.1

And I'm trying to enable Authoritative Mode for Google Login as described here. This is what I currently have in my LocalSettings.php:

$wgGLSecret = '-';
$wgGLAppId = '-';
$wgGLAllowedDomains = array( 'url.com' );
$wgGLAllowedDomainsStrict = 'true';
$wgWhitelistRead = array( 'Special:GoogleLoginReturn' );
$wgGLAuthoritativeMode = 'true';
$wgGroupPermissions['*']['autocreateaccount'] = true;
$wgUserrightsInterwikiDelimiter = "%";
$wgInvalidUsernameCharacters = "%";$wgShowExceptionDetails = 'true';

But when I try and log in with Google, it simply states the supplied creds are not associated with any user - which I expect but am I wrong in thinking that because I have authoritative mode enabled - it should then automatically create the new account since its not linked with a local mediawiki account?

Keen to hear your thoughts.

Hi,

are you using the REL1_33 release branch of Google Login? If so, this version does not support the authoritative mode. You would need to download a new copy of GoogleLogin using the latest development version "master" in order to get this feature :-)

Best, Florian

This was the key for me - on the patch page there were the following notes:

* The E-Mail address returned from Google needs to be the E-Mail in the MediaWiki account to match

* The E-Mail address returned from Google must not be assigned to multiple MediaWiki accounts

* The MediaWiki account e-mail address needs to be verified

The 3rd one was what was getting me - once I authenticated emails, it worked. You can do this manually directly against the database like this:

UPDATE mw_user SET user_email_authenticated = '20210907204043' WHERE user_email_authenticated IS NULL;

The "mw_" before user is just the value set in $wgDBprefix. That varchar value that is being updated is just the date in "YmdHis" format, so you could set it to the time you were running the query. Backup your database first, and potentially just try a single user account to start with!

Resolved by updating to PHP8

I am getting the following error when I try to login with a google account. Not quite sure what went wrong. Googling doesn't seem to have given me any good answers.

Internal Error

[4b497c88a9e2a00cf549c682] /index.php?title=Special:UserLogin&returnto=Main+Page ParseError: syntax error, unexpected '|', expecting variable (T_VARIABLE) Backtrace: from /var/www/mediawiki/extensions/GoogleLogin/vendor/psr/cache/src/CacheItemInterface.php(104)

1. 0 /var/www/mediawiki/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
2. 1 [internal function]: Composer\Autoload\ClassLoader->loadClass()
3. 2 /var/www/mediawiki/extensions/GoogleLogin/vendor/google/auth/src/Cache/Item.php(25): spl_autoload_call()
4. 3 /var/www/mediawiki/vendor/composer/ClassLoader.php(444): include(string)
5. 4 /var/www/mediawiki/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile()
6. 5 [internal function]: Composer\Autoload\ClassLoader->loadClass()
7. 6 /var/www/mediawiki/extensions/GoogleLogin/vendor/google/auth/src/Cache/MemoryCacheItemPool.php(54): spl_autoload_call()
8. 7 /var/www/mediawiki/extensions/GoogleLogin/vendor/google/auth/src/Cache/MemoryCacheItemPool.php(43): Google\Auth\Cache\MemoryCacheItemPool->getItems()
9. 8 /var/www/mediawiki/extensions/GoogleLogin/vendor/google/apiclient/src/AccessToken/Verify.php(184): Google\Auth\Cache\MemoryCacheItemPool->getItem()
10. 9 /var/www/mediawiki/extensions/GoogleLogin/vendor/google/apiclient/src/AccessToken/Verify.php(100): Google\AccessToken\Verify->getFederatedSignOnCerts()
11. 10 /var/www/mediawiki/extensions/GoogleLogin/vendor/google/apiclient/src/Client.php(793): Google\AccessToken\Verify->verifyIdToken()
12. 11 /var/www/mediawiki/extensions/GoogleLogin/includes/Auth/GooglePrimaryAuthenticationProvider.php(414): Google\Client->verifyIdToken()
13. 12 /var/www/mediawiki/extensions/GoogleLogin/includes/Auth/GooglePrimaryAuthenticationProvider.php(55): GoogleLogin\Auth\GooglePrimaryAuthenticationProvider->getVerifiedToken()
14. 13 /var/www/mediawiki/includes/auth/AuthManager.php(559): GoogleLogin\Auth\GooglePrimaryAuthenticationProvider->continuePrimaryAuthentication()
15. 14 /var/www/mediawiki/includes/specialpage/AuthManagerSpecialPage.php(374): MediaWiki\Auth\AuthManager->continueAuthentication()
16. 15 /var/www/mediawiki/includes/specialpage/AuthManagerSpecialPage.php(502): AuthManagerSpecialPage->performAuthenticationStep()
17. 16 /var/www/mediawiki/includes/htmlform/HTMLForm.php(715): AuthManagerSpecialPage->handleFormSubmit()
18. 17 /var/www/mediawiki/includes/specialpage/AuthManagerSpecialPage.php(435): HTMLForm->trySubmit()
19. 18 /var/www/mediawiki/includes/specialpage/LoginSignupSpecialPage.php(320): AuthManagerSpecialPage->trySubmit()
20. 19 /var/www/mediawiki/includes/specialpage/SpecialPage.php(646): LoginSignupSpecialPage->execute()
21. 20 /var/www/mediawiki/includes/specialpage/SpecialPageFactory.php(1386): SpecialPage->run()
22. 21 /var/www/mediawiki/includes/MediaWiki.php(309): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
23. 22 /var/www/mediawiki/includes/MediaWiki.php(913): MediaWiki->performRequest()
24. 23 /var/www/mediawiki/includes/MediaWiki.php(546): MediaWiki->main()
25. 24 /var/www/mediawiki/index.php(52): MediaWiki->run()
26. 25 /var/www/mediawiki/index.php(45): wfIndexMain()
27. 26 {main}

My config:

wfLoadExtension( 'GoogleLogin' );

$wgGLSecret = '*****';

$wgGLAppId = '*****.apps.googleusercontent.com';

$wgWhitelistRead = array( 'Special:GoogleLoginReturn' );

$wgGLAllowedDomains = array( '*****.com' );

$wgShowExceptionDetails = true;

$wgInvalidUsernameCharacters = '#€';

$wgGroupPermissions['*']['autocreateaccount'] = true;