Topic on Project:Support desk

MediaWiki 1.35.0

PHP 7.4.3 (fpm-fcgi)

SQLite 3.31.1

When I run update.php, I get this error.

Adding module field to table oathauth_users ...Wikimedia\Rdbms\DBQueryError from line 1699 of /var/www/site/html/includes/libs/rdbms/database/Database.php: Error 1: near ",": syntax error

Function: Wikimedia\Rdbms\Database::sourceFile( /var/www/site/html/extensions/OATHAuth/sql/mysql/patch-add_generic_fields.sql )

Query: ALTER TABLE oathauth_users

ADD module TEXT NOT NULL,

ADD data BLOB NULL

#0 /var/www/site/html/includes/libs/rdbms/database/Database.php(1683): Wikimedia\Rdbms\Database->getQueryException()

#1 /var/www/site/html/includes/libs/rdbms/database/Database.php(1658): Wikimedia\Rdbms\Database->getQueryExceptionAndLog()

#2 /var/www/site/html/includes/libs/rdbms/database/Database.php(1227): Wikimedia\Rdbms\Database->reportQueryError()

#3 /var/www/site/html/includes/libs/rdbms/database/Database.php(5075): Wikimedia\Rdbms\Database->query()

#4 /var/www/site/html/includes/libs/rdbms/database/Database.php(5010): Wikimedia\Rdbms\Database->sourceStream()

#5 /var/www/site/html/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->sourceFile()

#6 /var/www/site/html/includes/libs/rdbms/database/MaintainableDBConnRef.php(35): Wikimedia\Rdbms\DBConnRef->__call()

#7 /var/www/site/html/includes/installer/DatabaseUpdater.php(727): Wikimedia\Rdbms\MaintainableDBConnRef->sourceFile()

#8 /var/www/site/html/includes/installer/DatabaseUpdater.php(801): DatabaseUpdater->applyPatch()

#9 /var/www/site/html/includes/installer/DatabaseUpdater.php(512): DatabaseUpdater->addField()

#10 /var/www/site/html/includes/installer/DatabaseUpdater.php(480): DatabaseUpdater->runUpdates()

#11 /var/www/site/html/maintenance/update.php(181): DatabaseUpdater->doUpdates()

#12 /var/www/site/html/maintenance/doMaintenance.php(107): UpdateMediaWiki->execute()

#13 /var/www/site/html/maintenance/update.php(253): require_once('/var/www/access...')

#14 {main}

file a bug at https://phabricator.wikimedia.org being sure to tag it as mediawiki-extensions-oathauth and sqlite.

The schema was not written for SQLite, it was probably just hoped it would work with MySQL syntax, so it's not surprising it doesn't, giving the many limitations of SQLite on ALTER command.

ALTER TABLE /*_*/ oathauth_users ADD module VARCHAR( 255 ) NOT NULL, ADD data BLOB NULL;

The first ADD command specifies a NOT NULL constraint but there's no default value. In SQLite, a non-NULL default is necessary when a NOT NULL constraint is specified.

Reported at https://phabricator.wikimedia.org/T264492

It looks like it's fixed?

https://phabricator.wikimedia.org/T264492

Could someone give me an instruction on how to apply the patch?

just download a new version from Special:ExtensionDistributor

(If you really want to know how to apply patches see https://man7.org/linux/man-pages/man1/patch.1.html but easier to just get a new copy of extension)