Topic on Talk:Requests for comment/Isolate custom jQuery libraries

already loading Spinner, other spinner notes

3 comments • 10:30, 10 July 2015 8 years ago

3

SPage (WMF) (talkcontribs)

Nearly all WMF wikis load TimedMediaHandler and on 'BeforePageDisplay' it adds module 'mw.PopUpMediaTransform', which depends on Spinner.js, an earlier version of fgnass's code. TMH uses it to render a fairly large "loading" animation over media players.

It would be nice to only use one spinner library. bug 55550 is to reduce resource code loaded by TMH and MwEmbedSupport. A lot of extensions roll their own spinner, including I think ApiSandbox, Flow, LiquidThreads, UploadWizard...

BTW WMF still has a lot of code using (window.)injectSpinner() and removeSpinner from wikibits.js, even though it's deprecated.

This post was posted by SPage (WMF), but signed as S Page (WMF).

Reply Edited by Flow talk page manager 10:30, 10 July 2015 8 years ago

He7d3r (talkcontribs)

BTW: See also bugzilla:56201.

Reply 12:02, 26 October 2013 10 years ago

Matma Rex (talkcontribs)

Global injectSpinner() and removeSpinner() no longer exist now. (I hope that whoever was using them no longer does ;) )

Reply 14:05, 27 November 2013 10 years ago

Reply to "already loading Spinner, other spinner notes"