Manual talk:Hooks/PageContentSaveComplete

From MediaWiki.org
Jump to navigation Jump to search

Is this hook still used? I did not find anything in WikiPage class from MediaWiki installations 1.8 nor 2.0. Also tried to find text "PageContentSaveComplete" from all of my MediaWiki 2.0 files and did not find anything. Hook ArticleSaveComplete states that it is deprecated and this hook should be used instead but if this hook has disappeared from MediaWiki installations, that text should be removed. (unsigned text by User:Kulttuuri)

It still is used; maybe the filename is wrong. --88.130.92.147 15:34, 2 November 2014 (UTC)
See includes/page/WikiPage.php --Shirayuki (talk) 22:07, 2 November 2014 (UTC)
Obviously...I swear searching the file I did not find it before writing the above...Hmmm. --88.130.112.113 22:09, 2 November 2014 (UTC)

The page claims that undidRevId was "added in MW 1.30", but that doesn't seem like quite the full story. In 1.29.3, in fact, it looks like *one* of the places where the `PageContentSaveComplete` hook is run passes twelve args including that one, but the *other* passes eleven args, *not* including that one. So it would be more correct to say it was *partially* added in whatever release 7d7f8e2ae25c4be411d015e6ddb5992f3a56e931 first appeared in, and *fully* added in 1.30, I think... AdamWill (talk)