Front-end standards group/2016-10-12

From MediaWiki.org
Jump to navigation Jump to search

Attending: Volker E., Roan K., Jan D., Jon R., Ed S.

Social[edit]

No items in today's meeting.

Action & Code[edit]

New quests[edit]

Please participate in stylelint rules finding for wikimedia-config-stylelint
https://github.com/wikimedia/stylelint-config-wikimedia/issues/3

Should OOjs UI Widgets apply `box-sizing: border-box` as general rule?
https://phabricator.wikimedia.org/T147692
ES: When VE tried this the last time, VE devs got burnt. Injection of DOM where you don't have full control killed the approach.

Examples:

  • VE in MobileFrontend popup
  • AceEditor

Ed Sanders: only DOM elements with width are affected

Jan Drewniak: so if all of visualEditor used border-box...

Roan Kattouw: We can't rewrite ACE to use border-box

ACE or VE is such a large codebase, it isn't feasible to rewrite or play specificity game

Moment.js in core? https://phabricator.wikimedia.org/T146798

RK: jquery.globalize seems like a superior solution
JR: deprecating it
RK: don't think we can get rid of all in core right now
globalize has custom builds, much more modularized
Mediawiki.UI and OOjs UI calendar widget also use moment.js
RK: We probably don't need the C module
globalize uses CLDR which is good

Successes[edit]

Cross-team success: Getting rid of old UI CSS classes throughout our codebase
https://phabricator.wikimedia.org/T146923