Extension:MobileFrontend/Deployments/2013-04-02
Stories[edit]
* https://mingle.corp.wikimedia.org/projects/mobile/cards/446 * Remove need to vary cache on X-Device * https://mingle.corp.wikimedia.org/projects/mobile/cards/396 * Promote Uploads dashboard to stable
* https://mingle.corp.wikimedia.org/projects/mobile/cards/343 * Standardized login/signup CTA from articles
* https://mingle.corp.wikimedia.org/projects/mobile/cards/400 * Uploads dashboard first time user
Bugs[edit]
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46435 (https://mingle.corp.wikimedia.org/projects/mobile/cards/452) * Uploaded via web template no longer being added to uploads
* https://bugzilla.wikimedia.org/show_bug.cgi?id=41519 ( https://mingle.corp.wikimedia.org/projects/mobile/cards/450) * Don't request watch token on every page view
* https://bugzilla.wikimedia.org/show_bug.cgi?id=46480 * MediaWiki:Mobile.css and MediaWiki:Mobile.js no longer loading, breaks 'complex' lists types * https://bugzilla.wikimedia.org/show_bug.cgi?id=46441 * Special:MobileMenu missing icons for watchlist and uploads when JS disabled
Uncategorized[edit]
* Use OutputPage headElement function to generate head element * Localization Changes * Jshint changes * Change diff colors based on input from Vibha and Munaf (Alpha) * Clean up unused variables * Rename jsEnabled class to client-js * Qunit fixes * Remove tumblewee code for WLM banner * Remove disable_zoom now that it's unused * Allow viewport zooming * Stop low resolution main menu icon from404ing * Ensure userlogin.js checks for wfMFLoginHandshakeUrl * Surface talk pages on article (Alpha) * Add Page and Section view * Fix Android Browser quirks in transform * Protect mobile special pages when viewed in desktop mode * Minimal fix for Wikibase related SpecialMobileWatchlist fatal * New RVM setup files * Ruby gems * Kill native_iphone device type
Git Log[edit]
commit 6dedb3ca8dbb1b54bda6227684c4c4085993f68f Author: jrobson <jrobson@wikimedia.org> Date: Sun Mar 31 10:48:33 2013 -0700
Use OutputPage headElement function to generate head element Diff: https://gist.github.com/jdlrobson/5281620 override getPageClasses on SkinTemplate Move any classes on html tag or article tag to body tag Merge specialPage and mw-mf-special classes Use action-edit instead of actionEdit class Deprecate getForceLeftMenu on context and move to special page itself Make it possible for other modules to access main menu Rename noMargins, navigationEnabled, navigationFullScreen to use hypens Change-Id: I42908b734623a48ac32f318f011124486c5f01ae
commit b363d0481b1f1422732b71c308179cbfd8321625 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Mar 22 04:00:20 2013 +0400
WIP: [Card 446] Don't vary page HTML on X-Device Change-Id: I485dbb2e9c2a8c1443c10cb297984407fe523bf8
commit cb86300ff0800ee46073d2c2bad3a8b1786a17d8 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Apr 1 20:43:52 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: If0a4f273b4e08d3444163d1ddaafdea01ed3b338
commit 439906ef3395507526928131b70874d471cd6c9f Author: jrobson <jrobson@wikimedia.org> Date: Mon Apr 1 13:33:04 2013 -0700
fix jshint error declare variable Change-Id: I58f0e9ed2b6da69d9f4492ba88ac2782d86c4a17
commit dd9e56c179319abfc267b58b65b85cf79f3d2d43 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 29 12:10:09 2013 -0700
Add new diff test case for simple insertion Also avoid adding empty del or ins elements in clean diff Change-Id: I97ed3eaf6756cf2fe8a30ab4f768eb9f1b34b1eb
commit 37b34b67bed0bc02c50068f54c546a6e9d7684c2 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 29 11:53:51 2013 -0700
Change diff colors after design input [Alpha] Munaf/Vibha approved diff colors Now Protanopia and Deuteranopia friendly! Add margin right for single characters Change-Id: I7ad474695ecfe9f6265a256b9535e49bc063b682
commit 77c1f38eff784d31a53e2ea0a42bbc1ec8d21f59 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Apr 1 20:06:41 2013 +0200
Add missing dependency carousel.js and uploads.js depend on View and Api which are in mobile.stable. Change-Id: I0b6ad6ebc2d2664fca898b857ab14ecf29c4db8c
commit 7dfb38ea69c8e95e66ffd9f628d11c80c551694e Author: Max Semenik <maxsem.wiki@gmail.com> Date: Mon Apr 1 01:17:27 2013 +0400
rm unused variables Change-Id: I94097f8ed0e5be79f8102e5a0f14f420965162bf
commit fd1ca11e3db175642fed3192a13a3db51677b375 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Mar 31 18:52:28 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I3b0b138c0573d6fa4509dd1dcf112465fe2a3d0c
commit 271c1ad8dcc69ad3c0541a5220805feaa432e29b Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 29 14:26:42 2013 -0700
Go more ResourceLoader native for head scripts and styles Deprecate resourceLoaderLink in process Fixes bug 46480 in process Dependencies (both merged): * https://gerrit.wikimedia.org/r/56694 I795828ac05e2b71499db6a328004be4516849f7d * https://gerrit.wikimedia.org/r/49071 Ie03990e11d9a0ac8cd81dd0aae5c5a95f1d23e81 Change-Id: If68d92130e22991d44705a897ed7d616305cb9d4
commit de2a2b4756bebf31b83e1e0bedbb096567e89f9f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Mar 29 20:41:51 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I6220e48fbaa130a4bacd2c51ca1e682191dd72c7
commit 1c156811db15f9ce7db5b566f23ec50ff59fcdd6 Author: jrobson <jrobson@wikimedia.org> Date: Wed Mar 27 16:26:08 2013 -0700
Rename jsEnabled class to client-js to be consistent with desktop Change-Id: Ic546e3c1994ee34e7dcb10fe039d349ea8f2afc9
commit 3ac7b6c8217291b9279b6cd6415146407655bbd8 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 29 12:01:00 2013 -0700
Minor QUnit test fixes Avoid using globals Tell test how many to expect Change-Id: Ied1cd5f0ae56951bfad37772a0a73dcd251b51b3
commit 370c5e51c53c0fd11a8e0b063d14dbd796f64bb7 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 29 11:25:07 2013 -0700
Remove tumbleweed code for WLM banner This was added to allow banners in WLM. Going forward we should use CentralNotice instead Change-Id: Ibf582717ca2f8c513177b2340c9a1f70c58d2b3e
commit 0f6762bf89f47d6912fbd7886cb4bc239069626b Author: jrobson <jrobson@wikimedia.org> Date: Wed Mar 20 16:47:24 2013 -0700
Story 400: Deal with first time user upload Update photo success handler to show the upload count in case it has been hidden and destroy the carousel Change-Id: Idc891a2b420f1e9b715694519a710c7686e91657
commit b30efe8f6aea912bec603ce037b07b033f629f6c Author: jrobson <jrobson@wikimedia.org> Date: Thu Mar 28 10:09:40 2013 -0700
Bug 41519: Only request token when clicking the star Currently we are making unnecessary token requests. This changes things so we only make one when the user hits the star. Document functions in process Bug 41519 Change-Id: I9512c26a3f7ae020bf604a7b94283821a08606a3
commit 8462e999b4879154d77da905141223b28f7ff3dc Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Mar 29 19:47:56 2013 +0400
Remove disable_zoom now that it's unused Change-Id: Ifca553e4c077ee8c78b8556cc67fa16da55bc175
commit 00c251789d5dd1df330b12c553256e667d044cd9 Author: jrobson <jrobson@wikimedia.org> Date: Wed Mar 27 14:37:21 2013 -0700
Urgent fix: Provide greater expect-ations (fix breaking tests) Make use of expect in qunit tests (see change I214b3d4da46f3f3bb0fcde313ac2d82439e40e3c) Avoid using module and test as a global (All tests are currently failing with latest core so please merge this asap) Change-Id: I545cd1520ac4b0f945b71f76479473bcebe66573
commit 1616948b42e88233ad37a30fbbd7cea75882dce6 Author: jrobson <jrobson@wikimedia.org> Date: Thu Mar 28 16:27:10 2013 -0700
Always allow viewport zooming The changeset that introduced this [1] didn't specify an Opera Mobile browser version Tried against latest Opera Mobile and it is fine so let's throw away [1] I9e3e387cc3454e05156c2e285982eae36cbb85c7 Change-Id: Ia3877bb4cb3c6abc8536b92538c54c33a18e6d9e
commit 30bf812500fc0fbfdddd8bb779560a561d409c47 Author: Raimond Spekking <raimond.spekking@gmail.com> Date: Thu Mar 28 19:42:29 2013 +0000
Revert "Localisation updates from http://translatewiki.net." This override If9f3a2e80548006637e315f526c6ca65db7924ab This reverts commit 7ffd455862291f8cb2c1a00f03e93fe1d15efde6 Change-Id: I87e16b0728ee1061369e79bfffb013aca10f1b89
commit 0d6714da08d852c359bd3b2ea6b45c71f598a41c Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Mar 28 23:09:28 2013 +0400
Off with your head iphone2 You useless piece of junk Change-Id: Ib1a04ae71dfca869d17494f0cf963c654b4d7a0d
commit 7ffd455862291f8cb2c1a00f03e93fe1d15efde6 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Mar 28 19:07:35 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: If9f3a2e80548006637e315f526c6ca65db7924ab
commit fb0d2663e567a41f30fcc2621eaecfeb2ad36794 Author: jrobson <jrobson@wikimedia.org> Date: Thu Feb 28 15:26:46 2013 -0800
Story 396: Make Upload dashboard available on stable Promoted from beta Change-Id: I018c15d20185f9ddbc5c7b07eb37ba1fb5ba4b90
commit 28b129e57050fb27bb65a32ac3213be2cc197324 Author: jrobson <jrobson@wikimedia.org> Date: Wed Mar 27 20:17:28 2013 -0700
Regression: Stop low res main menu icon from 404ing due to move Follow up to I4365f914f95a8b4d1f2d9ab2e37614e835cc2fc5 Change-Id: Id95b18a22fac371b1e0aa7682e18be073305ed2c
commit 0f339b76bd9461a6f84b6ad5d6dac4b51e91975f Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Mar 12 15:59:09 2013 -0700
Add lead photo upload CTA (#343) This introduces a small addition to View, the preRender() function which can be used to manipulate the data which is passed to the template. Change-Id: I77ea2bc2b610b22e266a090374ea24c6af9e4f2c
commit 11fd25d2df8409324dcbc0e0e008a8156f724ee1 Author: awjrichards <arichards@wikimedia.org> Date: Wed Mar 27 16:57:04 2013 -0700
Ensure userlogin.js checks for wgMFLoginHandshakeUrl before handshaking Without this, if you leave wgMFLoginHandhakeUrl == false, this will attempt to redirect you to /null! Change-Id: I92e2ce8fe21682fcd6022f1f0f4296e5fb6c1218
commit a279e4b306c6502f6954baa84d75a45327f14401 Author: jrobson <jrobson@wikimedia.org> Date: Mon Mar 25 18:12:26 2013 -0700
Bug 46441: Move legacy css for menu into mobilemenu.css I was reviewing Ic6fd7585d25a051895e1eea26acb2f4934c97120 to suggest this change but it got merged before I could do so the jsEnabled method is flawed. It also applies to phones with js enabled Older phones can not access the menu without going via Special:MobileMenu page - so putting the fallback css here makes much more sense. In process fix.. Bug 46441 Change-Id: I4365f914f95a8b4d1f2d9ab2e37614e835cc2fc5
commit 46a8b972173fbd903156703e45eb0c07027f5106 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 15 23:10:37 2013 -0500
Alpha: Surface talk pages on article Adds a talk speech bubble to right of article title When clicked opens an overlay showing current discussions For non-js users points to talk page Suggested next steps: Iterate on design Show intermediate menus for smaller subheadings e.g. h3s Allow contributions via overlay (I'd suggest a + icon in the top right corner) Currently doesn't work with dynamic page loads (we should refactor that code to use page.js) Change-Id: I6e206267b754e1851c1223efb249a3830ba963d2
commit b1cb90ad5a05511324dd031f262c6ad3d425c874 Author: jrobson <jrobson@wikimedia.org> Date: Fri Mar 15 23:08:49 2013 -0500
Add Page and Section view Change-Id: I50d8425d030ed8d12ae915d7276d1db443009e71
commit 27307e98b2bcf95ccbbb586099e2422f27b727bf Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Mar 27 20:47:50 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I6487d4ddaa7dc799ef07e40557a09870e48bf7a7
commit 00629ef2fd13a0d23f72ed42b45a60de585c6faa Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Mar 27 01:31:18 2013 +0100
Fix Android Browser quirks in transforms support check Also, load the code responsible for the check only in alpha. Change-Id: Ifed61141c679e33fdcb9ae99136341264d01506b
commit 2018e70a37aa672b4bb81230a05969a34ae0b095 Author: jrobson <jrobson@wikimedia.org> Date: Tue Mar 26 14:49:14 2013 -0700
Protect mobile special pages when viewed in desktop mode When pages are viewed under desktop skin they throw an error. Let's protect them from doing this. Note the FIXME Change-Id: Id003a680f98cee1a376b89e9e5deb098f8947616
commit f869ba2b6990dadaf9939e9ad7c05d59d6f3bdb6 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Mar 26 21:16:14 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I5a7523deb8761cf686ded0d13bb816ee2f4594b4
commit e7b105aaecba23c3e309a9ced8df068b685bd01e Author: Reedy <reedy@wikimedia.org> Date: Tue Mar 26 18:45:37 2013 +0000
Minimal fix for Wikibase related SpecialMobileWatchlist fatal Catchable fatal error: Argument 5 passed to Wikibase\ClientHooks::onSpecialWatchlistQuery() must be an array, none given in /usr/local/apache/common-local/php-1.21wmf12/extensions/Wikibase/client/WikibaseClient.hooks.php on line 311 Change-Id: Ic4e337c3a22388f52e0a515b4ee3aa7c15381d04
commit 1d185d17e713f303337139d0af673cb602e4cd76 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Tue Mar 26 13:52:43 2013 +0100
Switch to new RVM setup files Auto generated with: rvm rvmrc to .ruby-version More information: https://rvm.io/workflow/projects/#ruby-versions Warning message from terminal: You are using '.rvmrc', it requires trusting, it is slower and it is not compatible with other ruby managers, you can switch to '.ruby-version' using 'rvm rvmrc to [.]ruby-version' or ignore this warnings with 'rvm rvmrc warning ignore /Users/z/project/wmf/browsertests/.rvmrc', '.rvmrc' will continue to be the default project file in RVM 1 and RVM 2, to ignore the warning for all files run 'rvm rvmrc warning ignore all.rvmrcs'. Change-Id: I2f4282c9d508fd6f5118ad4b1fb41c67efa5ead9
commit b3d47004b809a4907452aaafea139d5ce8fbd77c Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date: Tue Mar 26 10:35:09 2013 +0100
Updated Ruby gems Change-Id: I67847fb8c8d2a186e65fcbc3dcb0b2c7c75cc732
commit a9d28a360305fe3389546cff6418fe3df9c44ff9 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Mar 23 00:59:06 2013 +0400
Kill native_iphone device type This misleading name covers everything run on iPhone except for Safari and Opera. These various browsers don't need a special treatment just because they're on iPhone. Change-Id: I685c92f2529ed7a539b1108b6034d44876417963