Auth systems/OAuth/IRC log 2013-04-25

From MediaWiki.org
Jump to navigation Jump to search

Apr 26 11:02:58 <csteipp> Hey, sorry I'm a few minutes late. All here?
Apr 26 11:03:06 <anomie> I'm here
Apr 26 11:03:08 <pgehres> I'm here
Apr 26 11:03:36 <csteipp> good enough for topic #1 :)
Apr 26 11:03:54 * Aaron|home lurks
Apr 26 11:03:58 <csteipp> I showed the login on labs to robla today
Apr 26 11:04:12 <csteipp> He was impressed it worked
Apr 26 11:04:18 <anomie> \o/
Apr 26 11:04:35 <csteipp> But, he does think the speed that the javascript check runs may be an issue
Apr 26 11:04:57 <pgehres> RobLa and I chatted about it for about 15 minutes and we think we have a solution
Apr 26 11:05:17 <csteipp> Do share
Apr 26 11:05:32 <pgehres> instead of refreshing the page after js exec, populate the user info via JS
Apr 26 11:05:36 * pgehres was typing :-p
Apr 26 11:05:54 <pgehres> possibly even hide the anon stuff until after exec
Apr 26 11:06:09 <pgehres> which then would be a subtle hint to anons to register
Apr 26 11:06:29 <anomie> "populate the user info" == change skins and load gadgets, user scripts, etc?
Apr 26 11:07:00 <pgehres> there was a certain amount of "screw the skin change" on that first load
Apr 26 11:07:19 <pgehres> but the rest can be lazy loaded, yeah
Apr 26 11:07:21 <anomie> "hide the anon stuff" == more or less document.body.style.display = 'none'?
Apr 26 11:07:53 <pgehres> no, div#p-personal
Apr 26 11:08:20 <pgehres> so that only that changed subtling after execution
Apr 26 11:08:25 <pgehres> *subtly
Apr 26 11:10:17 <anomie> I just wonder how quick people will be to complain that the auto-login doesn't pick up their skin, user scripts, changed preferences, and so on. Thinking it's a bug.
Apr 26 11:10:17 <csteipp> My first reaction is I think that is going to confuse people more-- they're going to get to a page that has their username, but may or may not have their chosen skin, and won't have their action menu... it just feels a little wrong to me.
Apr 26 11:10:35 <csteipp> But, I think it's an option
Apr 26 11:10:52 <pgehres> the action menu and watchlist star could also be added after the fact
Apr 26 11:11:04 <pgehres> and someone with skin!=vector could get a refresh
Apr 26 11:11:29 <pgehres> we were going for the 90% solution
Apr 26 11:11:38 <csteipp> So pgehres, I'm not sure if robla also asked, but he suggested involving some UI people. Are you ok pulling them in?
Apr 26 11:11:47 <pgehres> yeah
Apr 26 11:11:52 <pgehres> on my list
Apr 26 11:11:55 <csteipp> Cool
Apr 26 11:12:02 <anomie> Also stuff like "view source" versus "edit" (or does vector not do that?), and missing edit links, if the page is protected.
Apr 26 11:12:28 <pgehres> "view source" is only on a few wikis IIRC
Apr 26 11:12:57 <Aaron|home> anomie: people would complain quickly :)
Apr 26 11:13:36 <pgehres> we can always hide the entire page until the JS is done and then refresh :-)
Apr 26 11:13:50 <pgehres> they will complain less about that then the bump
Apr 26 11:13:53 <csteipp> To also make sure that not many people hit this situation, do you think it's also possible to do something like we do with the images now, and login as many browsers as we can on login?
Apr 26 11:14:29 <Aaron|home> pgehres: you can't cut back on personalized chromes...YOU WILL REGRET THIS!
Apr 26 11:14:33 <Aaron|home> ;)
Apr 26 11:14:39 <csteipp> I think the only safe way is to open an iframe, and then have the js check run from the foreign wiki.
Apr 26 11:15:11 <pgehres> Aaron|home: i don't think you understand how excited robla was about this, I was trying to pull him back ;-)
Apr 26 11:15:31 <csteipp> that's what I get for leaving work early..
Apr 26 11:15:51 <pgehres> lol
Apr 26 11:16:22 <csteipp> anomie/Aaron|home, any thoughts about if it would be possible, and not too ugly, to open an iframe to all wikis?
Apr 26 11:16:48 <anomie> What do you mean by "open an iframe to all wikis"?
Apr 26 11:17:07 <Aaron|home> I assume you means wikis for the domains right?
Apr 26 11:17:13 <Aaron|home> *he means
Apr 26 11:17:21 <csteipp> Do something on the login success page that also lets us set a cookie on the other wikis
Apr 26 11:17:29 <anomie> Remember that an iframe is considered a third-party context, so it has the same cookie issues as images do.
Apr 26 11:18:31 <csteipp> Yep, I'm thinking targeting the people who have visited the other sites. Active editors. The people likely to notice the delay when they hit a new project :)
Apr 26 11:19:01 <anomie> I don't think the iframe has any advantage over the existing image thing for that part of it. Does it?
Apr 26 11:19:38 <csteipp> The security issue with the current images is the only reason I want to get rid of them
Apr 26 11:19:46 <csteipp> They work ok for cookie setting
Apr 26 11:19:55 <csteipp> (for non safari, non-mobile)
Apr 26 11:21:27 <csteipp> Anyway, not something we have to solve right now, but something else to think about. If we make the experience nice for most editors, then not many people will complain about the slow check :)
Apr 26 11:22:25 <csteipp> Btw, for labs, is there any reason the wikis don't have either other their autologin list?
Apr 26 11:22:56 <Aaron|home> sounds like missing conf?
Apr 26 11:22:58 <csteipp> The icon showing up on login is to the central wiki... I was thinking about adding the other wikis to the array. Any reason not to?
Apr 26 11:23:04 <csteipp> Probably :)
Apr 26 11:23:08 <anomie> For the image autologin? So we can log into labs and still be logged out on the other wikis for testing the central login.
Apr 26 11:23:40 <csteipp> I just wanted to demo to robla the speed if the user got a cookie from the image, instead of waiting for the js check
Apr 26 11:24:05 <anomie> CommonSettings.php, lines 1456-1461.
Apr 26 11:24:28 <csteipp> Cool, I'll add that tomorrow. I just didn't know if how it was, was intentional.
Apr 26 11:24:36 <Aaron|home> anomie: hmm, that makes sense
Apr 26 11:24:58 <anomie> err, s/log into labs/log into the central domain/
Apr 26 11:25:28 <csteipp> And yeah, I agree it's useful like that, so I'll take it out after I demo :)
Apr 26 11:26:23 <Aaron|home> is there a description of the iframe option anywhere?
Apr 26 11:26:30 * Aaron|home is sure how much faster that would be
Apr 26 11:27:01 <csteipp> Aaron|home: You mean using an iframe instead of images?
Apr 26 11:27:19 <csteipp> (as I was talking about above?)
Apr 26 11:27:22 <Aaron|home> yes
Apr 26 11:27:28 <csteipp> No, not yet
Apr 26 11:27:36 <csteipp> I'll add something...
Apr 26 11:28:17 <csteipp> later.
Apr 26 11:28:27 <csteipp> I can't multitask :)
Apr 26 11:29:34 <csteipp> But as far as testing goes, pgehres is talking with Zelko and Chris M about automating some testing for SUL2. Yay.
Apr 26 11:29:55 <csteipp> And I tested the current labs in a bunch of browsers today.
Apr 26 11:30:10 <csteipp> It's works for both FF 22 and mobile safari.
Apr 26 11:30:24 <csteipp> So mission accomplished, if we can make it a little faster :)
Apr 26 11:31:56 <csteipp> For OAuth stuff, I drew up some preliminary wireframes for the special pages on the train today. I'll get those uploaded tonight.
Apr 26 11:32:58 <csteipp> Aaron|home and anomie, if you guys have time tomorrow, I'd love to start working out the design of the oauth stuff. If you're out of idea for speading up sul2.
Apr 26 11:33:06 <anomie> I think the only way to actually make it faster is to somehow reduce the number of steps.
Apr 26 11:34:38 <csteipp> anomie: I agree, that would be nice. If you have any more ideas, let me know.
Apr 26 11:35:14 * Aaron|home would have to look at that patch more
Apr 26 11:35:23 * James_F is now known as James_F|Away
Apr 26 11:36:29 <anomie> We might be able to cut out two of the steps (skip C1, and do L1 on the initial page view) if we wanted to create a session for every anon that viewed a page. But I don't think we want to do that.
Apr 26 11:38:17 <csteipp> That would be nice, but I've assumed it's not possible. TimStarling, can correct me if I'm wrong though.
Apr 26 11:40:01 <csteipp> Alright, anything else we should chat about?
Apr 26 11:40:33 <pgehres> csteipp: one of the goals of this week was getting SUL merge ready, how is that going?
Apr 26 11:41:05 <csteipp> SUL merge?
Apr 26 11:41:18 <pgehres> SULv2 code, sorry, words are hard
Apr 26 11:42:18 <csteipp> I want to test the code without a central wiki, but as is, we could merge-- but the speed is something of a blocker. That's why we need to get it resolved asap.
Apr 26 11:42:52 <pgehres> okay, just wanted to make sure that we'd covered all blockers for that to happen
Apr 26 11:43:13 <pgehres> and then I have a note about P3P for IE
Apr 26 11:43:33 <csteipp> Yep, consider it blocked on the speed of the js login. anomie, aaron and I will be working on it :)
Apr 26 11:43:35 <Aaron|home> csteipp: what about that redirect login part? maybe that can be merged first
Apr 26 11:43:54 <csteipp> Aaron|home: yeah, we can do that I think
Apr 26 11:44:44 <anomie> csteipp: Test without a central wiki by commenting out the line setting $wgCentralAuthLoginWiki in CommonSettings.php (line 1480)?
Apr 26 11:44:45 <csteipp> I *think* the IE/p3p is a non issue-- the login is working in IE7 and 8.
Apr 26 11:45:01 <anomie> I did the P3P thing the other day ;)
Apr 26 11:45:05 <csteipp> Oh, nice!
Apr 26 11:45:10 <pgehres> Awesome
Apr 26 11:45:24 <csteipp> Is that in the patch?
Apr 26 11:45:41 <anomie> Should be, unless I forgot to git review it. Let me look.
Apr 26 11:45:57 <csteipp> (admits to not having looked at the patch in a few days)
Apr 26 11:46:14 <anomie> Yeah, it's in there.
Apr 26 11:46:25 <csteipp> cool.
Apr 26 11:46:50 <anomie> It turns out the page in the iframe doesn't need P3P, but we do need it when setting the central cookies.
Apr 26 11:47:32 <anomie> And IE10 needs it for setting the cookies on the CORS request, too.
Apr 26 11:48:18 <anomie> And we'll just hope Microsoft doesn't go and break things in IE11 (talked to Robla about that bit of it on Tuesday)
Apr 26 11:48:39 * csteipp grumbles about MS in general..
Apr 26 11:48:42 <pgehres> well, if that's it, I made this for everyone earlier in the convo http://cdn.memegenerator.net/instances/400x/37287100.jpg
Apr 26 11:48:54 <pgehres> and thinks about making a scumbag Microsoft
Apr 26 11:49:20 <csteipp> awesome
Apr 26 11:49:33 <csteipp> Cool. Thanks all!
Apr 26 11:49:39 <pgehres> thank you csteipp
Apr 26 11:52:01 <Aaron|home> csteipp: I noticed that onUserLoadFromSession doesn't set $result except for the "auth ok" case
Apr 26 11:52:06 * pgehres is now known as pgehres|away
Apr 26 11:52:42 * Aaron|home is trying to figure out how global logout actually works fully now
Apr 26 11:53:17 <Aaron|home> I can see how it stops further auto-login
Apr 26 11:54:04 <csteipp> The cookies (iirc) were all deleted on logout
Apr 26 11:55:58 <Aaron|home> for other wikis?
Apr 26 11:56:53 <Aaron|home> it must be stopping the local ones from getting set somewhere
Apr 26 11:59:39 * Aaron|home stares at SpecialUserlogin
Apr 26 12:00:19 <csteipp> Aaron|home: Ah, since they're both on the same top level domain right now, the one centralauth cookie delete is enough
Apr 26 12:00:50 <Aaron|home> I mean even of WMF sites now
Apr 26 12:01:20 <Aaron|home> onUserLoadFromSession() falls through to local sessions if there was no CA one (I thought it didn't do that before)
Apr 26 12:01:48 <csteipp> Oh, I think the local sessions are never filled right now
Apr 26 12:01:53 <csteipp> (iirc)
Apr 26 12:02:14 <csteipp> Except on the wiki where they actually login
Apr 26 12:02:26 <Aaron|home> they'd have to be, but I can't find code doing that
Apr 26 12:02:36 <Aaron|home> (have to be not filled)
Apr 26 12:02:36 <anomie> Aaron|home: Possibly where it unsets wsToken and Token in onUserSetCookies?
Apr 26 12:03:24 <Aaron|home> I passed right over that, that's it
Apr 26 12:04:59 <Aaron|home> so the cookies/session are still there be the stored session token is destroyed...that works
Apr 26 12:06:26 <Aaron|home> that username/sessionid cookie that is
Apr 26 12:10:03 <Aaron|home> s/be the/but the