Topic on Extension talk:Variables

I noticed that this extension is said to be supported in MediaWiki 1.29+ but I'm quite sure that it breaks MediaWiki 1.39.

https://phabricator.wikimedia.org/T348426#9305340

Premising that:

• yes, I've seen the red-warning in the extension page
• yes, I've read the full discussion at phabricator:T2509637

Probably it would be a good idea to evaluate if:

• explicitly flag this extension as not compatible with MediaWiki 1.39+
• and/or, mark this extension as "Unmaintained" (it has sense to say it at a certain point if it's not possible to continue the development because of MediaWiki deprecations)

I've edited the template to indicate "1.29-1.35" since the deprecation literally talks about 1.35 but feel free to clarify that in a better way.

What I did (and forgot about until now) was to remove support for the #var_final parser function, which relies on the deprecated InternalParseBeforeSanitize hook. That way it's working for me fine on MW 1.39 so it should be possible to release a new version.

Is the only symptom the PHP Deprecated: Use of InternalParseBeforeSanitize hook (used in VariablesHooks::onInternalParseBeforeSanitize) was deprecated in MediaWiki 1.35. [Called from MediaWiki\HookContainer\HookContainer::run] message? Those deprecation notices should be hidden from public view. I mean, it's not an error, just a warning that it will break in the future, it can be silenced and you'll be able to use 1.39 until EOL at least.

Thanks for this information. I tried playing with the `extension.json` to remove that hook call, and indeed it seems it was not the cause of our white screen of death. Originally I thought something was escalating the deprecation warning to an exception, but I'm quite sure this is not the case, and it's safe to keep that deprecation warning right there.

Thanks again for your work and I'm sorry that MediaWiki is doing these breaking changes affecting some of your users. But fortunately it seems we are not affected. I will revert my edits in the main page to restore 1.26+ compatibility.

If you are reading this message and if you are affected: enable the MediaWiki logs, and inspect other exception messages, for example the examining any other line marked with "[exception]".