Topic on Talk:Talk pages project/Replying/Flow

When you switch to Source mode, it looks like the page is getting extraneous javascript events as you type. For example, on enwiki, put this in your common.js:

mw.loader.load('https://tools-static.wmflabs.org/spi-tools-dev/spi/tag-check.js');

maxUsersCUStaleness = 300;

mw.loader.load("/w/index.php?title=User:Writ Keeper/Scripts/cuStaleness.js&action=raw&ctype=text/javascript");

mw.loader.load("/w/index.php?title=User:Writ Keeper/Scripts/sockStaleness.js&action=raw&ctype=text/javascript");

These are three scripts commonly in use by SPI clerks. Now, navigate to an SPI page (say, :en:Wikipedia:Sockpuppet investigations/Jinnifer, reply to a comment, go into Source mode, and start typing. The scripts will run repeatedly every keystroke or so, as seen in the attached screenshot.

This is exactly what I was worried about in phab:T279141#6986316. I don’t know how exactly these scripts work, but users of the wikipage.content hook should rely on, and only on, the hook parameter; they should not use global queries (e.g. $('.myClassname')), only those that work with the content passed by the hook (e.g. $content.find('.myClassname') or $('.myClassname', $content)).

My javascript skills are pretty much in the "knows just enough to be dangerous" category, so yeah, I was relying on global queries, i.e.

$("span.cuEntry a[href*='/User:']").each(async function() {...}

in my wikipage.content hook. Thanks for the suggestion. I pinged the author of the other script here too :-)

There's a similar issue with the marked-blocked gadget on w:en. w:en:Wikipedia talk:Talk pages project#Performance with blocked username gadget.

This is happening with Hot Cat as well. See en:WT:HotCat#Doubled HotCat insertions with Reply Tool.

It looks like all of the problems reported so far have been fixed:

https://tools-static.wmflabs.org/spi-tools-dev/spi/tag-check.js

I don't know where to check the revision/commit history, but the code looks like it should handle this correctly now, I assume you fixed it RoySmith? Thanks!

• w:User:Writ Keeper/Scripts/cuStaleness.js
• w:User:Writ Keeper/Scripts/sockStaleness.js

Fixed by the author:

• https://en.wikipedia.org/w/index.php?title=User:Writ_Keeper/Scripts/sockStaleness.js&diff=1029434239&oldid=935647142
• https://en.wikipedia.org/w/index.php?title=User:Writ_Keeper/Scripts/cuStaleness.js&diff=1029434185&oldid=1014995847

(Not in the ideal way – the scripts no longer use the hook, and won't run again after page content is updated without reloading – but whatever…)

w:en:Wikipedia talk:Talk pages project#Performance with blocked username gadget

Fixed by me: https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-markblocked.js&diff=1032763221&oldid=1021641704

en:WT:HotCat#Doubled HotCat insertions with Reply Tool

Fixed by me: https://commons.wikimedia.org/w/index.php?title=MediaWiki:Gadget-HotCat.js&diff=574182738&oldid=568234975 (although this one was not related to the use of wikipage.content hook).

tag-check.js is at https://github.com/roysmith/spi-tools/blob/master/spi/static/spi/tag-check.js I haven't updated it in several months.

The version at https://tools-static.wmflabs.org/spi-tools-dev/spi/tag-check.js is different, and it is fixed (I just checked).

You fixed it in https://github.com/roysmith/spi-tools/commit/437abed9ffa4ea84ac9426770c6180becdc13f2b on the dev branch. Consider merging it into master ;)

Oh, how embarrassing :-)