Topic on Project:Support desk

Tracked in Phabricator
Task T215731

Updating from 1.30 to 1.32 was going along just normally, aside from a few "require_once" to "wfLoadExtension" changes, but the database update fails with:

Populating externallinks.el_index_60...
el_id 0 - 200 of 456
[d8f1b9fab145228636205d65] [no req]   Wikimedia\Rdbms\DBQueryError from line 1496 of /usr/local/www/mediawiki/includes/libs/rdbms/database/Database.php: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: UPDATE IGNORE "externallinks" SET el_index_60 = 'http://org.mediawiki.www./wiki/Extension:Pchart4mw#Maintenan' WHERE el_id = '1'
Function: PopulateExternallinksIndex60::doDBUpdates
Error: 42P01 ERROR:  relation "ignore" does not exist
LINE 1: ...eExternallinksIndex60::doDBUpdates root@kyonyu */ IGNORE "ex...
                                                            ^
Backtrace:
#0 /usr/local/www/mediawiki/includes/libs/rdbms/database/Database.php(1466): Wikimedia\Rdbms\Database->makeQueryException(string, string, string, string)
#1 /usr/local/www/mediawiki/includes/libs/rdbms/database/Database.php(1226): Wikimedia\Rdbms\Database->reportQueryError(string, string, string, string, boolean)
#2 /usr/local/www/mediawiki/includes/libs/rdbms/database/Database.php(2112): Wikimedia\Rdbms\Database->query(string, string)
#3 /usr/local/www/mediawiki/maintenance/populateExternallinksIndex60.php(76): Wikimedia\Rdbms\Database->update(string, array, array, string, array)
#4 /usr/local/www/mediawiki/maintenance/Maintenance.php(1698): PopulateExternallinksIndex60->doDBUpdates()
#5 /usr/local/www/mediawiki/includes/installer/DatabaseUpdater.php(1374): LoggedUpdateMaintenance->execute()
#6 /usr/local/www/mediawiki/includes/installer/DatabaseUpdater.php(485): DatabaseUpdater->populateExternallinksIndex60()
#7 /usr/local/www/mediawiki/includes/installer/DatabaseUpdater.php(449): DatabaseUpdater->runUpdates(array, boolean)
#8 /usr/local/www/mediawiki/maintenance/update.php(203): DatabaseUpdater->doUpdates(array)
#9 /usr/local/www/mediawiki/maintenance/doMaintenance.php(94): UpdateMediaWiki->execute()
#10 /usr/local/www/mediawiki/maintenance/update.php(248): require_once(string)
#11 {main}

MediaWiki 1.32.0

PHP 7.2.15 (apache2handler)

PostgreSQL 9.5.15

ICU63.1

Ah, this seems to be a bug with PostgreSQL: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/281238/

This patch https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/420221/9/includes/libs/rdbms/database/DatabasePostgres.php seems to have been intended for 1.31, but is not included as of 1.32.

That patch is included in 1.32. You may have a new problem.

Yep, looks like that patch only affected INSERT, not UPDATE.

And pchart4mw didn't have anything to do with this, but thanks for pointing it out because I updated its page.