Topic on User talk:Werdna

Jump to navigation Jump to search

int unsigned vs. bigint unsigned for primary keys

1
Leucosticte (talkcontribs)

Hi Andrew, I notice that git blame abusefilter.tables.sql says that you made abuse_filter.af_user a bigint unsigned. Was that in anticipation that user.user_id might one day become a bigint unsigned? I recently filed bug 61111, "Change log_id, page_id, rc_id, rev_id, and user_id to bigint unsigned" to do just that. However, it will require dozens, if not hundreds, of changes to the core, since there are lines of code all over the place saying, e.g., $this->mId = intval( $this->mId ); Intval maxes out at 2147483647. Do you think it's a good idea to make this change? Thanks.

Reply to "int unsigned vs. bigint unsigned for primary keys"