Topic on Extension talk:GoogleLogin

[RESOLVED] Breaks mw-config

3
Summary by Florianschmidtwelzow
177.179.97.187 (talkcontribs)

Hello all,

I'm investigating MediaWiki 1.23.2 with Google Login (current HEAD of master).

I seems this combination breaks the automatic install/update process with mw-config.

I believe this is caused by this line:

// load $wgAuth
$wgAuth = new GoogleLoginAuth;

It seems that, during mw-config, GoogleLoginAuth cannot be found.

Maybe upgrading the install process to Composer would solve this.

Florianschmidtwelzow (talkcontribs)

oO: Never tested the web installer, only the cli :/ As a workaround you can use maintenance/update.php if possible or comment out $wgAuth = new GoogleLoginAuth; for the time you use the webinstaller.

Florianschmidtwelzow (talkcontribs)

Hello again! Are you able to test this patchset? https://gerrit.wikimedia.org/r/#/c/154134/ just change this in GoogleLogin.php: From:

// load $wgAuth
$wgAuth = new GoogleLoginAuth;

to:

$wgExtensionFunctions[] = 'efGoogleLoginSetup';

function efGoogleLoginSetup() {
	// check if we can load wgAuth automatically
	if ( class_exists( 'GoogleLoginAuth' ) ) {
		// load $wgAuth
		$wgAuth = new GoogleLoginAuth;
	}
}

Otherwise i merge it :)