Extension talk:RevisionSlider

Jump to: navigation, search

About this board

Edit description

This is the feedback page for the RevisionSlider extension.

Read about what we've learned about creating a RTL-accessible extension. Please report all RTL-related issues on this talk page!

Special feedback wanted:

Based on user feedback, we've changed the way you can move between revisions. The slightly different user interface can be tested on test.wikipedia. Any feedback is welcome :-) Thanks!

By clicking "Add topic", you agree to our Terms of Use and agree to irrevocably release your text under the CC BY-SA 3.0 License and GFDL

Issue: The revision pointers appear out of place when clicking the left arrow after dropping the other pointer

8
197.218.83.36 (talkcontribs)

Problem

The revision pointers appear out of place (outside the revision bar area) when quickly clicking the left arrow (to load more revisions) after dropping the other pointer.

Steps to reproduce

  1. Go to a page showing revisions (e.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?diff=354925&oldid=217960&title=Main_Page&type=revision)
  2. Click the icon to load the revision slider
  3. Move the mouse over the yellow revision ball
  4. Press the left mouse button
  5. Move the mouse horizontally right until the yellow pointer is close to the blue one
  6. Let go of the mouse button
  7. Quickly, before the new changes load, click the "left arrow" to show older revisions

Expected

The click doesn't do anything until the changes are loaded.

Actual output

The revision bar area moves to show the new revisions, and this behaviour causes the yellow and blue pointer go "off screen" and appear outside to the left of "revision bar" area.

Note: Steps 6 and 7 need to be done very quickly to reproduce this behaviour.

IKhitron (talkcontribs)

Bless you. I saw this dozens of times, but never succeeded to reproduce so I could create a phab ticket.

Christoph Jauera (WMDE) (talkcontribs)

Hey you two,

phew, that really is a tough one. I tried to follow the steps and be really really fast, but I failed to reproduce the error. :-/ Also I find it a bit hard to visualize what you mean with 'the yellow and blue pointer go "off screen"'.

It would be really awesome if you could send me a screenshot ( christoph.jauera@wikimedia.de ) or upload it somewhere and post a link here.

Thanks again for your very helpful feedback.

Best, Christoph

IKhitron (talkcontribs)

Next time I'll see this, I'll make a screenshot.

197.218.81.64 (talkcontribs)

Indeed, a picture or two (animated) is worth a thousand words:

http://imgur.com/a/0kcg8

Maybe it happens more often when there are connectivity problems, or the bandwidth happens to be limited?

I guess limiting the bandwidth in developer tools would make it easier to replicate.

IKhitron (talkcontribs)

It's not the case I meant, but pretty close.

197.218.81.64 (talkcontribs)

You mean not even close?

My case is due to conflicting conditions, it attempts to load the new revision and show older revisions. Since it can't do both simultaneously that happens.

IKhitron (talkcontribs)

Fixed the typo, thank you.

Reply to "Issue: The revision pointers appear out of place when clicking the left arrow after dropping the other pointer"

Popup doesn't always appear when hovering over "bars"

6
Summary by 197.218.83.36

Seems fixed here.

197.218.82.45 (talkcontribs)

Issue

When the mouse pointer is just about 1 or 2 cm above the yellow line the hover doesn't show up.

Steps to reproduce

  1. Go to a page showing revisions (e.g. https://www.mediawiki.org/w/index.php?diff=2446749&oldid=2428873&title=Extension%3AFlow&type=revision)
  2. Move the mouse to the left side of the screen (out of the revision slider area)
  3. Move the mouse vertically 1 or 2 cm above the yellow revision line
  4. Move the mouse horizontally between different revisions.

Expected

The popup showing revision data shows up.

Actual output

Nothing is shown.

Note: Moving the mouse a bit higher in the revision "bar" area will result in the popup showing up, but this is not intuitive.

Birgit Müller (WMDE) (talkcontribs)

Hi there! Thank you so much for your detailed reports :-) All issues are currently in work. We will let you know once it is done! Best, Birgit

197.218.83.250 (talkcontribs)

Great...

Well, here's one bug the developers haven't likely noticed, when a revision pointer is dragged, and then moved back to its original location, the current revision reloads needlessly.

Christoph Jauera (WMDE) (talkcontribs)

Hej!

As Birgit mentioned your first post relates to one of the issues we were currently working on. The bug is fixed now and you can see the improved version of the RevisionSlider on beta: https://en.wikipedia.beta.wmflabs.org/w/index.php?diff=354925&oldid=276480&title=Main_Page&type=revision

Due to some maintenance on the Wikimedia servers the fixes for the version on mediawiki.org and test.wikipedia.org will not go live before next week. So if you like to test it a bit more please feel free to do so with the current version on the beta server above.

Thanks again for your feedback and don't hesitate if you have any more issues or questions. I will also take a look into the second thing you mentioned.

Best, Christoph

197.218.83.36 (talkcontribs)

The first issue is fixed. The second one still exists.

Just to clarify, to trigger it, one needs to click and press the left mouse button over one of the revision pointers, then move it around horizontally over other revision "bars", and finally return it to its original position and then let go of the mouse.

Christoph Jauera (WMDE) (talkcontribs)

Yeah, thanks. I looked into it and filled a ticket in Phabricator: https://phabricator.wikimedia.org/T163425

Reply to "Popup doesn't always appear when hovering over "bars""

Popup doesn't always appear when dragging the yellow revision pointer (e.g. yellow "ball" )

3
Summary by 197.218.83.36

Seems fixed here.

197.218.82.45 (talkcontribs)

Issue

Selecting the revision pointer and dragging it horizontally doesn't always show the revision data popup.

Steps to reproduce

  1. Go to a page showing revisions (e.g. https://www.mediawiki.org/w/index.php?diff=2446749&oldid=2428873&title=Extension%3AFlow&type=revision)
  2. Place the mouse pointer on the "yellow revision pointer" (e.g. ball)
  3. Click and hold the mouse button
  4. Move the mouse pointer horizontally towards the left, between different revisions.

Expected

The popup showing revision data appears.

Actual output

Popup isn't always shown for all revisions.

Note: For the first few revisions the popup is actually shown, but when going toward the last few on the left it no longer appears. This also doesn't seem to happen on pages with few revisions.

Christoph Jauera (WMDE) (talkcontribs)

Hej hej!

As above this error should be fixed on the currently deployed version on Beta that will go live on mediawiki.org and test.wikipedia.org next week. You can already test it here: https://en.wikipedia.beta.wmflabs.org/w/index.php?diff=354925&oldid=276480&title=Main_Page&type=revision

Thanks and best,

Christoph

197.218.83.36 (talkcontribs)

Thanks, all these seem to be fixed in the test server ...

Issue: Popup shows up on the far left side of the page when it is dragged close to the right edge of the window

3
Summary by 197.218.83.36

Seems fixed here.

197.218.82.45 (talkcontribs)

Problem

As a user I expect the popup to always appear close to the "revision bar".

Steps to reproduce

  1. Go to a page showing revisions (e.g. https://www.mediawiki.org/w/index.php?diff=2446749&oldid=2428873&title=Extension%3AFlow&type=revision)
  2. Place the mouse pointer on the "yellow revision pointer" (e.g. ball)
  3. Click and hold the mouse button
  4. Move the mouse pointer horizontally towards the right until it is close to the edge of the screen / window.

Expected

The popup consistently shows close (and below) to the revision "bar".

Actual output

Sometimes the pop up shows up on the left side of the page.

Note: This is likely due to the popup tool attempting to be too smart. Whenever there isn't space on the right hand side to fully display the popup it puts it on the left hand side, instead of adjusting the arrow and keeping the "box" in the right place.

Christoph Jauera (WMDE) (talkcontribs)

Aaaand again :-)!

This error should also be fixed on the currently deployed version on Beta see here: https://en.wikipedia.beta.wmflabs.org/w/index.php?diff=354925&oldid=276480&title=Main_Page&type=revision

Really thanks a lot for your detailed error reports and best,

Christoph

197.218.83.36 (talkcontribs)

Yup, this is fixed on the test server, thanks ...

Suggestion: Add keyboard shortcuts to move between revisions

6
Summary by 197.218.83.36

Tracked here.

197.218.90.49 (talkcontribs)

Problem

As a user, I can't easily move to the previous (or next) set of revisions easily without using the mouse.

Background

Currently, if a user wants to move both pointers at the same time they need to click and drag the pointers twice, once to move the first pointer, and a second time to move the second one. While this makes perfect sense when the revisions are far apart, it is quite cumbersome when one wants to move to the previous (or next) two revisions.

Proposed solution

Keyboard shortcuts to move in each direction:

  • Shortcut to move both pointers ( ctrl + alt + ) - simultaneous move the pointers to the two previous revisions.
  • Shortcut to move one pointer (ctrl + ) - move the left or right pointer to previous or next revision
197.218.90.49 (talkcontribs)

For the second shortcut since there are cases where one would want to use either the left or the right pointer, maybe these would be better:

  • Move right pointer- META+ Shift+ 
  • Move left pointer - META+ 
Christoph Jauera (WMDE) (talkcontribs)

Hej,

thanks for the feedback. I created a ticket for your proposal on Phabricator so we can keep track off the idea and consider it for a future version or volunteers that might want to work on it. https://phabricator.wikimedia.org/T162119

Best,

Christoph

197.218.80.245 (talkcontribs)

This seems like such an easy hack, that it would probably also be useful for mediawiki core, and it is also easy to write a simple userscript (something I'll probably do for myself).

Thanks for the prompt feedback...

197.218.83.36 (talkcontribs)

I created this small userscript that does this. It doesn't yet move the pointers individually because that's a bit more complex. This even works on older mediawiki versions (> mediawiki 1.19).

// This software is entirely free to re-use, adapt, or sell  (hope it makes someone rich!), without any warranty of any kind or need to attribute "the IP". Use it at your own risk.
// Use ctrl + alt + arrow (left or right) to move to previous revisions or next.
var pressedKeys = {
	ctrl: false,
	shift : false,
	left: false,
	right : false
};
var urlQry = {};
location.search.substr(1).split("&").forEach(function(token) {
	urlQry[token.split("=")[0]] = token.split("=")[1];
});
document.onkeydown = function (event) {
	if (urlQry.type === "revision" || urlQry.diff) {
		if (event.ctrlKey) {
			pressedKeys.ctrl = true;
		}
		if (event.keyCode == 37) {
			pressedKeys.left = true;
		} else if (event.keyCode == 39) {
			pressedKeys.right = true;
		}
		if (pressedKeys.ctrl && pressedKeys.left) {
			document.getElementById("differences-prevlink").click();
		} else if (pressedKeys.ctrl && pressedKeys.right) {
			document.getElementById("differences-nextlink").click();
		}
	}
};
document.onkeyup = (function(event) {
	// reset status of the button 'released' == 'false'
	if (urlQry.type === "revision" || urlQry.diff) {
		if (event.ctrlKey) {
			pressedKeys.ctrl = false;
		}
		if (event.keyCode == 37) {
			pressedKeys.left = false;
		}
		if (event.keyCode == 39) {
			pressedKeys.right = false;
		}
	}
});
197.218.83.36 (talkcontribs)

It is also works independently from revision slider, so maybe it will help future "searchers".

Reply to "Suggestion: Add keyboard shortcuts to move between revisions"

Perhaps it is time to move this feature out of beta?

13
197.218.90.170 (talkcontribs)

Just curious, but is this feature still beta in certain wikis?

Based on Beta Features, such features aren't meant to be left there indefinitely. Given that it seems as this extension is now stable in certain wikis, it should probably get an announcement and removed as a beta feature, see :

So either this needs to become an optional full feature, or yanked from every wiki that doesn't want it. If nothing else, it might drive individual wikis to ask for it to be enabled by default for casual editors, instead of become a gravestone in "graveyard of discarded ambitions".

Considering its popularity [1] chances are that it may become a default wikimedia extension and encourage volunteer developer improve its feature set due to widescale usage ...

197.218.90.170 (talkcontribs)

*instead of becoming

Addshore (talkcontribs)

Feature rollout is currently being planned :)

197.218.88.37 (talkcontribs)

You mean more feature rollout as a beta, or as a full optional feature?

Anyway, hopefully it won't beat Gmail's beta period record(http://www.slate.com/articles/news_and_politics/recycled/2009/07/why_did_it_take_google_so_long_to_take_gmail_out_of_beta.html) :).

Thanks for the update.

Tobias Gritschacher (WMDE) (talkcontribs)

Hi,

RevisionSlider is a beta-feature on all wikis since September 2016, see https://phabricator.wikimedia.org/T143421#2632809. We're currently still testing a slightly different UI based on past user feedback (see https://phabricator.wikimedia.org/T160410) and after giving us some time to receive some feedback on the implementation of this we're aiming to leave the beta-feature-status on all Wikipedias soon after.

IKhitron (talkcontribs)

Unfortunately, there is still a hook bug. It looks like it should be fixed before the move.

Christoph Jauera (WMDE) (talkcontribs)

Just a small update here:

The hook bug mentioned by IKhitron was fixed in the meantime.

As Tobias mentioned we are currently in the process of testing a different UI. You can find the newest version of the alternative UI on Beta, test.wikipedia.org and here on mediawiki.org.

- Please note, that the version on test and mediawiki has some minor issues with the tooltips right now. The fixes for that should be deployed during next week though.

Best,

Christoph

IKhitron (talkcontribs)

Hi, Christoph Jauera (WMDE), I checked just now, it still doesn't work. Partially. Some problems disappeared indeed, not all of them.

Christoph Jauera (WMDE) (talkcontribs)

Hey, @IKhitron that's sad to hear. Could you create a new ticket or comment in the existing one with the problems you still get? - That would be great!

Thanks in advance,

Christoph

IKhitron (talkcontribs)

Where is the ticket, I don't remember, Christoph Jauera (WMDE)? The problem I can see is that after usage of RS, for one revision, thanks action opens thanks page, in place of regular inline question.

Christoph Jauera (WMDE) (talkcontribs)

Here you go: https://phabricator.wikimedia.org/T142636 :-)

IKhitron (talkcontribs)

Thanks, Christoph Jauera (WMDE). Looks as it will be deployed next week, because of the switch. So, I'll just wait.

197.218.83.36 (talkcontribs)

> As Tobias mentioned we are currently in the process of testing a different UI. You can find the newest version of the alternative UI on Beta, test.wikipedia.org and here on mediawiki.org.

The new UI is definitely more intuitive than the older one. Dragging and dropping with the old one was a bit confusing and hard to get used to. So this will likely be a welcome improvement.

Great work!

Reply to "Perhaps it is time to move this feature out of beta?"

Suggestion: Introduce milestones (or markers) to mark important event in article history

2
197.218.83.250 (talkcontribs)

Problem

As a user, I am unable to easily see significant disruptive or constructive changes have been made to an article.

As a reader, I unable to easily evaluate the history of a page to evaluate its potential bias.

Background

One of the main problems with the regular history is that everything is jumbled up. The history page simply lays out information without highlighting anything, and revision slider makes things somewhat worse because one can only see the summary after hovering. This means that it is hard to note if the article content was completely modified after years of existence, if it was suddenly blanked, or if it had considerable reverts.

Proposed solutions

Add some markers to denote some of these changes. Some of these can be detected using the automatic edit summary (Help:Automatic_edit_summaries), e.g.:

  • Red bar - whenever a newer revision is completely blank
  • Red bar - whenever a revision shows more than 70% of the content being removed
  • Orange bar - indicating a revert, if two adjacent revisions have the exact same sha1 hash

Other ideas include:

  • Highlight the most repeated revisions - by verifying a group of revisions that has the same content or sha1. This would be a possible indicator of revert or edit disagreements without even looking at all of them individually.
  • Highlight main contributor -show clusters of revisions done by major user. No matter what, a page created by a single user will always contain their biases, and is less likely to be reliable.
Christoph Jauera (WMDE) (talkcontribs)

Hey and thanks for the suggestion!

I created a Phabricator ticket with your Ideas so we can keep track of it and might consider it for future versions of the RevisonSlider. You can find the ticket here: https://phabricator.wikimedia.org/T163366

Best,

Christoph

Reply to "Suggestion: Introduce milestones (or markers) to mark important event in article history"
SpikeballUnion (talkcontribs)

The animation time is quite slow/laggy. Maybe make an option to disable it so the arrows can move instantly?

Christoph Jauera (WMDE) (talkcontribs)

Hi @SpikeballUnion,

could you tell us a bit more about what you mean with animation time?

Is it about the time needed until its completely loaded when initially expanded? The time it takes to load the diff when you drag the pointers to some revision? Or the delay when you quickly want to move to the "next page" of revisions by clicking the arrows on the left/right side?

Thanks for your feedback so far,

best,

Christoph

SpikeballUnion (talkcontribs)

Hi and thanks for your response.

I refer to the time that the arrows take to move to their position. It can be quite obstructing when making a mistaken click and needing to quickly click the correct revision one intended. I understand that the page load times will remain at their speed whatever the extension is, however I think the time it takes for the arrows to move across the revision slider compounds the swift use of the extension. That's just my opinion/feedback though.

Christoph Jauera (WMDE) (talkcontribs)

Hi @SpikeballUnion,

I looked at the things you mention and I think I got the idea now. When you click on two bars, that are right next to each other very quickly the pointer moves relatively slow to that bar. - I guess thats related to the way the animations are done there. I think in theory that could be adjusted slightly, but I am not sure if or when we will find the time to address the issue. I will file a ticket later and poke you again.

Thanks again,

Christoph

Christoph Jauera (WMDE) (talkcontribs)

Just created the task: https://phabricator.wikimedia.org/T161883

SpikeballUnion (talkcontribs)

Thank you for taking into account my relatively minor feedback and suggestions.

Reply to "Animation time"

Suggestion: Add an entry point to revision slider from the history page

2
Summary by Christoph Jauera (WMDE)

Ticket filed at https://phabricator.wikimedia.org/T160739

197.218.81.246 (talkcontribs)

Problems

As a user, I can't easily use revision slider without clicking the "diff" link while on the history page.

As new user, it is not completely obvious how to get to the revision slider.

Background

The revision slider is a very useful tool especially for novice users who don't know how the whole wiki interface works. However, the tool has a few issues:

  • Use of jargon - it assumes the user is familiar with the concept of "diff".
  • Entry point unclear - Presumably this would appear in the history page, but only shows up when a "diff" is clicked. Oddly enough its header has "browse history" not browse revisions, yet it can't be seen at all in the history page.

Despite knowing of the existence of revision slider it was unclear how to get to it. In fact it made me think that it didn't work in certain namespaces after going through multiple page histories because I had forgotten that "diff" must be clicked.

Proposed solution

  1. Improve readability of help - replace the word "diff" with a more user friendly term (e.g. comparison of page changes / revisions), possibly keeping the word "diff" in brackets. Alternatively link to a page explaining the concept of "diff". Note that diff isn't even a "standard" English word.
  2. Add entry point(s) - a clear way to get to revision slider from the history page and possibly even to the Special:ContributionSpecial:Contributionss, without clicking "diff'.

While this is obviously a tool designed for experienced editors or regular users, a new user is not immediately familiar with all such tools and jargon.

Jan Dittrich (WMDE) (talkcontribs)

Hello 197.218.81.246, 

Thanks for your well structured and graspable problem description!  I understand what you mean and I will created a ticket on Phabricator:https://phabricator.wikimedia.org/T160739 so it can be considered as task by the project management.

Images, references, templates

2
Summary by Christoph Jauera (WMDE)

Ticket filed at https://phabricator.wikimedia.org/T160323

Evolution and evolvability (talkcontribs)

Hi,

A useful visualisation for moving through he history. It would be excellent if icons or colours could be used to indicate if an image or reference was changed in the edit.

Christoph Jauera (WMDE) (talkcontribs)

Hi @Evolution and evolvability

thanks for your feedback. I created a task on Phabricator to track your request. We will consider it when deciding on possible features in a future version.

See https://phabricator.wikimedia.org/T160323