Extension talk:RevisionSlider

Jump to: navigation, search

About this board

This is the feedback page for the RevisionSlider extension.

Read about what we've learned about creating a RTL-accessible extension. Please report all RTL-related issues on this talk page!

By clicking "Add topic", you agree to our Terms of Use and agree to irrevocably release your text under the CC BY-SA 3.0 License and GFDL
Neil P. Quinn (talkcontribs)

Thanks so much to the team from WMDE for making this! I've already used it twice in the last few days to trawl through a page's history and figure out why particular bits of content were added; before I knew about this tool, I might simply have ignored those issues because searching the history would have been too difficult.

I do have a couple comments on the UI. First, it took me a significant amount of time to understand that you click in the lower half of the slider to set the start of the diff, and in the upper half to set the end. For a while, I just clicked somewhat randomly until I got the diff I wanted, which wasn't a great experience.

I think one of the reasons this was confusing was that the vertical axis of the "graph" is already used to indicate addition and removal of content, so I wasn't expecting it to have another meaning as well. Personally, I didn't find the graph very helpful (the edit summaries were much more useful, even though they were harder to access). Partly that may be because the graph isn't to scale; for example, in the history page I'm looking at right now, +11 bytes is about half the height of +364.

Second, when you've got one revision set as the endpoint of a diff, you can't click on the bottom half of that edit to make it the starting point of a new diff. I don't see any reason for that restriction; I would expect clicking in that bottom half to advance the starting point like normal, and advance the ending point by one as well to compensate.

So, all in all, I found the design somewhat unintuitive, but now that I've figured out how to use it, I really like it :)

Tobias Gritschacher (WMDE) (talkcontribs)

Thank you for your great feedback and we're happy that RevisionSlider can help you in your daily work! What you wrote about your experience with the current UI confirm what we've learned during several usability tests. We have some ideas in mind how to improve these aspects in a next version of the RevisionSlider!

Simultaneous moving both edges

Summary by Addshore

Ticket filed at https://phabricator.wikimedia.org/T155499 for further discussion.

Wargo (talkcontribs)

My proposal is option (additional draggable element or keyboard combination) for moving both markers simultaneously by one mouse move. For example to quickly move to next revision. Now I need to move one slider and then to move second slider within the same number of steps.

IKhitron (talkcontribs)

You can move the other marker once. They interchange by theirselves.

Wargo (talkcontribs)

I would get additional marker to move them both simultaneously. If I move one, the second should move in the same way.

IKhitron (talkcontribs)

As I said, that's exactly what happens now.

Wargo (talkcontribs)

They need to move separately - this is good but sometimes I need to compare next pairs (something like compare two versions and clicking "next"/"prev" diff).

Addshore (talkcontribs)

Hi @Wargo! I quite like your suggestion! I have created a ticket @ https://phabricator.wikimedia.org/T155499 for the suggestion to be further didcussed.

Can't disable on Wikinews

Summary by Addshore

The RevisionSlider is currently a beta feature on Wikinews. Click on the 'Beta' link at the top right of the page, scroll down to RevisionSlider and untick the box before saving your preferences.

Agastya (talkcontribs)

I am unable to disable this on Wikinews. And, I also think why to provide an opt-out option (which doesn't work on Wikinews)? Better provide an opt-in option.

Addshore (talkcontribs)

Hi there! The RevisionSlider is currently a beta feature on Wikinews. Click on the 'Beta' link at the top right of the page, scroll down to RevisionSlider and untick the box before saving your preferences. If this doesn't work then please post back here!

Agastya (talkcontribs)

I found it. And it is working! Thank you for telling me how to do it.

Delta-size bars should be positioned between Versions

Pemu (talkcontribs)

To me, it seem insensible that the delta-size bars appear upon the version arrows. Because it is a delta, they should be positioned between any two versions. They show the amount of data added during transition from one version to another; any version alone got no sensible delta, as delta is a function of two (adjacent) versions. Bars upon seems sensible, if they stand for the actual size, but not the difference of size. (I don’t want the actual size being displayed – showing deltas is yet absolute reasonable.) -- Pemu (talk) 21:34, 21 December 2016 (UTC)

Reply to "Delta-size bars should be positioned between Versions"

RS was broken on rtl wikis in last deployment

Summary by Addshore
IKhitron (talkcontribs)

Hi. Something happened, and now the RS opening arrow is on the right side of the screen instead of usual left. When clicking, the arrow "jumps" back to the left side.

Addshore (talkcontribs)

Hi! I have filed a bug at https://phabricator.wikimedia.org/T152913. Thanks for reporting.

IKhitron (talkcontribs)

Thank you.

Summary by Birgit Müller (WMDE)

Amazing feedback on RevisionSlider and one suggestion: See https://phabricator.wikimedia.org/T151761.

טוסברהינדי (talkcontribs)

One thing to add is the ability to click on a specific bar and view the version independently.

Jan Dittrich (WMDE) (talkcontribs)

Thanks for your suggestion! I assume, "independently" means seeing the clicked version only without the diff?

טוסברהינדי (talkcontribs)

Sorry for the late response.

Yes, that's exactly what I meant. The view of a specific version (a single revision).


Rugk (talkcontribs)
Indeed that thing is awesome! 👍
Birgit Müller (WMDE) (talkcontribs)

@@Rugk, @טוסברהינדי thanks for the great feedback! :-) @Jan Dittrich (WMDE), could you create a Phab ticket for this idea and move it to the "possibly in version 2.0" column, so that we can keep it in mind? Thanks!

Released with deprecated functionality, and how to switch offf?

Summary by Addshore

Tickets have been filed for all points mentioned, and many have already been tackled and will soon be deployed (Monday 28th).

Expanded docs on mw.org, jQuery deprecation warnings, User option to hide, HelpDialog doesn't have static name, Use Map.get instead of Map.values & Lazy Loading

PerfektesChaos (talkcontribs)

Page seems to throw a pile of warnings now?

  • This page is using the deprecated ResourceLoader module "jquery.ui.widget".
  • This page is using the deprecated ResourceLoader module "jquery.ui.core".
  • Use of "Map-values" is deprecated. mw.Map#values is deprecated. Use mw.Map#get() instead.
  • OO.ui.WindowManager#addWindows: Windows must have a `name` static property defined.

At least partially caused by this extension and tracked back.

If I do not want to load and execute this JavaScript stuff, where can I configure to be kept in peace?

Addshore (talkcontribs)

I have just confirmed that the "Use of "Map-values" is deprecated. mw.Map#values is deprecated. Use mw.Map#get() instead." messages do indeed come from the RevisionSlider. I created a ticket on phabricator and have uploaded https://gerrit.wikimedia.org/r/#/c/323094/ which should resolve these. The other warnings to not appear to come from the RevisionSlider extension.

The RevisionSlider bar loads mostly without JavaScript and currently there is no user option to disable / remove the bar.

Schnark (talkcontribs)

All these warnings are caused by the RevisionSlider: ext.RevisionSlider.SliderView has a dependency on jquery.ui.draggable (which itself depends on jquery.ui.widget and jquery.ui.core), and ext.RevisionSlider.HelpDialog.js does create a window without a static name.

Addshore (talkcontribs)

Ahh, indeed RevisionSlider also appears to contribute those deprecation notices, they still appear for me locally with RevisionSlider disabled as other extensions also pump out the same notices.

I have created https://phabricator.wikimedia.org/T151448 regarding the HelpDialog windows without a static name.

PerfektesChaos (talkcontribs)

WRT deprecated warnings (Thanks @Schnark):

  • They occur on pages with no gadgets at all, nothing else than MediaWiki issued stuff, and RevisionSlider is the only thing with a UI, and there has been silence until yesterday.
  • Unfortunately they do not permit simple tracking down; if they are caused by something but not directly called it is hard to identify which circumstances are triggering them, by calling something on top.

WRT Opt-Out:

  • On every diffpage call the new gadget is unconditionally loading in the background the full history of 20 or whatever previous versions.
  • The API calls require about 30 kB of additional traffic, depending on summary lengths.
  • This is not acceptable for slow or expensive connections.
  • I am interested to see the difference between two particular versions I asked for. If I would like to analyse the history for recent years I will let you know.

On Preferences I can disable VE, MultimediaViewer, and indirectly ULS.

  • I can even request on Preferences that I want to see the comparison only without rendered page, for a decade now. Sometimes I make temporarily use of this config for specific maintenance tasks.

I want to get a chance to bail out from this tool asap.

Addshore (talkcontribs)

The patch fixing the HelpDialog deprecation note has been merged. This only leaves the jquery.ui.draggable deprecation notice (and the 2 that result from that). jquery.ui.draggable is also still used by other extensions, for example WikiEditor.

The extension is loaded (in the form of the collapsed bar) but the "20 or whatever previous versions" will not be loaded until the user requests to expand the RevisionSlider. This means the additional traffic of the requests is optional. This follows exactly your 4th bullet point. If the user lets the slider know that they want to use it, then it will make the requests and render.

As for a user preference to totally disable the collapsed RevisionSlider bar I have created a ticket on Phabricator to track the request.

Addshore (talkcontribs)

A patch adding a user option has been merged and will be deployed on Monday the 28th.

A patch moving most of the JS and CSS to be lazy loaded is also now up @ https://gerrit.wikimedia.org/r/#/c/323193

PerfektesChaos (talkcontribs)

Fine; thanks a lot.

I do appreciate lazy loading. I am running 30 gadgets on wikipages, and I preselect depending on circumstances, which of them will be actually triggered, and some are only sniffing and will complete loading and execution after individual request only, or interactive configuration change.

And when I leave city and enjoy German countryside, I have an internet connection slower than in the Australian outback.

how could we make this feature better?

Griffin12199 (talkcontribs)


Birgit Müller (WMDE) (talkcontribs)

Hi @Griffin12199, welcome to Wikipedia :-). I wish you all the best for your start as an editor. Once you're actively using this feature, I would also be interested in hearing about your experiences :-). I'm closing this topic for now, feel free to reopen it! Best, Birgit

Summary by Birgit Müller (WMDE)

created Phabricator tickets for the request:

https://phabricator.wikimedia.org/T147012 (patrolled edits)

https://phabricator.wikimedia.org/T147014 (Bot edits) (talkcontribs)

Is it possible to mark edits that are made by bots and edits that are already ptrolled? 'cause finding the last patrolled review is really hard.

Birgit Müller (WMDE) (talkcontribs)

Hi there, thanks for your feedback!

I created Phabricator tickets: https://phabricator.wikimedia.org/T147012 (patrolled edits)

https://phabricator.wikimedia.org/T147014 (bot edits)

Could you tell a bit more about why you would like to have the bot edits marked?

Cat of the Six (talkcontribs)

I'm a patroller, and when I see bot-made edit, I realise that it's OK and I can omit revising it (and that's me above, really)

Birgit Müller (WMDE) (talkcontribs)

Hey @Cat of the Six,

thanks! Just to be sure that I fully understood you - Do you usually patrol by checking changes in articles on your watchlist and then you go to the diff page and navigate with the RevisionSlider through the last edits? Or do you patrol by checking recent changes? Could you describe your normal workflow a bit? At what point would you use the RevisionSlider in your work as a patroller? Best, Birgit

Cat of the Six (talkcontribs)

Well, I have several big (1-3k) categories that I usually patroll, so I scan "Special:Pending changes" for that category and I follow links (I don't know how they're called in English) between time and size of change. Than I see every article, if difference in diff is small and is not breaking rooles, structure and there is no comlicated syntax change, I patroll it without looking; oterwise I look throgh the whole article to be confident that it's all OK. So when I see a bot-made change, I just skip it (If bot is respecable). It helps when bot does wikification (~30 lines per page) after a pearson, I can check only pearson's change wich is usually very small.

Also, thanks for Phabricator tickets!

Best, Cat of the Six

Birgit Müller (WMDE) (talkcontribs)

Hi @Cat of the Six, thanks for your explanation! I added some more information on the reasoning behind your request to the Phabricator ticket.

Best, Birgit

Option to resize, zoom and change the scale

Summary by Birgit Müller (WMDE)

created a phabricator ticket for the request: https://phabricator.wikimedia.org/T148190.

Malore (talkcontribs)

I'd like to have more control over the graph: set the size of the RevisionSlider, the number of columns visualized and their scale (logarithmic, linear...). However, great extension!

FriedhelmW (talkcontribs)

+1. Good idea!

FriedhelmW (talkcontribs)

+1. Good idea!

Birgit Müller (WMDE) (talkcontribs)

Hi @Malore, thanks for your great feedback! :-) I created a Phabricator ticket for your idea, so that we can keep that in mind: https://phabricator.wikimedia.org/T148190.