Code Health Group/projects/Code Health Metrics/meeting notes/20181015

From mediawiki.org
Jump to navigation Jump to search

Code Health Metrics Working Group - 20181015[edit]

Attendees: JR, Guillaume, Kosta, Zeljko

Agenda:  [edit]

Task Review - https://phabricator.wikimedia.org/project/view/3621/

Action Review:[edit]

  •    JR: to add something to our wiki page regarding our core principle about measuring work in-flight vs historical.
  •    JR: to create a Phab task to collect the output usage requirements.
  •    Zeljko: to create a Phab task with our first 2 week goal https://phabricator.wikimedia.org/T207046
  •    JR: to schedule recurring weekly meeting. Yes Done
  •    Kosta: to update existing tasks with his notes/thoughts from past experiences. Yes Done   

Kosta summary of Code Climate:[edit]

Overview of Code Climate as in : https://phabricator.wikimedia.org/T205133

  • Purely hosted solution
  • Can't control versions of the various tools that they use
  • Scoring weights can be edited.  [todo: double-check this]
  • no base configurations/profiles.  Cust and paste.
  • Build integration with GitHub.  Can set as blocking and/or supressable blocking (particular uses can supress/ignore).  

Guillaume summary of SonarQube:[edit]

  • Configurability is good
  • They develop their own tools, use opensource tools until they can replace the capability internally.  They expand upon the capabilites and improve performance.
  • Rule system for quality gates.  Can be applied to just new changes as well as absolute.
  • had some scaleability issues with onsite instance.
  • java based so it reuires local JVM. (there might be a docker container for running it locally)
  • can push additional metrics

Having a framework like SonarQube is important for scalability moving forward.  

Ensuring that developers have the ability to run locally so that they can proactively make changes prior to committing.  

If you've not done so already, take a look at Kunal's email regarding code coverage.  He's added some additional information including links to trending graphs.  Helps address some of the concerns that were brought up previously.

Action Items:[edit]

  • Zeljko: Create tasks
    • Give a code health metrics talk at All Hands https://phabricator.wikimedia.org/T207044
    • Code health metrics spike https://phabricator.wikimedia.org/T207046
    • Quick and actionable code health metrics feedback https://phabricator.wikimedia.org/T20704
  • JR: to add something to our wiki page regarding our core principle about measuring work in-flight vs historical.
  • JR: to create a Phab task to collect the output usage requirements.