Extension talk:SVNIntegration

From mediawiki.org
Latest comment: 14 years ago by 194.24.138.3 in topic Problems with MediaWiki 1.14.0

Error: Invalid URL[edit]

When I put the following line on my wiki page ...

<svnFileInfo>http://svn.wikimedia.org/svnroot/mediawiki/trunk/Waikiki/Language.php</svnFileHistory>

... I'm getting

UngĂźltige URL: http://svn.wikimedia.org/svnroot/mediawiki/trunk/Waikiki/Language.php

The english equivalent of "UngĂźltige URL:" would be "Invalid URL:".

Trying to access [1] is possible. I'm using MediaWiki 1.12.0, PHP 5.2.0-8+etch10 (apache2handler), MySQL 5.0.32-Debian_7etch5-log. What can I do to make it work?

Kind regards, --Rhododendronbusch 13:10, 29 April 2008 (UTC)Reply

Your closing closing tag does not fit the opening tag: svnFileInfo <> svnFileHistory. I tried your URL in my wiki and it works perfectly if you correct the tags. StefanMacke 09:29, 1 May 2008 (UTC)Reply

Thats very embarrassing to me! Sorry!
Now I changed the tags. But there's still something wrong: Entering the following lines lead to the following errors:
<svnFileInfo>http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia/wiktionary.py</svnFileInfo>

<svnPrintFile revision="1" filetype="py">http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia/wiktionary.py</svnPrintFile>
username, password' are invalid switches for VersionControl_SVN_Info and were ignored. Please refer to the documentation.

'filetype' is an invalid switch for VersionControl_SVN_Cat and was ignored. Please refer to the documentation.
'username, password' are invalid switches for VersionControl_SVN_Info and were ignored. Please refer to the documentation.
Any idea what could be wrong this time?
I'm using subversion 1.4.2. Pear's VersionControl_SVN is 0.3.1 alpha. On [2] it is said that VersionControl_SVN is tested against subversion 1.0.4, could that be a problem? Kind regards. --Rhododendronbusch 15:17, 1 May 2008 (UTC)Reply
Mhh... I had the same problem with username/password and needed to patch VersionControl_SVN. And I already know what is wrong with parameter filetype. I will get a fix tomorrow, when I am back at work and let you know what to do. StefanMacke 16:37, 1 May 2008 (UTC)Reply
Thanks! --Rhododendronbusch 08:01, 2 May 2008 (UTC)Reply
Your problems should now be fixed with version 1.0.1 StefanMacke 08:40, 2 May 2008 (UTC)Reply
Just tested version 1.0.1. But now nothing is displayed. Did you test it with MediaWiki 1.12? Perhaps something has changed there...? Kind regards --Rhododendronbusch 11:06, 2 May 2008 (UTC)Reply
Yes I have just installed the lastest MediaWiki version some days ago. Everything works fine. Is the page displayed or is it completely empty? Have you enabled "display_errors" for PHP? An error message would help... If not, you could add ini_set("display_errors", "on"); at the top of SVNIntegration.setup.php.
Page is rendered as usual. At the position of the expected SVN-Output there is nothing. Error file is empty. --Rhododendronbusch 14:52, 2 May 2008 (UTC)Reply
Could you post the exact markup you entered including the URL? I remember I needed to change a file of VersionControl_SVN to get one of the tags to work, but not exactly which... StefanMacke 08:23, 3 May 2008 (UTC)Reply
Here you are:
<svnFileInfo>http://svn.wikimedia.org/svnroot/mediawiki/trunk/Waikiki/Language.php</svnFileInfo>
<svnFileInfo>http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia/wiktionary.py</svnFileInfo>
----
<svnFileHistory>http://svn.wikimedia.org/svnroot/mediawiki/trunk/Waikiki/Language.php</svnFileHistory>
<svnFileHistory>http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia/wiktionary.py</svnFileHistory>
----
<svnPrintFile revision="1" filetype="py">http://svn.wikimedia.org/svnroot/pywikipedia/trunk/pywikipedia/wiktionary.py</svnPrintFile>
<svnPrintFile revision="1" filetype="py">http://svn.wikimedia.org/svnroot/mediawiki/trunk/Waikiki/Language.php</svnPrintFile>
Kind regards. --Rhododendronbusch 20:15, 4 May 2008 (UTC)Reply
I think the problem is due to Info.php from VersionControl_SVN. Please try the following patch. StefanMacke 12:27, 5 May 2008 (UTC)Reply
Index: Info.php
===================================================================
--- Info.php	(revision 15)
+++ Info.php	(working copy)
@@ -212,6 +212,7 @@
                         break;
                     default:
                         // that's all, folks!
+                        $_switches .= "--$switch $val ";
                         break;
                 }
             } else {
@@ -266,7 +267,7 @@
                 break;
             case VERSIONCONTROL_SVN_FETCHMODE_ASSOC:
                 // Temporary, see parseOutputArray below
-                return join("\n", $out);
+                return $out;
                 break;
             case VERSIONCONTROL_SVN_FETCHMODE_OBJECT:
                 // Temporary, will return object-ified array from
I just tried your patch, but it still doesn't work. I also did a fresh installation of mediawiki on my local xampp. I upgraded pear as described on the PEAR-Mainpage. I only installed VersionControl_SVN and your extension without any further extensions. (Also excluding Geshi). But same here - no output. Neither with patch applied nor without. I'm just wondering that it works on your machine but not on mine. What's the difference? Kind regards --rhododendronbusch 14:15, 5 May 2008 (UTC)Reply
I copied/pasted your exact lines from above and 3 of them worked. The others failed for the fact, that revision 1 of the files does not exist). Could you try adding test outputs to the PHP functions and debug the single steps? I have absolutely no idea what could be wrong...

Problems with MediaWiki 1.14.0[edit]

I am running MediaWiki 1.14.0 and get some errors when trying to save an article containing one of the svn tags. I guess it has to do with recent changes in MediaWiki 1.14.0 in file includes/parser/Parser.php.

Notice: Undefined property: Article::$title in /srv/www/htdocs/mediawiki-1.14.0/extensions/SVNIntegration
/SVNIntegration.body.php on line 104

Catchable fatal error: Argument 2 passed to Parser::parse() must be an instance of Title, null given,
 called in /srv/www/htdocs/mediawiki-1.14.0/extensions/SVNIntegration/SVNIntegration.body.php on line 104
 and defined in /srv/www/htdocs/mediawiki-1.14.0/includes/parser/Parser.php on line 300


simply change $article->title to $article->mTitle in line 104 of SVNIntegration.body.php --194.24.138.3 14:25, 24 November 2009 (UTC)Reply

public repository[edit]

Hello,

is there anywhere a public repository for the newest code? I will run it in MediaWiki 1.30 and VersionControl_SVN 0.5.2