Extension:MobileFrontend/Deployments/2012-12-26
High Level[edit]
Stories[edit]
Bugs[edit]
https://bugzilla.wikimedia.org/show_bug.cgi?id=43425 Wide images are distorted https://bugzilla.wikimedia.org/show_bug.cgi?id=43280 Cache shouldDisplayMobileView for duration of request https://bugzilla.wikimedia.org/show_bug.cgi?id=42705 Editing sometimes sends user to desktop site https://bugzilla.wikimedia.org/show_bug.cgi?id=42804 RTL hamburger menu badly styled https://bugzilla.wikimedia.org/show_bug.cgi?id=43138 Style screen flash on watchlist https://bugzilla.wikimedia.org/show_bug.cgi?id=36182 Switching between desktop and mobile view should redirect to canonical URLs
Uncategorized[edit]
Localization changes Enable Random only when history is supported Fix and cleanup qunit tests Add PhatomJS runner to qunit Add Donate Image [alpha] Add padding to #mw-mf-overlay [bug in beta] Allow switching between watchlist reading view and changes view [beta] List watchlist in alphabetical order
Git Log[edit]
commit d69ac91b69f83b1f226bddf6d065aca2da022283 Author: MaxSem <maxsem.wiki@gmail.com> Date: Wed Dec 26 21:32:51 2012 +0000
Revert "move photo uploads to beta" This reverts commit d6352be5d5f13a776b52431ca267bbe10860f15f
commit 470d04417f25c40a3a969801af63c3315e418144 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Dec 26 21:11:19 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: If1b4c27906b00250dbb5983e0846af5691038847
commit 2eacf5d8010b6f12bac8a2130c291ebaf17d2c5e Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 24 14:45:07 2012 +0000
exclude phantomjs-qunit-runner from jshint putting in a folder called externals and updating .jshintignore external libraries cannot be guaranteed to pass jshint tests using external folder gives us a generic way to do this Change-Id: I9a46ff12b2f611689362ea3a5f1a0a37bd3279ec
commit 96b34bca4727d52357c529f2a80aa49d665c6d3c Author: Brion Vibber <brion@pobox.com> Date: Wed Dec 26 09:34:04 2012 -0800
* (bug 43425) Fix aspect ratio on images reduced to fit width We were setting a max-width but the height was left at the implicit original height of the image. Adding height: auto resolves this by keeping the aspect ratio neat. Change-Id: I72f027130b464a41e18bfad06b76c8146849b726
commit fb1463cf9f903ca23bd295954a952f636f8cc793 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Dec 25 20:10:04 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ia718ed8ab38162cc755e89ce494795351c1b6cdb
commit d625c155d7dd67d0a18714c9405243299bdf90cd Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 11:03:33 2012 +0000
protect against no jQuery if $ is false an exception will be thrown Change-Id: I2c578c861c17edb6578c07604764e675425ca7d3
commit d6352be5d5f13a776b52431ca267bbe10860f15f Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 24 09:57:33 2012 +0000
move photo uploads to beta Change-Id: Icec6578beccdc7b04d18ebbf0d81ad96486e9bc1
commit 9bf966deaae55e6235b55624488c41021eaa9c0f Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Dec 23 21:54:42 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I09da251da151cbbc802391d12bc66db4952e1cf9
commit 40a8ca3bbfbb145a195ec92a8c63e066c538d40e Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Dec 22 22:13:57 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Iddc1ebf2c243db47318a60bfd53a825abf1376b7
commit f0e7c0826447aa542ad7eb264643cb794c0db871 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Dec 21 20:15:37 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Iac2d6e11ac82a096071fca290ff04bf2e5f88ccd
commit 7a160c71248a4747915fd1a7b229eac70e4ec776 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 17:21:22 2012 +0000
only enable random module when history api supported currently it results in weird redirections on android 4.x for example this stops this behaviour Change-Id: Iec1edc8763ab29acab5eeca4f01a022a4db55c9c
commit ae44a761cf87e59e6492680db6c2ba89677d9893 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 21 10:55:23 2012 +0000
don't bind the jQuery shim to $ some existing tests seem to use $ directly rather than alias jQuery. Since we alias jQuery everywhere (or at least should be) taking away this alias for the shim Change-Id: Icd1896e089e2f1b052e48a6166535d42b7cd7773
commit 13007b890678f8a27ff47054c9e9f89b76d85a3c Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Dec 20 21:04:09 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I7fd030aa6d35046e32859bc5ac8716e340bac2da
commit e7369b5ca7df716505a2392db8d61e2c08a968d2 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Thu Dec 20 23:57:34 2012 +0400
Bug 43280 - Cache shouldDisplayMobileView() results Change-Id: I670f767ee4e67c1e4912e258985ace22bfc6384e
commit 251ba67763a914010828c3cecffabc19dde5e917 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 11:24:43 2012 -0800
refactor when to show photo uploader break out an articleNeedsPhoto function and expose it so we can write tests for it Change-Id: I80e79a2a6808c3177eaf8fcece0c4cf7502b8765
commit b2e7938ec0efcff11b1818655359d491c2dd6ad2 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Dec 19 20:00:49 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I5e2d96c45daaaf51db245c291aa009d37e1c251b
commit 848c4097dbc47a9993be3b7a01c0d5965c9c17a7 Author: jrobson <jrobson@wikimedia.org> Date: Wed Dec 19 10:45:52 2012 -0800
fix broken qunit test it is now mandatory when using replaceHash that an item with that hash exists in the DOM update whitespace in mf-history.js whilst at it Change-Id: I793ac56f84ecd30b859519ce1aeca48148229169
commit 5304beeb8e041fb1e204d0c03988a33de7de5faa Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Dec 18 18:12:17 2012 -0800
Add a PhantomJS runner for QUnit tests Now `make qunit` runs tests in the terminal instead trying to open a browser window. Also updated the pre-commit hook. Change-Id: I6ebbb7c6c08d72b85dae09600274e59125c81c00
commit 0a5dd6094b97539e59e41d93562621319b4a1764 Author: raymond <raimond.spekking@gmail.com> Date: Wed Dec 19 19:21:27 2012 +0100
Sync special page alias file In https://gerrit.wikimedia.org/r/#/c/39155/8/MobileFrontend.php,unified * 'DonateImage' was added * 'MobileDiff' and 'MobileMenu' were added somewhere in the past * 'MobileFrontend' was removed somewhere in the past Change-Id: Idc9711054fd18b7321ff62de1c71c90fcd7480c9
commit 122fe58f5c3ee99eb1f4b787bae19d38293dc80b Author: Max Semenik <maxsem.wiki@gmail.com> Date: Sat Dec 8 04:58:12 2012 +0400
Bug 42705 - editing sometimes sends user to desktop site Consider it an experiment, needs much investigation and testing Change-Id: I7a74e20eac58cdf15d00e09407ef22a31b826d69
commit 3e2cf4666cc2bae38b4a08c8290efa8591e364b6 Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 18 13:53:02 2012 -0800
fix an epic fail ......................................__................................................ .............................,-~*`¯lllllll`*~,.......................................... .......................,-~*`lllllllllllllllllllllllllll¯`*-,.................................... ..................,-~*llllllllllllllllllllllllllllllllllllllllllll*-,.................................. ...............,-*llllllllllllllllllllllllllllllllllllllllllllllllllllll.\.......................... ....... .............;*`lllllllllllllllllllllllllll,-~*~-,llllllllllllllllllll\................................ ..............\lllllllllllllllllllllllllll/.........\;;;;llllllllllll,-`~-,......................... .. ...............\lllllllllllllllllllll,-*...........`~-~-,...(.(¯`*,`,.......................... ................\llllllllllll,-~*.....................)_-\..*`*;..).......................... .................\,-*`¯,*`)............,-~*`~................/..................... ..................|/.../.../~,......-~*,-~*`;................/.\.................. ................./.../.../.../..,-,..*~,.`*~*................*...\................. ................|.../.../.../.*`...\...........................)....)¯`~,.................. ................|./.../..../.......)......,.)`*~-,............/....|..)...`~-,............. ..............././.../...,*`-,.....`-,...*`....,---......\..../...../..|.........¯```*~-,,,, ...............(..........)`*~-,....`*`.,-~*.,-*......|.../..../.../............\........ ................*-,.......`*-,...`~,..``.,,,-*..........|.,*...,*...|..............\........ ...................*,.........`-,...)-,..............,-*`...,-*....(`-,............\....... ......................f`-,.........`-,/...*-,___,,-~*....,-*......|...`-,..........\........ Change-Id: I75ab58e962d8b8483de8b00bb46ddc27065db861
commit 4015fd28ac9bd16d7c6dc130b69c12df94af1be0 Author: jrobson <jrobson@wikimedia.org> Date: Tue Dec 18 13:25:32 2012 -0800
remove random sentence how did this guy sneak in? Change-Id: I83c921a915ccff0cd29e51b97dbfbfe98efd2175
commit b474699c570622e3562ec24b2eedad7869648e32 Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 17 15:21:20 2012 -0800
add a donate image page [alpha] generic upload interface for logged in users: to help reach target of 1,000 mobile uploaders/month show a donate image page to logged in users show users latest photo contributions here and allow them to upload a photo here refactor mf-photo code so that the call to action can be shown on any page where required and also refactor it so that the second step of including the image on the wikipage is optional use temporary image in left menu Change-Id: I35ce2e597b753039649c2727203c0ac1b73b565b
commit 9f65f4b06a5751535b3403218690601ff4609fe1 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Dec 18 20:37:09 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ia07dded364677c348f5dc12af77a3d54f56c04fb
commit afdb7ac86a060fe632fb97b5572a5c47b0eaf4ab Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 17 17:04:50 2012 -0800
make sure #mw-mf-overlay .header gets padding left [bug in beta] language overlay currently styled badly seems to have been introduced by Ifd540d3b787e588bcec88c8f75132ab9370cc912 Change-Id: I25253c90b368b3628f67836e45877795e290996d
commit 2df59d68b9b706c1fb2b6b9d842d91624b7c5e86 Author: jrobson <jrobson@wikimedia.org> Date: Mon Dec 17 16:09:35 2012 -0800
i18n change for hamburger menu (bug 42804) this ensures that the icons appear on the right of the menu in rtl mode rather than the left of the menu Change-Id: I102fc7795784ecdb83eada8d674d9155d99038f8
commit ac2eeba806c15a3ae7d232673f219235dc85b386 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Dec 17 21:27:29 2012 +0000
Localisation updates from http://translatewiki.net. Change-Id: I28af570c112a6e101c29373decba1154bbc5650d
commit d7094470afcdc319c68b04410ca3f0cc3e213057 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 13 14:36:48 2012 -0800
allow switching between watchlist reading view and changes view [beta] introduces the ability for an anchor tag to style itself as a button and button styling for buttons inside the header at the top of the page slight adjustment to left nav to remove button class from random link which is currently not being used for any purpose. Change-Id: I6a74c1e7ae1ae3e72b2e5ffffc2e473236ae80a6
commit 7cbb9a043d22c36fad8f175ad0b1286da8287abb Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 14 16:29:30 2012 -0800
when focus initialise textarea height to show all the content this creates a pre element with the same content takes the height and then sets the textarea to that height when the user focuses the element on clicking enter or backspace it readjusts itself Change-Id: I7ada08794210cdbbd5a7d5864c995e260e0f112e
commit 3910129b0cb5879a977d7835626cebfe096527f8 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 13 11:53:45 2012 -0800
list watchlist in alphabetical order [beta] this is default view on watchlist Change-Id: I4e06dd38982901f048c8863c6adf49a360dd2dc2
commit e127c07c2e0bb5b9a3c6b2336ea4d80c32ae8b99 Author: jrobson <jrobson@wikimedia.org> Date: Fri Dec 14 15:53:05 2012 -0800
watchlist styles / load RL at top of page (bug 43138) this moves the script tag for RL to the head of the document this means stylesheets can be loaded dynamically before the page content has loaded Change-Id: Ib5b0008a1cc38fb4ec396459f5a32158ad611bfd
commit b3efeb6676ed609f51a8e4d4de19522ee49df2f8 Author: jrobson <jrobson@wikimedia.org> Date: Thu Dec 13 11:32:52 2012 -0800
allow two modes for watchlist [beta] this refactors watchlist code so that we can have two views on the watchlist - reading mode and recent changes mode currently only recent changes mode implemented accessed by watchlistview=feed query string parameter Change-Id: Iaea2b97ef7e56c9a131cdb296c4e3d2ca22658c4
commit ceae2c5a2b9cb54417a804bcae857a00c38f9c50 Author: awjrichards <arichards@wikimedia.org> Date: Mon Dec 3 17:45:07 2012 -0700
Make 'mobile view' link respect canonical URLs when possible Addresses bug 36182 Change-Id: I93af392e3b27017f95e36acd7c0651d3b896741a