Code review management
| Group: | Platform |
| Management: | Rob Lanphier |
| Team: | Tim Starling, Chad Horohoe, Sam Reed, Aaron Schulz |
Code review is the systematic examination of MediaWiki core and extension code revisions intended to find and fix mistakes overlooked in development.
This page is about Wikimedia-sponsored code review, focusing on MediaWiki core and extensions used on Wikimedia production wikis.
Contents |
[edit] Status
-
[edit status] • [add new]2012-04-monthly: The Wikimedia engineering 20% policy is the current approach of the Wikimedia Foundation to improving the code review situation. With the move to Git, we no longer have a code review backlog in trunk, but we are still facing a backlog of patches to review (in Gerrit and Bugzilla), RFCs to comment on, and extensions to review.
[edit] Rationale
We have a large community of developers who are frustrated with the current velocity of our code reviews. On the flip side, we need to review changes made to the site carefully enough such that our operations team doesn't have to continuously recover from poor developer choices.
[edit] Timeline
In the long term, we are brainstorming now how to best identify and train community members to take up some of the code review tasks and how to provide appropriate oversight to ensure that we continue to catch potential style, architecture, performance, and security flaws in submitted code.
Other than "just get cracking" (which we're doing), one other thing is to try to improve visibility into the problem. Rob Lanphier plans to start reporting on our current metrics based on some work that Bryan Tong Minh has already started. See code review status graph to see the number of "ok" commits plotted against the number of total commits in the "phase3" branch.
[edit] Additional documents
- Open merge requests for MediaWiki and its extensions
- Code of the code review status graph
- Status updates
