r48842 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48841‎ | r48842 | r48843 >
Date:20:00, 25 March 2009
Author:raymond
Status:ok (Comments)
Tags:
Comment:
* Add CSS defintion of the 'wikitable' class to shared.css. Style copied from enwiki.
A lot of core and extension tables use this class but without the definition it is useless, espescially on third party installations.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -339,3 +339,23 @@
340340 background: url("images/feed-icon.png") center left no-repeat;
341341 padding-left: 16px;
342342 }
 343+
 344+/* wikitable class for skinning normal tables */
 345+table.wikitable {
 346+ margin: 1em 1em 1em 0;
 347+ background: #f9f9f9;
 348+ border: 1px #aaa solid;
 349+ border-collapse: collapse;
 350+}
 351+.wikitable th, .wikitable td {
 352+ border: 1px #aaa solid;
 353+ padding: 0.2em;
 354+}
 355+.wikitable th {
 356+ background: #f2f2f2;
 357+ text-align: center;
 358+}
 359+.wikitable caption {
 360+ font-weight: bold;
 361+}
 362+
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1469,7 +1469,7 @@
14701470 * to ensure that client-side caches don't keep obsolete copies of global
14711471 * styles.
14721472 */
1473 -$wgStyleVersion = '207';
 1473+$wgStyleVersion = '208';
14741474
14751475
14761476 # Server-side caching:
Index: trunk/phase3/RELEASE-NOTES
@@ -151,6 +151,7 @@
152152 on a different database
153153 * Add a class if 'missingsummary' is triggered to allow styling of the summary
154154 line
 155+* Add CSS defintion of the 'wikitable' class to shared.css
155156
156157 === Bug fixes in 1.15 ===
157158 * (bug 16968) Special:Upload no longer throws useless warnings.

Follow-up revisions

RevisionCommit summaryAuthorDate
r48844Follow-up r48842: use the "wikitable" CSS style since it's now in coreialex20:08, 25 March 2009
r66535Add styles for printing wikitables....hartman15:42, 16 May 2010

Comments

#Comment by Simetrical (talk | contribs)   00:54, 26 March 2009

Good change, I've been meaning to do this for a while.

#Comment by Brion VIBBER (talk | contribs)   23:21, 15 April 2009

nom nom nom

Status & tagging log