Topic on Project:Support desk

Hi!

During a page request I sometimes get this message:

"LoadBalancer::reuseConnection: this connection was not opened as a foreign connection"

It is not there on every page load, but sometimes. When it is there, then it appears several times in a row.

In my case reuseConnection() always ends up with this message; the following code is never executed.

What does that tell me? Does that mean that I could or should improve something?

According to the code https://github.com/wikimedia/mediawiki-core/blob/master/includes/db/LoadBalancer.php#L522

/**
* This can happen in code like:
* foreach ( $dbs as $db ) {
* $conn = $lb->getConnection( DB_SLAVE, array(), $db );
* ...
* $lb->reuseConnection( $conn );
* }
* When a connection to the local DB is opened in this way, reuseConnection()
* should be ignored
*/

Ok, so this should not happen. Issue 49529 created.