Page MenuHomePhabricator
Create Task
Maniphest T105676

Remove "coder" and "svnadmins" group from mediawiki.org
Closed, ResolvedPublic
Actions

Description

Similar to T105570: Remove old user groups from Wikimedia wikis (afttest, afttest-hide, etc.).

These two groups no longer have any rights related to Extension:CodeReview. There're no reason to keep them. Just remove them from $wgAddGroups and $wgRemoveGroups.

Existed members of coder group except admins should be moved to "autoreview" group.

Announcement: https://www.mediawiki.org/wiki/Project:Requests#Delete_.22coder.22_and_.22svnadmins.22_group

Details

SubjectRepoBranchLines +/-
Properly remove SVN Adminsoperations/mediawiki-configmaster+0 -1
Remove SVN admin and coder groups from mediawiki.orgoperations/mediawiki-configmaster+3 -5
Customize query in gerrit

Related Objects

Event Timeline

Bugreporter created this task.Jul 13 2015, 8:49 AM
Bugreporter raised the priority of this task from to Needs Triage.
Bugreporter updated the task description. (Show Details)
Bugreporter added a project: Wikimedia-Site-requests.
Bugreporter added subscribers: Bugreporter, Legoktm, Krenair.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptJul 13 2015, 8:49 AM
Meno25 subscribed.Jul 13 2015, 1:22 PM
Krenair added a comment.Jul 13 2015, 1:58 PM

Cleared SVN admins

Krenair claimed this task.Jul 13 2015, 2:05 PM
Krenair added a comment.Jul 13 2015, 2:19 PM

Cleared coders as well

Jdforrester-WMF triaged this task as Medium priority.Jul 13 2015, 2:22 PM
Jdforrester-WMF set Security to None.
gerritbot subscribed.Jul 13 2015, 2:39 PM

Change 224420 had a related patch set uploaded (by Alex Monk):
Remove SVN admin and coder groups from mediawiki.org

https://gerrit.wikimedia.org/r/224420

gerritbot added a project: Patch-For-Review.Jul 13 2015, 2:39 PM
Krenair added a subscriber: • brion.Jul 13 2015, 2:39 PM

I wonder about this line still:

wmf-config/wgConfVHosts.php:	// 'wikimedia.org' // Removed 2008-09-30 by brion -- breaks codereview-proxy.wikimedia.org
• Purodha mentioned this in T105701: Bogus e-mail notification about a page change when user rights are changed.Jul 13 2015, 4:03 PM
Dereckson moved this task from Backlog to Working on on the Wikimedia-Site-requests board.Jul 15 2015, 11:18 AM
gerritbot added a comment.Jul 15 2015, 4:02 PM

Change 224420 merged by jenkins-bot:
Remove SVN admin and coder groups from mediawiki.org

https://gerrit.wikimedia.org/r/224420

Krenair mentioned this in rOMWCd6e1d29752e3: Remove SVN admin and coder groups from mediawiki.org.Jul 15 2015, 4:02 PM
Bugreporter added a comment.Jul 16 2015, 8:12 AM

Got rid of coders, but SVN admins still exist

Krenair added a comment.Jul 16 2015, 4:20 PM

Yeah. No way to properly remove it completely, think we should just do https://gerrit.wikimedia.org/r/#/c/224999/ instead

Krenair closed this task as Resolved.Jul 16 2015, 9:30 PM

Let's call this done on the Wikimedia config side.

Krenair moved this task from Working on to Done on the Wikimedia-Site-requests board.Jul 16 2015, 9:30 PM
Meno25 unsubscribed.Jul 17 2015, 7:59 AM
gerritbot added a comment.Mar 8 2016, 3:19 PM

Change 275824 had a related patch set uploaded (by Alex Monk):
Properly remove SVN Admins

https://gerrit.wikimedia.org/r/275824

Restricted Application added a subscriber: JEumerus. · View Herald TranscriptMar 8 2016, 3:19 PM
gerritbot added a comment.Mar 10 2016, 12:08 AM

Change 275824 merged by jenkins-bot:
Properly remove SVN Admins

https://gerrit.wikimedia.org/r/275824

Krenair removed a project: Patch-For-Review.Mar 10 2016, 12:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL