r33656 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r33655‎ | r33656 | r33657 >
Date:21:21, 20 April 2008
Author:btongminh
Status:old
Tags:
Comment:
(bug 13803) Add 'reupload' parameter to allow reuploads of existing blacklisted images.
Modified paths:
  • /trunk/extensions/TitleBlacklist/TitleBlacklist.hooks.php (modified) (history)
  • /trunk/extensions/TitleBlacklist/TitleBlacklist.list.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TitleBlacklist/TitleBlacklist.hooks.php
@@ -54,7 +54,11 @@
5555 public static function verifyUpload( $fname, $fpath, &$err ) {
5656 global $wgTitleBlacklist;
5757 efInitTitleBlacklist();
58 - $blacklisted = $wgTitleBlacklist->isBlacklisted( Title::newFromText( $fname, NS_IMAGE ), 'upload' );
 58+
 59+ $title = Title::newFromText( $fname, NS_IMAGE );
 60+ $action = $title->exists() ? 'reupload' : 'upload';
 61+
 62+ $blacklisted = $wgTitleBlacklist->isBlacklisted( $title, $action );
5963 if( $blacklisted instanceof TitleBlacklistEntry ) {
6064 wfLoadExtensionMessages( 'TitleBlacklist' );
6165 $message = $blacklisted->getCustomMessage();
Index: trunk/extensions/TitleBlacklist/TitleBlacklist.list.php
@@ -209,6 +209,9 @@
210210 if( !isset( $this->mParams['noedit'] ) && $action == 'edit' ) {
211211 return true;
212212 }
 213+ if ( isset( $this->mParams['reupload'] ) && $action == 'reupload' ) {
 214+ return true;
 215+ }
213216 return false;
214217 }
215218 return true;
@@ -240,6 +243,9 @@
241244 if( $opt2 == 'casesensitive' ) {
242245 $options['casesensitive'] = true;
243246 }
 247+ if( $opt2 == 'reupload' ) {
 248+ $options['reupload'] = true;
 249+ }
244250 if( preg_match( '/errmsg\s*=\s*(.+)/i', $opt, $matches ) ) {
245251 $options['errmsg'] = $matches[1];
246252 }

Status & tagging log