User talk:WikiBhasha.MSR

From mediawiki.org
Latest comment: 13 years ago by Peachey88 in topic comment

Please confirm your e-mail address[edit]

Hi. This wiki user account has been connected to the MediaWiki committer "wikibhasha.msr". Please confirm your e-mail address so that you will be able to be notified of any Code Review comments. Thanks. siebrand 15:46, 29 September 2010 (UTC)Reply

comment[edit]

Hello K. Saravanan, Just a quick note, you might want to use Special:Code to comment on code revision. It is easier to use than talk pages :p Since you have a Wiki account, you should be able to comment on [1]. For now, I will answer to your message right here :p

We used “target=_blank” to load the external URL in a new window to prevent any data loss in WikiBhasha in case if the user did any edits. Please help us in understanding how exactly your changes here will help WikiBhasha in not losing any data.

  • hashar> I do not like the target=_blank since it force the user to get a new window when it would have preferred to reuse the current windows. Since the text seems to be an introduction, I did not thought about the data loss. In this context, the target=_blank should probably be put back. Feel free to revert this change :b Hashar 12:33, 29 November 2010 (UTC)Reply
  • In regards to the _blank the matter is that it forces the browser to load a new window (even when most support tabs these days) and it generally agreed for mediawiki related matters that it should be the users choice and not the developers choice when it comes to these matters. Peachey88 12:49, 29 November 2010 (UTC)Reply

We checked the class definition of “external” and we are unable to understand how it is going to enable the user to make the chose. These are the two declarations we found in Wikipedia and there were no declaration in WikiBhasha code referring this class.

content a.external {
color:#3366BB;
}
content a.external, #content a[href^="gopher://"] {
background:url("images/external-link-ltr-icon.png?2") no-repeat scroll right center transparent;
padding:0 13px 0 0;
}
  • hashar> the "external" class is part of the skin. So you do not need to declare it in WikiBhasha. The class is used to stylize anchors (<a>) to an external URL. Hashar 12:33, 29 November 2010 (UTC)Reply
  • The external class is a class that should be applied to all external links so that they get classed appropriately (and add the arrow icon next to it) and it makes it easier for end users that want to do extra styling to them via their personal user css and javascript pages. Peachey88 12:49, 29 November 2010 (UTC)Reply

Coder Group[edit]

I have added your account to the 'coder' group (see Special:ListGroupRights). This will let you change the status of revisions in Special:Code. Hashar 12:39, 29 November 2010 (UTC)Reply