User talk:Sarveshgpt1991/WIE

From mediawiki.org
Latest comment: 9 years ago by Nemo bis in topic Code review

Microtasks[edit]

Have you completed any microtasks? This is a requirement to be accepted as a GSoC student in Wikimedia. Check with your mentors. Please link to your bugfixes or other microtasks from your proposal and your entry at Google Summer of Code 2014.--Qgil (talk) 18:37, 27 March 2014 (UTC)Reply

Minimum viable product[edit]

Your proposal defines very disrete milestones and phases. However, we request our candidates to define a minimum viable product, the minimum set of features that should be pushed first as a testable release. We do this to avoid a common problem of students putting a lot of time in one aspect, and then not having time enough to complete the rest, ending up with nothing that actually works. Please fine tune your proposal to define this. Thank you.--Qgil (talk) 18:37, 27 March 2014 (UTC)Reply

I agree. You define 6 deliverables and 5 of them are marked as required, so the distinction is of little use.
In general, this proposal seems to lack focus.
  • In several phases you mention tasks you'll do but no concrete, visible result one can "touch", though maybe to devs this makes some sense.
  • I have no idea what bots have to do with the project.
  • The OAuth component absolutely can't be the second last thing you make: it's the only required component of this project! I don't know how this data is currently stored, but it really doesn't matter. It could be a wiki table on a page of wikitech: wiki, or anything; it's just a list of nicknames. The only requirement is that, while being openly editable, data about a person should be edited only by that person, as identified by wikitech wiki (via OAuth if not happening on the wiki itself). --Nemo 06:55, 3 April 2014 (UTC)Reply

Repositories[edit]

You suggest to publish your code in your own GitHub repository. Why not in a repository within Metrics Grimoire? It is important to get as much community attention as possible. I'm interested in hearing the opinion of your mentors.--Qgil (talk) 18:37, 27 March 2014 (UTC)Reply

And now it says gerrit? I'm confused as well. --Nemo 06:55, 3 April 2014 (UTC)Reply

Code review[edit]

Please familiarise yourself with what is meant by code review around here. "Conduct code review by myself" is a contradiction, and it surely can't come at the end of your project. --Nemo 06:55, 3 April 2014 (UTC)Reply