User talk:Jossmart

From MediaWiki.org
Jump to navigation Jump to search

RequestContext[edit]

Jossmart, you really don't want to use RequestContext::getMain(). It's a pointless and counterproductive thing to do. In that callback you defined you had an OutputPage in the $out parameter. An OutputPage is a context source so you can make your get{User,Request} calls directly on $out. Daniel Friesen (Dantman) (talk) 11:25, 30 July 2012 (UTC)

Thanks for your advice, I appreciate it. I'll make some changes. --Jossmart (talk) 11:40, 30 July 2012 (UTC)

Oh Jossmart. msg() is actually part of a context source as well. So you don't need to drop right to wfMessage.

Though I do have two other notes. You shouldn't string concatenate message like that directly. You should explicitly use the right method for what kind of output you want. Primarily ->text() for plaintext and ->parse() for parsed WikiText (See Manual:Messages API). Also please avoid concatenating raw html, it's really risky and you can easily introduce an XSS vector into your wiki. We have a really nice Html class that lets you do things like Html::element( 'a', array( 'href' => $url ), 'some raw text with <dangerous> characters.' );. Daniel Friesen (Dantman) (talk) 12:42, 30 July 2012 (UTC)

Thanks, I'm working on it. Mediawiki offers lots of manuals and information, but it's sometimes hard to understand. Some place with simple self-explanatory programming examples (how to do things the right way) would be great. --Jossmart (talk) 14:11, 30 July 2012 (UTC)
Heh... ;) that's bug 1. Daniel Friesen (Dantman) (talk) 14:16, 30 July 2012 (UTC)

URNames repo[edit]

Hi Jossmart. I created your repo a little while ago, but you don't seem to have ever logged into Gerrit with your labs account. I need you to do this at your earliest convenience so I can grant you permission to your new repo and you can get to using it. Thanks! ^demon (talk) 17:08, 8 August 2012 (UTC)

I'm sorry for this delay, vacation time. And moreover I don't have any experiences with SVN or GIT and it's not completely clear to me (docs, workflow etc.). Some simple tutorial of publishing a new extension to gerrit would be great. I managed to find this page https://gerrit.wikimedia.org and I logged into. Is it ok now? Thanks --Jossmart (talk) 07:47, 9 August 2012 (UTC)
Yes, you seem to have logged in so I was able to grant you the rights on your extension URNames that I created in Git/Gerrit. As far as documentation, I think the best place to start is the tutorial that we've written. Also, people on IRC are generally helpful and able to answer any questions you may have regarding the process. Thanks for your quick response! ^demon (talk) 19:06, 10 August 2012 (UTC)

ArticleIndex licensing[edit]

Hello Jossmart. As author of Extension:ArticleIndex your input at https://phabricator.wikimedia.org/T184846 would be appreciated. Best regards, —MarcoAurelio (talk) 08:36, 13 January 2018 (UTC)

I'm sorry, I don't have much time to take care of my things on mediawiki. I'm not familiar with gerrit, I clicked something. Is it ok now? --Jossmart (talk) 07:30, 15 January 2018 (UTC)
Hello. Thanks for merging the patch. However we still have doubts as to which GPL version of the license is your extension. No need to post on Gerrit/Phabricator if you're not familiar with them. I can copy your replies over there. Regards, —MarcoAurelio (talk) 07:34, 15 January 2018 (UTC)
I've changed to GPL-3.0 at extension page, is it ok? I don't care about the licence. But I understand it should be the same at all places. --Jossmart (talk) 07:38, 15 January 2018 (UTC)
Yes, I think it'll be okay to license as GPL-3.0-only. Thanks. —MarcoAurelio (talk) 07:39, 15 January 2018 (UTC)