User:TCipriani (WMF)/Gerrit/Review
๐ง๐ฝโ๐ป Gerrit for Product Analytics
- ๐ Home
- ๐ง Tutorial
- ๐ Commit messages (Using
Bug:
) - ๐ Uploading changes
- ๐ข Reviewing and submitting
๐ข Reviewing and submitting
Continuous Integration, Jenkins-Bot, and Autosubmit
In general, once you vote CR+2
: you're done!
Sometimes, you will need to vote V+2
and then click the Submit
button.
Submit
These are a sublist of repos that Product Analytics cares about along with whether or not you have to vote V+2
and click Submit
Repo | Use submit |
---|---|
schemas/event/secondary | NO โ |
analytics/wmf-product/jobs | YES โ |
Labels
Code-Review
(CR
)Verified
(V
)
Voting
Don't let numbers confuse you: they're just tags.
Verified
+2
: This repo does not auto merge, and I am ready to merge
Code Review
+1
: I like this change, but I have some questions or nitpicks for the author-1
: I have spotted some small issues in this change+2
: I am merging this change-2
: I never want this change to mergeโthe concept is bad