Topic on Skin talk:Minerva Neue

Don't call $output->setPageTitle() with empty string

2 comments • 14:37, 10 August 2021 2 years ago

2

With Minerva skin activated and not logged in, on homepage I found that the page title is empty, including the title bar (in the browser). Leaving weird title there - My Wiki Site.

The cause is here: /skins/MinervaNeue/includes/Skins/SkinMinerva.php there is:

$out->setPageTitle( $pageTitle );

It should be wrapped with a conditional:

if ( strlen($pageTitle) ) {

    $out->setPageTitle( $pageTitle );

}

Quick fix is appreciated. Thanks.

Reply 12:47, 10 August 2021 2 years ago

Jdlrobson (talkcontribs)

This is phab:T265892. Patches welcome.

Reply 14:37, 10 August 2021 2 years ago

Reply to "Don't call $output->setPageTitle() with empty string"