Topic on Project:Support desk

Upgrade PrivatePageProtection.php for Mediawiki 1.34.2

5
Summary by Jack Phoenix

It's fixed now and lightly tested on MediaWiki 1.39. See this gerrit changeset and refer to Extension:PrivatePageProtection for download link, installation instructions, usage, etc.

And note that it's probably still as insecure as ever, so do give security issues with authorization extensions a read.

Zer00CooL (talkcontribs)

PrivatePageProtection (archived) work with 1.33.3

Files Source : https://phabricator.wikimedia.org/diffusion/SVN/browse/trunk/extensions/PrivatePageProtection/


Now, with Mediawiki 1.34.2, PrivatePageProtection not work :

https://privatebin.visionduweb.fr/?8039658573b9ed9d#GbeVLFerzrd7go8NNRn22y6nwfWCkseHXZP7vpUK2Mjd


I replace DB_REPLICA instead of DB_SLAVE on :

sudo nano /var/www/mediawiki/extensions/PrivatePageProtection/PrivatePageProtection.php line 95

//      $dbr = wfGetDB( DB_SLAVE );

       $dbr = wfGetDB( DB_REPLICA );


Then, i have this error :

/index.php?search=joomla&title=Sp%C3%A9cial%3ARecherche&fulltext=1 TypeError from line 3367 of /var/www/wiki.visionduweb.fr/languages/Language.php: Argument 1 passed to Language::commaList() must be of the type array, null given, called in /var/www/wiki.visionduweb.fr/extensions/PrivatePageProtection/PrivatePageProtection.php on line 132

https://privatebin.visionduweb.fr/?8986b983a4d95d45#BMyweusa8P6ekukDnWp4CBoN4M8wwcC6UZaKyeGDY84X

               $err = array(

                       'badaccess-groups',

                       $wgLang->commaList( $groupLinks ), // This line is the 132.

                       count( $groups )

Bawolff (talkcontribs)

i'm not sure what your question is? The extension is archived because it doesn't work anymore and nobody has stepped forward saying they are willing to fix it.

Zer00CooL (talkcontribs)

I need help for debug :


TypeError from line 3367 of /var/www/wiki.visionduweb.fr/languages/Language.php: Argument 1 passed to Language::commaList() must be of the type array, null given, called in /var/www/mediawiki/extensions/PrivatePageProtection/PrivatePageProtection.php on line 132


See all message here : https://privatebin.visionduweb.fr/?8986b983a4d95d45#BMyweusa8P6ekukDnWp4CBoN4M8wwcC6UZaKyeGDY84X


PrivatePageProtection.php

Code line 132 :

  $err = array(

    'badaccess-groups',

// This line is the 132 : must be of the type array, null given

$wgLang->commaList( $groupLinks ),

     count( $groups )


I create a repo Github for this : https://github.com/ZerooCool/PrivatePageProtection

TiltedCerebellum (talkcontribs)
Jack Phoenix (talkcontribs)