Topic on VisualEditor/Feedback

Jump to navigation Jump to search

Does VE munge white space?

19
Mathglot (talkcontribs)

Does VE munge white space under certain circumstances? I wouldn't mind if VE eats two spaces to make one space inside sentences for example, or chops useless trailing blanks and that sort of thing. But if VE is responsible for the white-space changes in these two edits (and I'm not at all sure that it is), then that's annoying. w:User:Haywalk is trying to make one small change to one line in an Infobox at w:Kingdom of France and tried twice to do so, but the result was 424 bytes changed in 48 lines. Related discussion can be found here. Thanks, Mathglot (talk) 20:49, 15 May 2020 (UTC)

Whatamidoing (WMF) (talkcontribs)

Hi, Mathglot,

Yes, you're right, that's not Haywalk's fault. The software doesn't "change" something inside a template. Instead, it "removes" the old template and "inserts" a complete new version of the template. When it inserts a template, it follows the directions given in the template's /doc page about how to format it.

It is a bit annoying (especially if the infobox formatting rules get changed), and unfortunately I don't have any reason to hope that it will stop doing this during the foreseeable future.

Alsee (talkcontribs)

Oh hi, I didn't see your post until after I posted. Regarding: I don't have any reason to hope that it will stop doing this during the foreseeable future.

You are a liaison, right? Perhaps you you tell them that not-fixing this bug is a disruptive time-sink on the community, and that Foundation-staff time is just going to get wasted dealing with an endless stream of independent duplicate bug reports?

Alsee (talkcontribs)

I believe this issue is Phabricator T179259. They did this deliberately. Somehow they think it's a good idea. They made changes to Visual Editor such that it edit wars the format of existing template parameters.

  • Complaints have continue to come in in various places for the last two and a half years, and will continue to come in endlessly until this is fixed
  • for every report that comes in there surely thousands more editors repeatedly disrupted by it
  • editors are blaming and stressing each other over these edits
  • it is disrupting our edit filters

This bug is clearly wasting an excessive amount of community time, orders of magnitude more time than it would take to fix, but staff don't want to bother fixing it.

I invite/suggest you post in Phabricator T179259. Perhaps eventually they will realize that explaining they don't want to fix it consumes more of their time than simply fixing it.

P.S. I count a crazy 74 lines changed in this diff, which should have been a 1 line change. More than one and a half times the 48 you reported.

Mathglot (talkcontribs)

Alsee, thanks for the updated count; that is indeed crazy.

Whatamidoing, we all run into software glitches from time to time. When we do, we report the problem, look for a workaround that will work in the meantime, and execute it, perhaps at the cost of some increased time and/or effort. That is normal and acceptable; nobody expects software to be perfect. But what is the workaround here, for a VE user who isn't familiar with wikitext? I don't see one.

It seems to me that one aspect of this bug (or is it by design?) is that it drafts wikitext editors into involuntary servitude as housekeepers to sweep up after the actions of good-faith VE editors trying to improve the article, who are thwarted by the actions of a tool through no fault of their own, and who are prevented from carrying out a workaround by the tool. To me, this is the greater problem.

I'd rather be working on improving the encyclopedia in some interest area of mine, and no doubt User:Haywalk would, as well; but instead, we're both trying to deal with this now. As Alsee pointed out, it's a drain on numerous editors. #VEwhitespaceMunge Thanks, Mathglot (talk) 19:57, 16 May 2020 (UTC)

ESanders (WMF) (talkcontribs)

The example here shows a template that has been incorrectly configured in the TemplateData to use a fixed number of spaces. TemplateData allows users to keep values and parameters aligned in block templates, it just needs to be configured correctly, see Help:TemplateData#Custom formats.

The TemplateData in question that needs to be fixed: Template:Infobox_country/doc#TemplateData

Alsee (talkcontribs)

@ESanders (WMF) your answer has been suggested previously. It is not effective in resolving the issue. There is no value we can place in TemplateData to fix the general problem.

Desired behavior:

  • Put simply: If the VE-user didn't change something, VE shouldn't change it either. A typo fix or other trivial change should result in a 1 line diff, not a 78 line diff.
  • Attempting to be formal and precise: VE should apply TemplateData when a template is originally inserted. It should apply TemplateData formatting to an individual field when the user introduces a new field. When the user blanks a field, VE should use TemplateData to decide whether to delete that field or retain it as present&blank. Modified and unmodified existing fields should not be reformatted - it is both unnecessary and a problem.

Why this matters:

  1. Needlessly massive diffs are burdensome on the editing community. Individual occurrences may "merely" be a nuisance, but in the aggregate they outweigh the cost of fixing it by orders of magnitude.
  2. Massive diffs with little or no apparent purpose are often reverted. We lose potentially useful content, and reverts are a known primary reason new users quit and never return.
  3. Editors who are unaware that VE is responsible may blame the VE-user for the disruption. This may cause talk page arguments which is a cost in itself, with the potentially permanent result that the VE user may leave and never return.
  4. Editors may attempt to reverse the unwanted changes. VE then engages in unrelenting edit warring any time someone comes along and innocently tries to use VE on that template.
  5. It's a thorn that keeps jabbing us. The above issues often have an undesirable side effect of generating ill-will against VE and/or against the Foundation. You really do want to fix this, if only for this reason.
Mathglot (talkcontribs)

ESanders, I have to agree with what Alsee says. I try mightily to avoid the blaming in #3, and tried to go out of my way to point out to User:Haywalk that it wasn't their fault. Still, it's a natural, human reaction (#5) to resent the interruption, and the mopping-up effort required, not to mention the back-and-forth required just to deal with it, for example, at this Wikipedia talk page discussion recently irks. Mathglot (talk) 20:20, 21 May 2020 (UTC)

Mathglot (talkcontribs)

I would also add another bullet to Alsee's "Why this matters", namely:

        6. Wikipedia editors are responsible for all their edits.

Even when using a bot, whether user-assisted or operating entirely autonomously, this is so:

  • WP:BOTACC: The contributions of a bot account remain the responsibility of its operator... . In particular, the bot operator is responsible for the repair of any damage caused by a bot which operates incorrectly.
  • WP:BOTCONFIG: Bot operators... should bear in mind that they retain all responsibility for their bot account's edits.
  • WP:AWB (top): Warning: You take full responsibility for any action you perform using AutoWikiBrowser.
  • WP:AWBRULES: You are responsible for every edit made. (emphasis in original).

Is the standard for VE to be lower, than for using AWB or a bot? Is a VE user responsible for every edit, or not? Mathglot (talk) 20:43, 21 May 2020 (UTC)

Mathglot (talkcontribs)

I'm seeing something related, where VE is now prettifying infoboxes. Not sure if this is a result of a fix to a previous situation described above, or completely new, but in this edit to w:Italian Libya, a user made a simple, one-line change to a value of an Infobox, and as a result, all the equal signs, formerly unjustified, now all nicely line up, with almost every line in the Infobox altered, to ensure their vertical alignment. While some might see this as desirable (that is, the alignment), I don't believe that an editing program doing things "under the hood" that the user did not specify is desirable. For example: terminating a wikilink by using end-brackets where they are required, is highly desirable; and yet, neither the wikicode editor, nor VE (to my knowledge) performs this function. Neither should VE provide spaces to enforce alignment (desirable as it may be) if the editor did not specifically make that change. If this is a TemplateData issue, and not a VE issue, then the change should be made there. Adding previous discussants @Whatamidoing (WMF), Alsee, ESanders (WMF): (if you are watching and don't wish to be re-pinged; please lmk.) Thanks, Mathglot (talk) 22:36, 15 June 2020 (UTC)

ESanders (WMF) (talkcontribs)

This is for the community to decide. If you remove the "display" parameter completely from the template then no whitespace style will be enforced. It seems to me that the community is getting value from this feature due to its widespread usage. If you think the parameter should not be used at all, or used less, then that is a decision the community can make for themselves.

Pppery (talkcontribs)

This was a consequence of w:Special:Diff/958036265, which changed the style VE normalizes to to be "nicely lined-up columns" without addressing the actual problem.

Mathglot (talkcontribs)

Oh dammit, here's another one of these; my watchlist is showing me a +479 byte change to w:Michel Temer, so I ran the Diff, and I can't see what they changed, due to the fact that every line in the Infobox is prettified. This doesn't represent what the user intended, as a reviewing editor, I cannot find what they changed without way more effort than should be needed; it's just a big cock-up. I suspect the user made one tiny change in one line, but this is just ridiculous.

Whatamidoing (WMF) (talkcontribs)

It changed | vicepresident = [[Hamilton Mourão]] to | vicepresident = ''None''

This is highlighted. What diff system are you using?


Mathglot (talkcontribs)

Pppery, can you please redo your diff? That seems to point to something irrelevant.

Mathglot (talkcontribs)

Thanks!

Pppery (talkcontribs)

Sorry, off-by-one-error in extracting the correct revision ID from a URL.

Mathglot (talkcontribs)

Back to what it was, per ESanders comment above at 16 June 2020 08:34 AM.

Reply to "Does VE munge white space?"