Topic on Help talk:Paragraph-based Edit Conflict Interface

The new Edit Conflict software appears to mishandle page info passed to template logic

2
Summary by Alsee

Patched, reviewed, and merged in just a few hours. Nice work @Thiemo Kreuz (WMDE). Thanx. The fix will presumably be deployed soon.

Alsee (talkcontribs)
  • I encountered an edit conflict at English Wikipedia:Village_pump_(policy), with the beta edit conflict software enabled.
  • The page included several copies of the the Talk Quote template, {{tq}}. This template includes logic to verify the namespace of the current page. This template generates a red error message when it detects that it is being used on an inappropriate page. The template normally detects and accepts Village Pump as an appropriate page.
  • The {{tq}} template failed to render correctly in the new edit conflict preview. The template generated warning messages that it was being used on an inappropriate page.
  • I saved the edit. The template and everything else rendered correctly on the saved page.

I believe the most likely explanation is that the edit conflict software passed incorrect information about the page to the template logic. I only encountered this issue once, I was in the middle of clicking save when I spotted the problem, and I have not attempted any testing. My interpretation and explanation of the issue seem obvious and simple, but it is merely a hasty hypothesis.

Thiemo Kreuz (WMDE) (talkcontribs)

That is indeed exactly what happens. Thanks a lot for the wonderful report (especially for clearly marking hypothesis as such) and for creating that Phabricator ticket. This will be fixed.