Topic on Talk:Continuous integration/Codehealth Pipeline

There must have been some configuration change to the SonarCube configuration between 2019-12-18 and 2019-12-20 that causes our javascript code coverage collection to fail:

Patch Set 2 at 2019-12-18: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/558150#message-0d1eb9d153d132b84a5888510886209927bf23f5

Patch Set 3 at 2019-12-20: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/558150#message-aa2cef394e340d66bfc2dcd0a5a809cef82e4ce1

Also note how the estimated total drops from 3.7% to 0.0% :/

Any idea what is going on? @KHarlan (WMF)

Timeline fits with 19e934d1b3a9e5677fa75a7a9e1b426adb5a47c5 / f1c8efea9604e66881c9f0800a745aec63726efe.

I'm not sure how those changes would have impacted this.

JavaScript coverage is supposed to generated by `npm run-script test:unit`, which Wikibase's package.json doesn't have, so I'm not sure how coverage was gathered before.

Oh, this is embarrassing. It seems we (WMDE) broke this ourselves in 91ba57 ? I really should have thought of checking this first :/

Thank you for pointing me to npm run-script test:unit!

I'm very sorry for all the noise 🙈

PS: I noticed that the code health pipeline is also run for WIP builds, but the result is not added as a comment in Gerrit. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/562833 and https://integration.wikimedia.org/ci/job/mwext-codehealth-patch/10147/

Is that intentional?

No worries!

There are some quirks with how the bot posts to gerrit reviews (sometimes we get a 403 -- maybe that's related to the WIP status?), I will file an issue and look into it more.