Topic on Talk:Edit Review Improvements/New filters for edit review

New wikitext in edit mode

13
Summary by Trizek (WMF)
Spinningspark (talkcontribs)

Turning on "New filters for edit review" in Beta has also turned on "New wikitext mode" without me selecting it in preferences. Is this deliberate? If so, it is mistaken to do that, if not, it is a bug. I'm using the monobooks skin.

George Ho (talkcontribs)

Is the "Automatically enable all new beta features" option checkmarked? If so, that could be the cause of enabling the "New wikitext mode". See whether de-checkmarking the option and "New wikitext mode" works.

Trizek (WMF) (talkcontribs)

@George Ho has raised the most probable case. Can you confirm if that's the origin of your problem, @Spinningspark? Thanks!

Spinningspark (talkcontribs)

Of course that's not the problem. If I had all beta features automatically enabled it would have been on ''before'' I turned on the new filters. But today it seems to be on permanently and I can't turn it off at all.

George Ho (talkcontribs)

I tried to reproduce the issue at English Wikipedia but found none. I tested out the feature in various skins in older wikitext editors, including the one without the toolbar. The wikitext editor is not affected.

I even used IE11, Chrome, and Firefox to find the problem but found no issues that you asserted. Maybe it's your browser's cache? Have you enabled a gadget that can clear out, i.e. "Purge", your cache? More can be read at Help:Locating broken scripts.

Spinningspark (talkcontribs)

Ok, purging the cache doesn't help. Turning on safemode doesn't help. Switching browsers (Firefox, Chrome) doesn't help. Below is the output of the console. There appears to be an error with $button.toggleClass(...).data(...) but I've no idea where that is coming from. It's not directly in my js page but may possibly be imported from other js.

Use of "mw.toolbar" is deprecated.

load.php:154:52

Use of "mw.toolbar" is deprecated.

load.php:154:52

JQMIGRATE: jQuery.fn.bind() is deprecated

load.php:140:200

jQuery.Deferred exception: $button.toggleClass(...).data(...) is not a function updateToolbarButton@https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=ext.3d%2CCodeMirror%2Ccharinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.CodeMirror.data%2Clib%7Cext.CodeMirror.mode.mediawiki%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.echo.api%2Cinit%7Cext.eventLogging.subscriber%7Cext.math.editbutton.enabler%7Cext.uls.common%2Ceventlogger%2Cinit%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.visualEditor.desktopArticleTarget.init%7Cext.visualEditor.supportCheck%2CtargetLoader%2CtempWikitextEditorWidget%2Ctrack%2Cve%7Cext.wikimediaEvents.loggedin%7Cjquery.accessKeyLabel%2CcheckboxShiftClick%2Cclient%2Ccookie%2CgetAttrs%2ChighlightText%2ClengthLimit%2CmakeCollapsible%2Cspinner%2Csuggestions%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CRegExp%2CString%2CTitle%2CUri%2Capi%2Ccldr%2Ccookie%2Cexperiments%2Cicon%2CjqueryMsg%2Clanguage%2Cnotify%2CsearchSuggest%2Cstorage%2Ctemplate%2Ctoolbar%2Cuser%2Cutil%7Cmediawiki.ForeignApi.core%7Cmediawiki.action.edit%7Cmediawiki.action.edit.collapsibleFooter%7Cmediawiki.api.options%7Cmediawiki.language.data%2Cinit%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.regexp%7Cmediawiki.widgets.visibleLengthLimit%7Coojs%2Coojs-ui-core%2Coojs-ui-widgets%7Coojs-ui-widgets.styles%7Coojs-ui.styles.icons-editing-advanced%2Cicons-editing-styling%2Cicons-moderation%2Cicons-movement%7Cschema.UniversalLanguageSelector%7Cskins.monobook.mobile%7Cskins.monobook.mobile.echohack%2Culs%7Cuser.defaults%7Cwikibase.client.action.edit.collapsibleFooter&skin=monobook&version=0rq8z53:6:700

addToolbarButton/</<@https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=ext.3d%2CCodeMirror%2Ccharinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.CodeMirror.data%2Clib%7Cext.CodeMirror.mode.mediawiki%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.echo.api%2Cinit%7Cext.eventLogging.subscriber%7Cext.math.editbutton.enabler%7Cext.uls.common%2Ceventlogger%2Cinit%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.visualEditor.desktopArticleTarget.init%7Cext.visualEditor.supportCheck%2CtargetLoader%2CtempWikitextEditorWidget%2Ctrack%2Cve%7Cext.wikimediaEvents.loggedin%7Cjquery.accessKeyLabel%2CcheckboxShiftClick%2Cclient%2Ccookie%2CgetAttrs%2ChighlightText%2ClengthLimit%2CmakeCollapsible%2Cspinner%2Csuggestions%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CRegExp%2CString%2CTitle%2CUri%2Capi%2Ccldr%2Ccookie%2Cexperiments%2Cicon%2CjqueryMsg%2Clanguage%2Cnotify%2CsearchSuggest%2Cstorage%2Ctemplate%2Ctoolbar%2Cuser%2Cutil%7Cmediawiki.ForeignApi.core%7Cmediawiki.action.edit%7Cmediawiki.action.edit.collapsibleFooter%7Cmediawiki.api.options%7Cmediawiki.language.data%2Cinit%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%2Cstartup%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.regexp%7Cmediawiki.widgets.visibleLengthLimit%7Coojs%2Coojs-ui-core%2Coojs-ui-widgets%7Coojs-ui-widgets.styles%7Coojs-ui.styles.icons-editing-advanced%2Cicons-editing-styling%2Cicons-moderation%2Cicons-movement%7Cschema.UniversalLanguageSelector%7Cskins.monobook.mobile%7Cskins.monobook.mobile.echohack%2Culs%7Cuser.defaults%7Cwikibase.client.action.edit.collapsibleFooter&skin=monobook&version=0rq8z53:8:489

mightThrow@https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=monobook&version=18kdz1s:49:590

resolve/</process<@https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=monobook&version=18kdz1s:50:269

undefined

load.php:52:398

TypeError: $button.toggleClass(...).data(...) is not a function[Learn More]

Trizek (WMF) (talkcontribs)

Can you please do the following and tell us what happens?

  1. Go to beta preferences, remove both beta features.
  2. Make absolutely sure that the checkbox is not checked; make sure it didn't accidentally (or through a bug) got checked on its own
  3. Save preferences, and then go on to Wikipedia and clear cache
  4. Go back into preferences, and select "New Filters for Edit Review"
  5. Save, check to see if the problem re occurs.

Thanks.

Spinningspark (talkcontribs)

Hi Trizek, I'm pretty sure I've tried all of that already, but just to make sure, I've gone through it again following your instructions exactly. Note that "New wikitext mode" is on permanently regardless of whether I have "New filters for edit review" turned on. I've also tried completely removing all personal js. Still got the wikitext mode stuck on.

George Ho (talkcontribs)

On Windows 7, which I'm using, enabling the feature for my Watchlist while in beta doesn't change my wikitext mode. I turned on and off the new wikitext editor. The old editor still remains unaffected in my account.

I don't know which OS you are using. If Windows, maybe you want to check your "Task Manager" (via Ctrl+Alt+Del) to see your CPU and RAM performances. If that's not the case, how about checkmarking the "Temporarily disable the visual editor while it is in beta" option in the "Editing" tab? Maybe either clearing out your browser's cache or resetting your Preferences to Default would solve the issues, but I'm uncertain whether either is worth the risk because either you would lose your browser data or you have to reconfigure the Preferences settings.

Spinningspark (talkcontribs)

I'm using Windows 10. I don't know what you wanted me to look for in task manager but nothing stands out as problematic. Temporarily disabling visual editor in beta does nothing and I am not using VisEd in any case. I've cleared my browser cache without effect. That was not likely to be the problem anyway since I still have the problem if I switch to Chrome. I'm reluctant to reset my preferences, that's likely to cause me all sorts of grief.

Spinningspark (talkcontribs)

This is definitely account related. Only seeing the enhanced wikitext in editing mode in my main account. Not while logged out or logged in to an alt account.

Spinningspark (talkcontribs)

Ok, I fixed the problem by taking the plunge and resetting my preferences. That was a bit of a pain because I had to save a copy of all the settings and remake them, but the only annoying things that have happened is my watchlist token has been reset and my saved watchlist filters have been lost.

The problem was not actually caused by any setting in preferences. It was that I had inadvertently turned on (or it got turned on through a bug) syntax highlighting in the (old style) edit window toolbar. I did not even realise that this button had been added to the toolbar. I wish people would leave the old skins alone. There is a reason people use them; they don't want to change to something new.

Trizek (WMF) (talkcontribs)

Glad you've managed to fix that @Spinningspark. We have looked for reasons from what you gave us but found nothing. While you're the only one reporting this, we think that was on your side. If you experience any new disturbance, please tell us!