Topic on 2017 wikitext editor/Feedback

Tracked in Phabricator
Task T184786

Steps to reproduce

1. Try to source edit the template protected page,en:Template:Static_IP, without the "template editors" right. This should display the "This page is currently protected ... message which should also contain the "Submit an edit request" button.
2. Tap on the "Submit an edit request" button.

Expected results

The editor loads for creating a new section with the pre-filled topic "Template-protected edit request on DD MONTH YYYY" and some content in edit box.

Actual results

The editor fails to load showing the "The editor will now load. ... message. The browser's console shows the error "TypeError: Argument 1 of Window.getComputedStyle is not an object." for the mangled code line var l = window.getComputedStyle(t).

Further, if the page is re-loaded using the link found in the message displayed in the page, a different page is loaded which appears to be in an inconsistent state as the UI contains parts of both the 2017 wikitext editor and the OWE.

I believe that the seemingly "inconsistent state" of the icons is the result of https://phabricator.wikimedia.org/T191031, which changed the 2010 WikiEditor's toolbar yesterday.

I'm not pretty sure how this issue is related to the one in task T184786. IIUC, this issue is about editing the talk page corresponding to a template protected page, with pre-loaded content and the issue in task T184786 is about creating a protected page. Regardless, the errors I see in the browsers console for both the issues are the same.

I didn't refer to the icons in the edit toolbar when I said "inconsistent state" (They don't appear to be using OOUI, at least not yet). See this screenshot.

I noted another surprising thing just recently. When I turn off the "Wikitext syntax highlighting" beta feature, a partial inconsistent state is seen. To add to the surprise, the text in the OWE editor window is syntax highlighted despite the fact that I turned off the beta feature.

Note: I corrected the link for "source edit" in the topic description.

(Removed note that belongs in some other thread)

I don't think that's a relevant reply for this discussion. Anyways, the editor seems to behaving gracefully now. It loads completely instead of halting in an inconsistent state. It shows a Javascript error anyhow.