Topic on 2017 wikitext editor/Feedback

appears to break {{meetupsig}} @ enwiki

13
Summary by Elitre (WMF)
Jeremyb (talkcontribs)
Elitre (WMF) (talkcontribs)

(You don't need to sign with tildes in Flow posts.) What do you mean by "break"? (I was able to add the button here. The editnotice that appears after I click on the button is barely readable and likely not helpful, but I don't know that that's what you mean.)

Jeremyb-phone (talkcontribs)

(yeah, don't use flow much)

I saw the editnotice issue also. this is not about adding the button, this is about how the button works once it's already on a page.

with this feature disabled click the button and then immediately click save and you're done.

when enabled click button and then save is greyed out and nothing is prefilled (wikitext textarea is empty)

Elitre (WMF) (talkcontribs)
Jeremyb-phone (talkcontribs)

sounds about right

Alsee (talkcontribs)

The template is specifically designed to give maximum ease and maximum assistance to people who have never edited before.

Expected behavior:

  1. Click the blue SIGN UP button
    • Edit screen appears with * ~~~~ automatically inserted, with extremely effective and stable edit notice telling them to click SAVE.
  2. Click SAVE

Actual behavior:

  1. Click the blue SIGN UP button
  2. Edit screen appears, but signature code is not inserted
  3. Editnotice is mangled, and vanishes if you do anything
  4. Save button is disabled (because the NewEditor doesn't let you save or preview a nulledit)
Elitre (WMF) (talkcontribs)

I appreciate the longer explanation: it looks like the task linked above (already patch for review) may be behind this (if I'm mistaken, we'll flag this separately).

Alsee (talkcontribs)

It looks like the Phab T51622 addresses support for preloading text into the edit window. That's the more important thing in this particular case.

As for the edit notice issue, there are other cases where providing the editnotice in pop-up form more directly breaks functionality. On some dedicated-workflow pages we fill the page notice with a toolbar of clickable links that insert helpful text into the edit window. For example try this edit link for EnWiki's AN/RFC page and click SHOW on page notice's green box. Clicking any link in the green box inserts the item into the page. That doesn't work with the popup editnotice.

Elitre (WMF) (talkcontribs)
Alsee (talkcontribs)

Ah, yes. That's the Phab for it. I forgot where it was.

Elitre (WMF) (talkcontribs)

Understandable! There are so many of them :D So the first one is solved, landing on the wikis later this week, and I asked whether that being fixed changes anything for the second one.

Jim.henderson (talkcontribs)

Today I clicked the blue button and it showed my four tildes but Save was greyed out until I added and deleted some letters. So, it's still broken. ~~~~

Elitre (WMF) (talkcontribs)

Ah-ha! Thanks for reporting.