Topic on Talk:Edit Review Improvements/New filters for edit review

Saving filters, saved filters^2, and filter by my watchlit

4
Nabla (talkcontribs)
  • We should be able to update saved filters.

Currently we can only edit and save again as a new filter - thus having to type or copy&paste the whole name again, which leads to...

  • Saved Filter names should be unique

When trying to save under the same name it should either be updated or not allowed - better yet, ask? Currently we end up with multiple filters with the same name.

  • Saved Filter excluding namespace(s) does not save the 'not'

Create a filter excluding, e.g., the wikipedia namespace. Save it. Use the saved filter. The saved filter *includes* the wikipedia namespace.

  • All{{fact}} filters using "my watchlist" are slooooowwwwww

Slow means some 15 minutes to load, or more, I open the page and look at it later, I do not stare at the screen for 15 minutes :-) My watchlist has some 400 pages

If these are reported somewhere I do not know where to look for... point me there please. If these are best split one by message, please do or tell me to.

JMatazzoni (WMF) (talkcontribs)

Hi @Nabla. Thanks for your feedback. I'll take your issues in order:

Saved filters naming: I'm glad you're using Saved Filters! The issues you raise are completely valid. But I'd call your requests feature enhancements, and in all honesty I'm not sure we're going to address them any time soon–though I completely grant that the shortcomings you cite make it harder to achieve filter sets that are just right.

Namespace excludes not saving. Thanks for reporting this bug. We're on it, and a patch to the code has been filed. The fix should roll out in the next week or two. See ticket  T172635

Slow Watchlist filters. I'm not seeing this but I'll forward it to QA for further investigation. It would be helpful if you could say more about the exact protocol you follow, the combination of filters etc., that cause this slowdown. And how big is your Watchlist?

Thanks again!

Andrei Stroe (talkcontribs)

About that slow watchlist filters issue: this may not be related to the edit review filters. We've been experiencing issues with the loading of the Watchlist page itself (slowness, but especially MySQL errors) at ro.wp, discussion here. And, yes, the watchlist filters are very slow. I would open a phabricator ticket, but I'm not sure in which project I should do that and I don't know if I'm not duplicating an issue. Could you help me with that @JMatazzoni (WMF)?

Andrei Stroe (talkcontribs)

Never mind that, in the meantime I was made aware of phab:T171898 that tracks this exact issue. I was right, it was already reported.

Reply to "Saving filters, saved filters^2, and filter by my watchlit"