Topic on Project:Support desk

Is this Hunk #1 important? Should I reinstall MW or just ignore the error and patch it?

# patch -p1 --dry-run < mediawiki-1.26.4.patch

patching file RELEASE-NOTES-1.26

Hunk #1 FAILED at 1.

Hunk #2 succeeded at 14 (offset -19 lines).

1 out of 2 hunks FAILED -- saving rejects to file RELEASE-NOTES-1.26.rej

patching file includes/Block.php

patching file includes/DefaultSettings.php

Hunk #1 FAILED at 75.

1 out of 2 hunks FAILED -- saving rejects to file includes/DefaultSettings.php.rej

patching file includes/GlobalFunctions.php

patching file includes/Html.php

patching file includes/HttpFunctions.php

patching file includes/OutputPage.php

patching file includes/Title.php

patching file includes/User.php

patching file includes/api/ApiParse.php

patching file includes/diff/DairikiDiff.php

patching file includes/filerepo/file/LocalFile.php

patching file includes/parser/Parser.php

patching file tests/parser/parserTest.inc

patching file tests/parser/parserTests.txt

patching file tests/phpunit/includes/HtmlTest.php

patching file tests/phpunit/includes/LinkerTest.php

patching file tests/phpunit/includes/OutputPageTest.php

patching file tests/phpunit/includes/XmlSelectTest.php

patching file tests/phpunit/includes/XmlTest.php

patching file tests/phpunit/includes/content/JsonContentTest.php

patching file tests/phpunit/includes/parser/NewParserTest.php

The release process sadly is flawed. The 1.26.4 release for example first contained PHP 5.5 code, which broke installations. And this code wasn't even in Git. They have Git, but they don't use it to package the stuff. And this wasn't the first time that the tarballs were broken. It's a pitty.

The hunk in the Release Notes file is not important, it is only some text. But an incorrect change in DefaultSettings.php is a problem. Better use the tarball with the complete code and extract the files from there.

Additionally, you might want to open a BUGREPORT about this problem to get the patch file fixed.

Oh, well Thank you!