Topic on Project:Support desk

Splash skin isn't loading after upgrading to MW-1.26

9
Summary by Ciencia Al Poder

This fix needs to be merged on REL1_26 branch https://gerrit.wikimedia.org/r/#/c/255945/

in the meantime, using latest master should probably work

1.39.49.57 (talkcontribs)

The skin was working fine in v1.25.2 but now after upgrading my wiki to 1.26 and configuring splash as default skin as before, it just shows plain texts without any styling at all as if there is no skin.

88.130.97.228 (talkcontribs)

Two steps:

First, at the bottom of your LocalSettings.php file, please add the line

$wgResourceLoaderDebug = true;

Then, second step, please have a look inside the source code of an affected page.

In the head of this page, you will have a number of links pointing to load.php. Please visit each of these links!

In all of these links you should see some CSS styles. In your case, you will most likely not have CSS styles, but you will see a PHP error in at least one of these links.

What is the error message?

1.39.101.40 (talkcontribs)

Hey, Thanks for replying.

So, I added the code in my localsettings.php and refreshed the main page but it's still the same with no errors showing up anywhere on the page or on any other pages on my wiki. There are no links in the head either.

Also, every page on the wiki is showing up like this, so it is not just one page issue. The css used "inside" the wiki page is however working fine. The issue is that the navigation links, footer links, site's name, create account/login links, etc are not showing as configured in the skin's CSS. They are like:

●Create an account

●log in

Navigation

●Main page

●recent changes

●Random page

Tools

●What links here

●Related Changes

●Special pages

■Main Page

■Discussion

■Edit

■History

Ciencia Al Poder (talkcontribs)

I've installed it on 1.26 and indeed it fails to load styles. With $wgShowExceptionDetails, loading load.php with &modules=skins.splash&only=styles&skin=splash gives me:

exception 'Less_Exception_Chunk' with message 'ParseError: Unexpected input in screen.less on line 396, column 3
394| 		border: none;
395| 		height: 1px;
396| 		padding: 0;
397| 		margin: .5em 0;
398| 		display: list-item !ie;
399| 		list-style: url('images/hr.png') inside !ie;' in /home/www/lib/mediawiki-1.26.0/vendor/oyejorge/less.php/lib/Less/Parser.php:543

I'm not sure what's up with that line, as removing it gives the same error on the avobe line, etc

Removing from that line until the end of the ruleset "}" stopts the error, though.

I suspect there's a bug in the less parser of MediaWiki

Ciencia Al Poder (talkcontribs)
This post was hidden by Jörgi123 (history)
This post was hidden by Jörgi123 (history)
88.130.70.240 (talkcontribs)

The new less parser of 1.26 chokes on some expressions, which still worked in 1.25. One of these expressions is "!ie". The expression "!ie" can no longer be used - remove it!

If you need styles, which are only used by Internet Explorer, you can instead use the underscore hack, e.g.

_display: list-item;
_list-style: url('images/hr.png') inside;

The according CSS in the Splash skin should be fixed!

Matiia (talkcontribs)

This message was written by 1.39.50.46, but the filter didn't allow to post it.


Well, the problem got solved by removing "!ie" from lines

398|  display: list-item !ie;

&

400|   filter: alpha(opacity=0) !ie;

as pointed out by Ciencia Al Poder in the error he posted above

It looks like it has problem only with the "!ie" in those line. I wonder why the less parser would choke on the expression only in those lines?

Anyway, the problem is solved. 

Thank you '88.130.70.240' and Ciencia Al Poder for helping. You guys are awesome! :)