Talk:Parsoid/2015b

View developer tasks

Report a new bug in Phabricator

Join the IRC channel

Previous discussion was archived at Talk:Parsoid/Archive on 24 June 2015.

Archive

The previous discussion was archived at Talk:Parsoid/Archive on 2015-06-24. Arlolra (talk) 18:28, 24 June 2015 (UTC)

Installation of Parsoid/Visualeditor on CentOS 7, RHEL 7, Fedora 22, or Scientific Linux 7

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

See: https://www.centos.org/forums/viewtopic.php?f=47&t=53223&p=225372#p225372

All the problems with SELinux are solved! 185.46.214.55 (talk) 12:49, 6 July 2015 (UTC)

Glad to hear it :) Arlolra (talk) 21:38, 29 July 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Failed API request

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

This is an update for the following archived thread : Talk:Parsoid/Archive#Failed_API_request

If I directly call a Parsoid page (" curl http://localhost:8000/localhost/myPageName?oldid=883 " for instance) it works as expected. The parsoid.log indicates that parsing was done in half a second.

But using the VisualEditor (when I click "Modify" in the Wiki) parsoid starts parsing and ends with a timeout as explained in the archived topic...

I tried to activate parsoid debug and I can see some JSON output before "completed parsing in 100439 ms" (at the timeout). This output and the debug output when calling parsoid directly seem to be identical (some identifiers are different, but the content is the same)

Should I look on the VE side instead ? 37.1.253.18 (talk) 11:58, 20 July 2015 (UTC)

I think what's happening is that your MediaWiki instance doesn't support any concurrency. So, the initial VE request ties up the process, it calls Parsoid, which call back to the MediaWiki API, and that just hangs. Are you using a webserver like Apache to run MediaWiki? php's build-in webserver is single threaded, last I checked. Arlolra (talk) 21:34, 29 July 2015 (UTC)

Yes I'm running Apache. And it worked on mediawiki 1.23.

I'll check if something on the Apache side could make it single-threaded... 37.1.253.18 (talk) 09:41, 4 August 2015 (UTC)

Apache side seems ok.

New info : If I use curl by replacing "localhost" with the local network IP, it doesn't work anymore:

curl: (7) couldn't connect to host

Could this be the cause of the trouble ?

Note that in parsoids' localsettings.js, the Interwiki address uses localhost (and not the local network IP). 37.1.253.18 (talk) 12:46, 4 August 2015 (UTC)

You said (in the archive) the request VE is making is to the above url, right? And then you tested that directly with curl and it worked. It seems like Parsoid is configured correctly.

How did you verify that Apache is ok? What's your MediaWiki API url? I would try opening a hanging connection to the MediaWiki API (using telnet, or nc, or some such) and then curl'ing it to confirm that multiple request are handled alright. Arlolra (talk) 22:21, 4 August 2015 (UTC)

Yes Parsoid seems to work correctly.

And for Apache, I called a php script that sleeps for 10 seconds (from another IP in the network), and launched curl during these 10 seconds. It worked. 37.1.253.18 (talk) 08:32, 11 August 2015 (UTC)

same here? Anything new? http 0. 2A03:2260:118:0:E8C2:8BFF:FE44:E1CF (talk) 21:51, 14 September 2015 (UTC)

We recently updated the recommended configuration instructions for both Visual Editor and Parsoid. This should make misconfigurations less likely. You might want to try going through the new configuration steps carefully, ideally with the latest Parsoid package and latest MediaWiki and Visual Editor, ensuring that any "prefix" and "domain" you specify is consistent between the mediawiki and parsoid configuration files. cscott (talk) 13:14, 24 September 2015 (UTC)

I wonder if setting $wgMessageCacheType = CACHE_NONE; in your LocalSettings.php will help. Arlolra (talk) 06:16, 14 November 2015 (UTC)

I could not work on this during several months, but I thank you for your help.

In the meantime, while installing another extension, I had problems with URL prefixes because I use :

$wgServer = "//my.domain.com";

$wgCanonicalServer = "https://my.domain.com";

Which should allowed.

Could this be the cause ?

Anyway, I'll try to update to the latest version and reinstall parsoid and VisualEditor from Scratch.

And if I still have problems, I'll give a try to $wgMessageCacheType = CACHE_NONE; 37.1.253.18 (talk) 10:12, 26 January 2016 (UTC)

Yes, I believe that Parsoid correctly supports protocol-relative URLs. In this case it will try to make the connection using https, I believe, so you might want to double-check that your SSL certificates are valid as well. Let us know how it goes. cscott (talk) 17:22, 26 January 2016 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Parsoid utilizing Nodejs memory specs?

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

After having parsoid installed, with nodejs in ubuntu. I noticed there is 5 nodejs task running, and they are under www-data (user).

Each nodejs consumes about 1013032,1010980,878792,693656,688044KiB.

Is that normal for nodejs to consume to much memory? AmazingTrans (talk) 22:35, 24 July 2015 (UTC)

You can limit the number of processes with a flag, `node api/server.js -n 2`. That'll spawn 3, the master and 2 workers.

Those numbers look a order of magnitude off. I would expect something like 68-101MB, at least that's what we see in practice. Arlolra (talk) 21:59, 29 July 2015 (UTC)

Arioira, i'm using this alone with visual editor.

1. Is the standard in the server.js file set to 5 process?
2. What side effects do i get if I limit it to have 3 instead of 5?
3. Sorry, i was seeing the VIRT parameter instead of the RES parameter. Under RES: it is actually 117268, 115184, 94348, 69464, 63176.

Thanks 206.51.148.2 (talk) 12:35, 30 July 2015 (UTC)

1) No, default is to look at the number of cpus it thinks are available, and add three to that. Meaning that you have 2.

2) The idea of spinning up more processes is to serve more requests concurrently. But there are a number of factors at play. I think you'll be fine limiting it to three, or less even.

3) Ah, right, that's what's expected then. Arlolra (talk) 17:15, 30 July 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Windows instructions gone

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

With https://www.mediawiki.org/w/index.php?title=Parsoid/Setup&oldid=1655043 this edit the windows instructions were banished .... cleanup sure, but remove? Can they come back? Robert.Labrie (talk) 13:17, 10 August 2015 (UTC)

The windows instructions were moved to Parsoid/Developer Setup, they haven't gone anywhere. The Developer Setup page describes how to install Parsoid from source; since we don't have a windows package (self-installer, or something like that), the install-from-source page seems like a more appropriate place for the Windows instructions. cscott (talk) 13:11, 24 September 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Fail to install Parsoid

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I failed to install Parsoid on my Ubuntu server with these errors:

sudo apt-key advanced --keyserver keys.gnupg.net --recv-keys 5C927F7C

yields

Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --homedir /tmp/tmp.hzJuISWZKb --no-auto-check-trustdb --trust-model always --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver keys.gnupg.net --recv-keys 5C927F7C
gpg: requesting key 5C927F7C from hkp server keys.gnupg.net
?: keys.gnupg.net: Network is unreachable
gpgkeys: HTTP fetch error 7: couldn't connect: Network is unreachable
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0

sudo apt-get update after adding the deb config

yields

W: Failed to fetch http://parsoid.wmflabs.org:8080/deb/dists/wmf-production/InRelease
W: Failed to fetch http://parsoid.wmflabs.org:8080/deb/dists/wmf-production/Release.gpg  Unable to connect to parsoid.wmflabs.org:8080:
W: Some index files failed to download. They have been ignored, or old ones used instead.

sudo apt-get install parsoid

yields

E: Unable to locate package parsoid

Now I'm stuck in getting VE rolling.

Could anyone help me? Maybe @Arlolra, please? Thanks! Netnetjoe (talk) 07:49, 12 August 2015 (UTC)

"couldn't connect: Network is unreachable"

"Unable to connect to parsoid.wmflabs.org:8080"

It sounds like you're having problems with your network. Arlolra (talk) 22:18, 15 August 2015 (UTC)

I also cannot connect. When entering "http://parsoid.wmflabs.org:8080/deb" in the browser I get a "welcome to nginx" message. 2.242.92.87 (talk) 19:54, 17 August 2015 (UTC)

Also cannot connect. 65.205.175.4 (talk) 15:44, 28 August 2015 (UTC)

I had a similar issue. Replacing keys.gnupg.net with pgp.mit.edu solved it for me. Planetenxin (talk) 12:44, 31 August 2015 (UTC)

FWIW, we recently released an updated version of the Parsoid package, which is hosted on releases.mediawiki.org instead of parsoid.wmflabs.org. I don't know if that fixed the keyserver problems... but it might have. cscott (talk) 13:07, 24 September 2015 (UTC)

I had a similar issue. To resolve it, I added

deb https://releases.wikimedia.org/debian jessie-mediawiki main

in the file (to be created if needed)

/etc/apt/sources.list.d/parsoid.list

Thanks @Seb35 for his help Nicolas NALLET Wiki-Valley.com (talk) 12:05, 15 December 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Parsoid for OL7 (Red Hat)

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

Exist Parsoid package for Oracle Linux Enterprise 7 (Red Hat)? 177.128.175.2 (talk) 02:47, 12 September 2015 (UTC)

No, sorry. Also please note that our .deb files are currently out-of-date. Jdforrester (WMF) (talk) 15:47, 14 September 2015 (UTC)

The developer setup instructions should work fine on Red Hat. cscott (talk) 21:54, 15 September 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Converting a Wiki or Wiki pages into HTML using Parsoid

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

Hi,

What's the best way to convert a private wiki or many pages from that wiki into exported HTML (files) using Parsoid? So far, the "http://localhost:8142/_wikitext/ form has produced the best results. Is there a way to do this from the Linux command line en masse? I have Visual Editor working as well and have tried using nodejs and curl too, but can't get the result I'm after. Thanks 220.233.42.239 (talk) 05:52, 17 September 2015 (UTC)

Kiwix includes tools to do exactly this, including rewriting the pages to include links to downloaded resources: http://sourceforge.net/p/kiwix/other/ci/master/tree/mwoffliner/

If you just want to dump html from the command line, Parsoid includes `tests/parse.js` which does this; see Parsoid#Converting simple wikitext cscott (talk) 17:22, 21 September 2015 (UTC)

mwoffliner looks promising. Thanks! 220.233.42.239 (talk) 23:56, 24 September 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

How to enable SSL for parsoid?

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

If I want to use SSL in parsoid,How to do? Zhangjintao(Connect to me at zh.wikipedia.org) 12:29, 24 September 2015 (UTC)

You can use https when you specify the mediawiki action API URL for your wiki in localsettings.js. That will ensure Parsoid uses https for its outbound connections.

But I'm guessing what you want is for parsoid to use SSL for *incoming* connections. The way I would recommend doing this is to configure Parsoid to bind to a localhost-only port, then set up a front-end SSL server (like apache, etc) which accepts the SSL connection and then proxies over to Parsoid on its local port.

Parsoid uses "express" for to set up its web service. There are a number of posts on the internet for configuring it to launch an SSL server: https://www.google.com/search?q=express+SSL We would gladly accept patches to Parsoid to allow users to launch an SSL service "natively". cscott (talk) 13:05, 24 September 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Using Parsoid to extract template parameters in a user script?

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

Every few months I extract information from lists of (TV) episodes on Wikipedia to synchronize them with other sources. In the past I have copied the raw wiki source to my editor and boiled it down with ad hoc regular expressions to SQL tupels. I have played with the idea to automate that in a Perl/Python/etc. script, but the other idea would of course be to have the functionality in a user JavaScript that on clicking some icon/link/etc. opens a text field with the SQL tupels (or JSON or …) ready to be copied & pasted.

Looking at http://rest.wikimedia.org/en.wikipedia.org/v1/page/html/List%20of%20Grand%20Designs%20episodes, Parsoid seems to already parse the templates (data-mw), and https://doc.wikimedia.org/Parsoid/master/#!/guide/jsapi seems to provide a way to parse that offline. But how do I parse it in user JavaScript? I searched around a bit on enwp, but most hits I got were hand-written wikitext parsers that were marked "TODO: Replace with Parsoid". Does someone have a working example how to extract template parameters in a user script for the current page?

For example, I want to extract from:

=== Series 2 (2001–2002) ===
{| style="width:98%;" class="wikitable plainrowheaders"
! style="background:#fcc25d;" width="10%" | No.
! style="background:#fcc25d;" width="50%" | Title
! style="background:#fcc25d;" width="20%" | Location
! style="background:#fcc25d;" width="20%" | Original air date
{{Episode list
 |EpisodeNumber = 1|Title = The Regency Villa|Aux1 = Farnham, Surrey|OriginalAirDate = 17 July 2001|ShortSummary = Kevin McCloud meets a woman determined to build the house of her dreams, an enormous Georgian-style mansion. Helen Saunders and her husband Mark Eisenstadt finally found the perfect plot of land in Farnham, and have spent years planning every aspect of their new home. Having undergone extensive preparation, they don't foresee too many problems, but once the build gets underway their dream soon turns into a nightmare.|LineColor = fcc25d}}
|}

the tuple (2, 1, 'The Regency Villa', 'Farnharm, Surrey). Tim Landscheidt (talk) 21:13, 3 October 2015 (UTC)

This is much easier if you can run a script locally; it is rather difficult to do from user JavaScript running in the browser. One (*extremely hacky*) way to do this might be to open VE on the page before you run your user script; you can access the Parsoid representation of the article at that point. But I'm not sure I'd actually *recommend* doing it this way. cscott (talk) 15:03, 6 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Install Parsoid for MediaWiki 1.25.2

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I've recently installed MediaWiki 1.25.2 successfully on CentOS 6.7.

But I did not find any exact and step by step instruction for installing Parsoid for MediaWiki 1.25.2.

Can anyone help me in this way?

Thanks in advance. Hadiov (talk) 17:57, 8 October 2015 (UTC)

See https://www.centos.org/forums/viewtopic.php?f=47&t=53223&p=225372#p225372 SSastry (WMF) (talk) 19:42, 9 October 2015 (UTC)

Thank you SSastry, but it is for CentOS7.

Some commands are not valid in CentOS6.7 such as:

chown -Rv root:root parsoid

chcon -Rv --type=system_u:object_r:usr_t:s0 parsoid

firewall-cmd --permanent --zone=public --add-port=8000/tcp

Thanks again and I will be very grateful if you can help me more. Hadiov (talk) 20:42, 10 October 2015 (UTC)

I am sorry, but I am not familiar with CentOS to tell you more, but I would recommend you ask in CentOS forums since these seem specific to the OS. SSastry (WMF) (talk) 13:02, 12 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

ve-api error

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

i've installed mediawiki 1.25.2 via bitnami on ubuntu 14.04 32bit, i've installed parsoid via bitnami bash (use_mediawiki script), the VE and all its dependencies;

i've setted the url in LocalSetting.php to http://domain:8083/mediawiki, and the parsoid uri of settings.js to http://domain:8083/mediawiki/api.php, but the parsoid server starts on port 8142, and i get this error when i try to edit with VE:

ve-api: Revision IDs (doc=0,api=51) returned by server do not match.

how can i fix this? Ciuino (talk) 09:03, 10 October 2015 (UTC)

Have you set parsoidConfig.serverPort = 8083; in /etc/mediawiki/parsoid/settings.js? Alexander Mashin ^talk 09:30, 10 October 2015 (UTC)

yes, but the parsoid server starts on port 8142 Ciuino (talk) 10:03, 10 October 2015 (UTC)

i also setted the $wgVisualEditorParsoidURL = 'http://domain:8083/mediawiki'; in LocalSetting.php, but still doesen't work :( Ciuino (talk) 10:58, 10 October 2015 (UTC)

That /mediawiki seems strange. Did you try to test Parsoid with curl? Alexander Mashin ^talk 16:17, 11 October 2015 (UTC)

It sure looks to me like Parsoid is pointing at a different wiki than your wiki. cscott (talk) 22:16, 11 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Testing Parsoid

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I've installed Parsoid on MediaWiki 1.25.2 based on [1]

And I can see Parsoid on my mediawiki special pages in installed extensions.

Is there anything more to do before installing VisualEditor?

How can I run and test the Parsoid. There is no server.js to run.

Thanks in advance Hadiov (talk) 17:59, 11 October 2015 (UTC)

Extension:Parsoid is not actually the parsoid service. You should follow the installation instructions at Extension:VisualEditor. cscott (talk) 22:15, 11 October 2015 (UTC)

Thank you very much!!

This sentence solved many of my problems:

Extension:Parsoid is not actually the parsoid service Hadiov (talk) 08:49, 12 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Crossreferences <figtable> and <figure> does not work in mediawiki (CrossReference extension)

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I have some problems when I use crossreferences in my wiki. The result in kiwix (instead of <xr id="tab:infotable"/>) is three red ???, and caption of all tables are "Table 1: xxxxx". Pictures with tag <figure> gives a text <figure id="fig:figurename"> on top of the picture and a text <figure> below the picture. Can anyone please help me? Danielraknes (talk) 09:20, 12 October 2015 (UTC)

We don't support mediawiki extensions yet (other than Cite) although we will be implementing a framework to allow this support in the upcoming quarter. cscott (talk) 21:26, 15 October 2015 (UTC)

Thanks :) Danielraknes (talk) 08:09, 21 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Visual Editor and Parsoid

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I've installed parsoid and VisualEditor on MediaWiki 1.25.2

I can see Edit button on my wiki page but when I click on it I receive this error message:

"Error loading data from server: 0 parsoidserver -http"

Though parsoid server is activated and port 8000 is open.

Thanks in advance Hadiov (talk) 19:13, 12 October 2015 (UTC)

I answered this above, I hope. Usually the disagreement is over "prefix" or "domain". cscott (talk) 21:25, 15 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Table of contents

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

Table of contents does not appear to be a part of the parsoid output.

Is that correct?

Is this an error or is it a request? Danielraknes (talk) 08:29, 13 October 2015 (UTC)

It's intentional. Implementing this has been left to consumers; https://phabricator.wikimedia.org/T51224 is the one for VisualEditor, but it's not something we're currently working on. Jdforrester (WMF) (talk) 14:57, 13 October 2015 (UTC)

Thanks! Danielraknes (talk) 08:32, 14 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Error loading data from parsoidserver -http

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

What reasons may cause this error?

When I click on "Edit" button on my mediawiki to edit with VisualEditor I see this message.

Parosid server is working well.

What is the problem?

Please help me in this way.

Thank you Hadiov (talk) 18:28, 13 October 2015 (UTC)

Usually this is caused by a disagreement in "prefix" or "domain" between mediawiki, VisualEditor, and Parsoid. Did you follow the instructions in Parsoid/Setup? cscott (talk) 21:23, 15 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Numberedheadings

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

MagicNumberedHeadings does not to be a part of the parsoid output.

Is this a feature you are working on? Danielraknes (talk) 08:45, 14 October 2015 (UTC)

There are many mediawiki extensions which Parsoid does not yet support. A goal for the upcoming quarter is to implement an extension framework so that folks can extend Parsoid to support their mediawiki extensions. cscott (talk) 21:22, 15 October 2015 (UTC)

Thanks :) Danielraknes (talk) 08:09, 21 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

How to configure Parsoid

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

Hello,

I can't find localsettings.js nor api directory in my Parsoid extension directory...

Where should I add the configuration specified in Parsoid/Setup ?

Thank you! Ornithorynque liminaire (talk) 15:36, 16 October 2015 (UTC)

Sorry about the confusion. The parsoid extension is not what you want. To clarify this (since you are not the first person confused about this, we have added a big bold message on that extension page).

So, if you are trying to install Parsoid, you should follow the instructions at Extension:VisualEditor. SSastry (WMF) (talk) 20:18, 16 October 2015 (UTC)

Okay, thank you very much. I still don't see whare installation on a shared server (like my wiki) is explained, could you give me a tip please ? Ornithorynque liminaire (talk) 15:23, 17 October 2015 (UTC)

Right now, if you are hosting your wiki on a shared server and need Parsoid for using VE, then the only solution is to install Parsoid on a 3rd party server like heroku unless your wiki host is willing to install node.js and Parsoid for you. See VisualEditor/Installation on a shared host SSastry (WMF) (talk) 21:15, 23 October 2015 (UTC)

Oh this is quite bad for a solution that should be quasi by default :(

Thank you very much for the link! Ornithorynque liminaire (talk) 22:58, 24 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

How to start parsoid automatically?

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

Hello

What should I do to activate and start parsoid ( server.js) automatically when the server starts working?

CentOS 6.7

Thanks Hadiov (talk) 06:01, 18 October 2015 (UTC)

None of us are familiar with CentOS 6.7 .. but, someone showed up on IRC recently (not sure if it was you or someone else) asking about CentOS 6.* and said that they would give us updated instructions once they get it figured out. At that point, we'll update our setup instructions so others on similar installs can benefit from it. But, at this point, we ourselves are not able to help you out directly. Sorry about that. SSastry (WMF) (talk) 21:10, 23 October 2015 (UTC)

Assuming that you have created a /etc/init.d/parsoid script, to make parsoid auto-start (on centos 6) you need to run (once):

chkconfig parsoid on

BTW, our /etc/init.d/parsoid script is:

#! /bin/bash

  #

  # parsoid start

  #

  # chkconfig: 345 86 14

  # description: parsoid

  #

  ### BEGIN INIT INFO

  # Provides: $parsoid

  ### END INIT INFO

  # Source function library.

  . /etc/init.d/functions

  rc=0

  # See how we were called.

  case "$1" in

    start)

          echo    starting parsoid

          cd /opt/parsoid

          nohup node /opt/parsoid/bin/server.js > /dev/null 2>&1 &

          $0 status

         ;;

    stop)

          process=`ps -ef | grep 'node /opt/parsoid/bin/server.js'| grep -v grep | awk '{print $2}'`

          if [ "${process}" != '' ]

          then

                echo    stopping parsoid

                killall -9 node 

          fi

          $0 status

          ;;

    status)

          proc_find=`ps -ef | grep 'node /opt/parsoid/bin/server.js'| grep -v grep`

          if [ "${proc_find}" = '' ]

          then

                echo    parsoid is not running 

          else

                echo parsoid is running: ${proc_find}

          fi

          ;;

    restart|reload)

          cd "$CWD"

          $0 status

          $0 stop

          $0 start

          ;;

    *)

          echo $"Usage: $0 {start|stop|restart|reload|status}"

          exit 1

  esac

  exit $rc 111.69.143.217 (talk) 22:51, 9 January 2016 (UTC)

It would probably be better to redirect parsoid's console output to >> /var/log/parsoid/parsoid.log instead of > /dev/null. (See question above about missing log files on CentOS.) cscott (talk) 19:11, 1 February 2016 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

How to install Parsoid on Raspbian (RPi2)?

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

Hello,

I'm setting up a mediawiki on my Raspberry Pi 2, it's run the Raspbian which are based on Debian jessie. I'm stuck at the Add Wikimedia repository step, it returns this error:

Traceback (most recent call last):

  File "/usr/bin/apt-add-repository", line 167, in <module>

    sp = SoftwareProperties(options=options)

  File "/usr/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 105, in __init__

    self.reload_sourceslist()

  File "/usr/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 595, in reload_sourceslist

    self.distro.get_sources(self.sourceslist)

  File "/usr/lib/python3/dist-packages/aptsources/distro.py", line 89, in get_sources

    (self.id, self.codename))

aptsources.distro.NoDistroTemplateException: Error: could not find a distribution template for Raspbian/jessie

I tried changing the lsb_release to Debian and successfully add the repository but it returns this error on sudo apt-get update:

W: Failed to fetch https://releases.wikimedia.org/debian/dists/jessie-mediawiki/InRelease Unable to find expected entry 'main/binary-armhf/Packages' in Release file (Wrong sources.list entry or malformed file)

I guess my only option now is too manually install Parsoid, but I'm not sure how can I config it so that it looks like I installed it via repository. Can you help me with detail config like which directory should I install parsoid?

Thanks 14.169.215.88 (talk) 16:04, 18 October 2015 (UTC)

it cant be done since it it doesnt have binary for arm 71.64.195.175 (talk) 18:47, 6 January 2016 (UTC)

I assume you are trying to install Parsoid for running VisualEditor? It doesn't matter where you install Parsoid. But, Parsoid/Developer Setup might help you there. It tells you have to start Parsoid on the commandline as well as how to set up the config files (on Ubuntu/Debian) for starting the parsoid service automatically. SSastry (WMF) (talk) 21:19, 23 October 2015 (UTC)

Parsoid could not be installed directly in Raspbian. By SSastry (WMF)suggestion, we could run it with develop version.

Here is Parsoid/Developer setup.

However, the new problem for Raspbian is Develop version need node v4.x or higher. For my raspberry, v0.10.29 is the latest version(Amazing /(ㄒoㄒ)/~~).

So the first thing is to update nodejs.

Follow the steps from Beginner’s Guide to Installing Node.js on a Raspberry Pi.

It should be noticed not every raspberry works.

The second thing is install npm.

sudo apt-get install npm

After doing these, Parsoid/Developer setup will work for Raspbian.

Although Parsoid works, restbase cannot work on my raspberry. Error is " Cannot read property 'constructor' of undefined" Bsplu (talk) 22:17, 26 October 2017 (UTC)

How did you install parsoid for raspbian?

It's impossible. Alkydes (talk) 14:25, 17 March 2018 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Windows installation fatal errors (uncaught exception bind EADDRINUSE null:8000)

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I installed Parsoid on Windows Server 2003 R2 on MediaWiki 1.25.2 and have some fatal errors.

I followed instuctions from: https://www.mediawiki.org/wiki/Parsoid/Developer_Setup#Windows_setup

When I open url (to test installation): http://localhost:8000/my.domain.pl/v3/page/html/Strona_główna then it looks that all is ok.

BUT NEXT WHEN I TRY TO START PARSOID THEN I RECEIVE MANY ERRORS.

I start Parsoid with command:

"C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\parsoid\api\server.js"

and here are errors:

C:\Documents and Settings\Administrator>"C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\parsoid\api\server.js"
[info][master][560] initializing 4 workers
[info][worker][3524] loading ...
[info][worker][3896] loading ...
[fatal][worker][3524] uncaught exception bind EADDRINUSE null:8000
Error: bind EADDRINUSE null:8000
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at cb (net.js:1299:16)
    at shared (cluster.js:582:5)
    at Worker.<anonymous> (cluster.js:556:9)
    at process.<anonymous> (cluster.js:710:8)
    at emitTwo (events.js:92:20)
    at process.emit (events.js:172:7)
    at handleMessage (internal/child_process.js:686:10)
    at internal/child_process.js:497:7
[info][worker][3056] loading ...
[fatal][worker][3896] uncaught exception bind EADDRINUSE null:8000
Error: bind EADDRINUSE null:8000
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at cb (net.js:1299:16)
    at shared (cluster.js:582:5)
    at Worker.<anonymous> (cluster.js:556:9)
    at process.<anonymous> (cluster.js:710:8)
    at emitTwo (events.js:92:20)
    at process.emit (events.js:172:7)
    at handleMessage (internal/child_process.js:686:10)
    at internal/child_process.js:497:7
[info][worker][3968] loading ...
[warning][master][560] worker 3524 died (1), restarting.
[fatal][master][560] uncaught exception Cannot read property 'count' of null
TypeError: Cannot read property 'count' of null
    at EventEmitter.<anonymous> (C:\Program Files\nodejs\parsoid\api\server.js:159:9)
    at emitThree (events.js:97:13)
    at EventEmitter.emit (events.js:175:7)
    at ChildProcess.<anonymous> (cluster.js:353:15)
    at ChildProcess.g (events.js:260:16)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
[fatal][worker][3056] uncaught exception bind EADDRINUSE null:8000
Error: bind EADDRINUSE null:8000
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at cb (net.js:1299:16)
    at shared (cluster.js:582:5)
    at Worker.<anonymous> (cluster.js:556:9)
    at process.<anonymous> (cluster.js:710:8)
    at emitTwo (events.js:92:20)
    at process.emit (events.js:172:7)
    at handleMessage (internal/child_process.js:686:10)
    at internal/child_process.js:497:7
[fatal][worker][3968] uncaught exception bind EADDRINUSE null:8000
Error: bind EADDRINUSE null:8000
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at cb (net.js:1299:16)
    at shared (cluster.js:582:5)
    at Worker.<anonymous> (cluster.js:556:9)
    at process.<anonymous> (cluster.js:710:8)
    at emitTwo (events.js:92:20)
    at process.emit (events.js:172:7)
    at handleMessage (internal/child_process.js:686:10)
    at internal/child_process.js:497:7
	
C:\Documents and Settings\Administrator>

C:\Documents and Settings\Administrator>"C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\parsoid\api\server.js"
[info][master][3952] initializing 4 workers
[info][worker][4276] loading ...
[fatal][worker][4276] uncaught exception bind EADDRINUSE null:8000
Error: bind EADDRINUSE null:8000
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at cb (net.js:1299:16)
    at shared (cluster.js:582:5)
    at Worker.<anonymous> (cluster.js:556:9)
    at process.<anonymous> (cluster.js:710:8)
    at emitTwo (events.js:92:20)
    at process.emit (events.js:172:7)
    at handleMessage (internal/child_process.js:686:10)
    at internal/child_process.js:497:7
[info][worker][4292] loading ...
[info][worker][4476] loading ...
[info][worker][4264] loading ...
[warning][master][3952] worker 4276 died (1), restarting.
[fatal][master][3952] uncaught exception Cannot read property 'count' of null
TypeError: Cannot read property 'count' of null
    at EventEmitter.<anonymous> (C:\Program Files\nodejs\parsoid\api\server.js:159:9)
    at emitThree (events.js:97:13)
    at EventEmitter.emit (events.js:175:7)
    at ChildProcess.<anonymous> (cluster.js:353:15)
    at ChildProcess.g (events.js:260:16)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

C:\Documents and Settings\Administrator>

C:\Documents and Settings\Administrator>"C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\parsoid\api\server.js"
[info][master][4536] initializing 4 workers
[info][worker][4704] loading ...
[info][worker][3356] loading ...
[info][worker][1756] loading ...
[fatal][worker][4704] uncaught exception bind EADDRINUSE null:8000
Error: bind EADDRINUSE null:8000
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at cb (net.js:1299:16)
    at shared (cluster.js:582:5)
    at Worker.<anonymous> (cluster.js:556:9)
    at process.<anonymous> (cluster.js:710:8)
    at emitTwo (events.js:92:20)
    at process.emit (events.js:172:7)
    at handleMessage (internal/child_process.js:686:10)
    at internal/child_process.js:497:7
[info][worker][4200] loading ...
[warning][master][4536] worker 4704 died (1), restarting.
[fatal][master][4536] uncaught exception Cannot read property 'count' of null
TypeError: Cannot read property 'count' of null
    at EventEmitter.<anonymous> (C:\Program Files\nodejs\parsoid\api\server.js:159:9)
    at emitThree (events.js:97:13)
    at EventEmitter.emit (events.js:175:7)
    at ChildProcess.<anonymous> (cluster.js:353:15)
    at ChildProcess.g (events.js:260:16)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
[fatal][worker][3356] uncaught exception bind EADDRINUSE null:8000
Error: bind EADDRINUSE null:8000
    at Object.exports._errnoException (util.js:874:11)
    at exports._exceptionWithHostPort (util.js:897:20)
    at cb (net.js:1299:16)
    at shared (cluster.js:582:5)
    at Worker.<anonymous> (cluster.js:556:9)
    at process.<anonymous> (cluster.js:710:8)
    at emitTwo (events.js:92:20)
    at process.emit (events.js:172:7)
    at handleMessage (internal/child_process.js:686:10)
    at internal/child_process.js:497:7

C:\Documents and Settings\Administrator>

Any clues how I can debug this or what is the meaning of this errors? Pit pl (talk) 08:43, 19 October 2015 (UTC)

If you are able to view http://localhost:8000/my.domain.pl/v3/page/html/Strona_główna then that means you have Parsoid running already and it is listening on port 8000. So, when you try to start Parsoid again on the command line (a second instance of Parsoid I assume), you are starting it with default settings which tries to listen on port 8000 again and cannot open it because it is already in use. SSastry (WMF) (talk) 21:08, 23 October 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

start the service with parsoid/src/api/server.js

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

With

nodejs /usr/lib/parsoid/src/api/server.js

as a workaround... See bug at http://stackoverflow.com/q/33420819/287948 Krauss (talk) 22:41, 2 November 2015 (UTC)

@Krauss Can you tell me more about your install? We have not released a new deb. So how did you even run into the new bin/server.js issue? If you installed from deb, you shouldn't have seen these changes. SSastry (WMF) (talk) 23:01, 2 November 2015 (UTC)

@SSastry (WMF), thanks to the help. I reply there (at Stackoverflow), and the final problem is to generate a lot of parsoid process (see at stackoverdlow comments the description) Krauss (talk) 20:57, 22 November 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

keys.gnupg.net: Network is unreachable

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

Hi,

I have just started trying to install this system and seem to have hit a problem right at the start. When I try to "Import the repository gpg key:" the command fails with an error indicating that "keys.gnupg.net: Network is unreachable"

Are there alternative repositories to get this key from ?

I am trying to set this up on a new Ubuntu 14.04 virtual installation, which is connected to the internet.

Thanks. Jpadfield (talk) 11:18, 12 November 2015 (UTC)

I can reach the network. Maybe it was a transient error. Could you try again? Or, check if you are behind a firewall maybe? SSastry (WMF) (talk) 15:57, 12 November 2015 (UTC)

Still does not work, I will investigate Firewall issues tomorrow, thanks Jpadfield (talk) 17:12, 12 November 2015 (UTC)

I believe there are other mirrors of keys.gnupg.net; some poking around might turn them up.

We could also upload the key to other keyservers, if you can suggest any which are more reachable. cscott (talk) 23:06, 12 November 2015 (UTC)

Using the following command seemed to work, or at least it imported a key :-)

sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 664C383A3566A3481B942F007A322AC6E84AFDD2

It could be good just to add a similar line to the documentation.

I got this solution from: https://gist.github.com/maciakl/4531580

Thanks Jpadfield (talk) 15:34, 13 November 2015 (UTC)

Yes this seems to have work, I now have everything up and running, thanks for the comments. Jpadfield (talk) 16:06, 13 November 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Cannot install parsoid

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

When using the following command 'sudo apt-get install parsoid' I get back 'E: enable to locate package parsoid'.

As the instruction describe i have imported the repository gpg key and did add the wikimedia to the repository.

Anyone an idea how to solve this? 194.78.6.99 (talk) 12:15, 25 November 2015 (UTC)

Does the advice in Talk:Parsoid/2015b#h-Fail_to_install_Parsoid-2015-08-12T07:49:00.000Z help? Arlolra (talk) 18:03, 9 December 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

No settings.js file on re-install of Parsoid

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I ended up having some problems with Parsoid and VisualEditor, so i decided to delete them both and re-install them. After the re-installation I no longer have a settings.js file in my /etc/mediawiki/parsoid folder. How can I get this file back? Swennet (talk) 22:29, 6 December 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

VisualEditor gives "Error 200"

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I installed Parsoid and tried to use VisualEditor. It tries to load, but in the middle it gives me an "Error loading server data. Error 200. Would you like to try again?" (loose translation, my MediaWiki install isn't english). Parsoid seems to be running. What I possibly did wrong? Athosbr99 (talk) 15:46, 9 December 2015 (UTC)

200 is a surprising error, considering it's an HTTP success code.

Can you confirm that Parsoid is more than just running, but that it's generating expected output? Try visiting http://localhost:8142/localhost/Main_Page (or however yours is configured) and verifying that it's rendering that page properly.

Also, it may be helpful to know which versions of Parsoid and VisualEditor you're using. Arlolra (talk) 18:00, 9 December 2015 (UTC)

I was getting this same error, and in my case I removed another package from the server, that removal unintentionally removed php5-curl, so apt-get install php5-curl and a restart of my php5-fpm service fixed the issue. Fyi; I tracked it down by using a local proxy to introspect the request packets mediawiki was sending / receiving and saw the php curl error in there. Wdamien (talk) 23:49, 10 February 2016 (UTC)

I am receiving a HTTP 200 error as well. Would it be possible for you to share a copy of your configuration files to compare? Ldbrizzle (talk) 11:35, 9 March 2016 (UTC)

I had the same problem and I resolved adding the --with-curl to the build options of PHP (I've installed php from source not package on my Centos 6.7)

Probably some missing php-curl or php5-curl package on your install.

Mindux

--'./configure' \

'--prefix=/opt/php-5.3.27' \

'--enable-calendar' \

'--with-freetype-dir' \

'--with-gd' \

'--with-png-dir' \

'--with-jpeg-dir' \

'--with-mysql' \

'--with-ldap' \

'--with-apxs2=/opt/httpd/bin/apxs' \

'--disable-cgi' \

'--with-zlib' \

'--with-libdir=lib64' \

'--with-curl' \ 2001:620:808:2000:E401:7DA8:5280:AA26 (talk) 17:41, 25 March 2016 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

User 'parsoid' not found?

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

sudo service parsoid restart

* Restarting Parsoid HTTP service parsoid                                                                                                                                                                           

start-stop-daemon: user 'parsoid' not found

[fail]

Always getting this message.. Has anyone her a solution for it? 77.59.199.130 (talk) 12:31, 11 December 2015 (UTC)

What platform are you on? Are you using the "official" packages? cscott (talk) 17:36, 26 January 2016 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.

Upgrading MW from 1.5 to 1.6 causes VE editor error

The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.

---

I have the following error after upgrading. So i decided to upgrade VE for 1.6, and i backup my old parsoid to old, and did this quick start process to obtain the new parsoid.

1. git review doesn't work with : git: 'review' is not a git command. See 'git --help'.
2. the localsettings.js this time sits in the parsoid directory rather than parsoid/api
3. Tried nodejs bin/server.js , Editor still couldn't work
4. Check nodejs and it is v0.10
5. tried npm install next , it gets everything
6. test npm test, with an error
7. tried nodejs server.js, got following error. listed below.

What should i do? We have been down for a week.

Error: after upgrading

"Error loading data from server: 404: parsoidserver-http: HTTP 404. Would you like to retry? "

Error: after npm test

root@linux:/opt/bitnami/apps/mediawiki/htdocs/extensions/parsoid# npm test

> parsoid@0.4.1-git test /opt/bitnami/apps/mediawiki/htdocs/extensions/parsoid

> npm run no-0.8 && npm run parserTests && npm run mocha

> parsoid@0.4.1-git no-0.8 /opt/bitnami/apps/mediawiki/htdocs/extensions/parsoid

> node -e 'process.exit(/v0[.][0-8][.]/.test(process.version) ? 0 : 1)' || (npm run nsp && npm run lint)

sh: 1: node: not found

> parsoid@0.4.1-git nsp /opt/bitnami/apps/mediawiki/htdocs/extensions/parsoid

> nsp check

/usr/bin/env: node: No such file or directory

npm ERR! weird error 127

npm WARN This failure might be due to the use of legacy binary "node"

npm WARN For further explanations, please read

/usr/share/doc/nodejs/README.Debian

npm ERR! not ok code 0

npm ERR! weird error 1

npm WARN This failure might be due to the use of legacy binary "node"

npm WARN For further explanations, please read

/usr/share/doc/nodejs/README.Debian

npm ERR! not ok code 0

npm ERR! weird error 1

npm WARN This failure might be due to the use of legacy binary "node"

npm WARN For further explanations, please read

/usr/share/doc/nodejs/README.Debian

npm ERR! not ok code 0<div></div>

"Nodejs Error?"

bitnami@linux:/opt/bitnami/apps/mediawiki/htdocs/extensions/parsoid$ nodejs bin/                               server.js
[info][master][2082] initializing 4 workers
[info][worker][2084] loading ...
[info][worker][2089] loading ...
[info][worker][2087] loading ...
[info][worker][2085] loading ...
[fatal][worker][2084] uncaught exception bind EADDRINUSE
Error: bind EADDRINUSE
    at errnoException (net.js:901:11)
    at net.js:1081:30
    at Object.1:1 (cluster.js:592:5)
    at handleResponse (cluster.js:171:41)
    at respond (cluster.js:192:5)
    at handleMessage (cluster.js:202:5)
    at process.EventEmitter.emit (events.js:117:20)
    at handleMessage (child_process.js:318:10)
    at child_process.js:392:7
    at process.handleConversion.net.Native.got (child_process.js:91:7)
[warning][master][2082] worker 2084 died (1), restarting.
[fatal][worker][2087] uncaught exception bind EADDRINUSE
Error: bind EADDRINUSE
    at errnoException (net.js:901:11)
    at net.js:1081:30
    at Object.3:1 (cluster.js:592:5)
    at handleResponse (cluster.js:171:41)
    at respond (cluster.js:192:5)
    at handleMessage (cluster.js:202:5)
    at process.EventEmitter.emit (events.js:117:20)
    at handleMessage (child_process.js:318:10)
    at child_process.js:392:7
    at process.handleConversion.net.Native.got (child_process.js:91:7)

Quick start

node --version # should be v0.8 or higher (0.10 or higher is preferred) 
git clone https://gerrit.wikimedia.org/r/p/mediawiki/services/parsoid cd parsoid 
git review -s # optional, see below (Doesn't work)
npm install 
npm test # might as well 
edit localsettings.js node bin/server.js

AmazingTrans (talk) 20:45, 17 December 2015 (UTC)

Thats a problem with your node and nodejs. (node got renamed to nodejs on debian)

Download nodejs-legacy

Or

Create a manual symlink to /usr/bin/node.

sudo ln -s `which nodejs` /usr/bin/node 77.59.199.130 (talk) 11:40, 22 December 2015 (UTC)

The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.