MediaWiki r99741 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r99740‎ | r99741 (on ViewVC)‎ | r99742 >
Date:23:04, 13 October 2011
Author:thenub314
Status:ok (Comments)
Tags:math 
Comment:
The following patches restore how texvc added braces for all commands
but \operatorname to fix Bug 31442. More specifically, TEX_FUN1 now
adds braces as it did in previous versions. The result is texvc will
once again correctly sanitize multiple math accents even when no braces are
given (e.g. \dot \vec B) and it will allow math accents to be used with
symbols whose font as been changed (e.g. \tilde \mathcal{M}). Parser
tests are created to ensure these continue to work.

The handling of \operatorname is now handled specially by the
function TEX_FUN1nb (nb stands for no braces and the name is taken to
be consistent with the existing function TEX_FUN2nb). The addition of
braces causes this command to LaTeX incorrectly. The parser test for
\operatorname has been updated to reflect the fact the hash of the
images involved has changed.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r103197missing TEX_FUN1nb in html_render_deep()...hashar17:26, 15 November 2011
r103240REL1_18 MFT r98560, r99741, r101031, r101404, r102438, r102563, r102953, r103197reedy22:08, 15 November 2011
r1032421.18wmf1 MFT r98560, r99741, r101031, r101404, r102438, r102563, r102953, r10...reedy22:10, 15 November 2011

Comments

#Comment by Sumanah (talk | contribs)   16:54, 15 November 2011

I asked some OCaml people to comment on this. One said, "I don't see anything wrong in this commit, although, again, I am not aware of the whole project." Another said, "I guess I don't see anything problematic in the changelog there (though I can't comment much on the .mly stuff - I haven't used ocamlyacc) - are there any specific concerns?"

So that's somewhat reassuring.

#Comment by Hashar (talk | contribs)   19:25, 15 November 2011

This revision is not blocking the 1.18 tarball.

#Comment by Hashar (talk | contribs)   22:09, 15 November 2011

This one is good. i have reviewed the various tests cases on bug 31442 and they seems to render correctly on my Debian.

This can be merged to 1.18wmf1 and scap will recompile the math (thanks Aaron for that tip).

We probably want to add r103197 too although it will need to be reviewed.

#Comment by Hashar (talk | contribs)   22:37, 15 November 2011

Change deployed live! Thanks thenub314 :-)

Status & tagging log