MediaWiki r93067 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r93066‎ | r93067 (on ViewVC)‎ | r93068 >
Date:17:06, 25 July 2011
Author:ashley
Status:deferred
Tags:
Comment:
SocialProfile: support GD for image uploads, too, instead of requiring ImageMagick. Code by Phil Nelson (see http://web.archive.org/web/20090629011952/http://philnelson.name/2009/01/06/using-mediawikis-socialprofile-extension-without-exec-support-in-php/ and http://web.archive.org/web/20090614215532/http://philnelson.name/wpfiles/wp-content/uploads/2009/01/socialprofile-gd.txt), some coding style and code fixes by me. The original code called imagejpeg() unconditionally, even for gif and png images, which caused that the medium-large, medium and small images weren't generated properly. I also adapted the code for SystemGiftManagerLogo and GiftManagerLogo special pages.
Modified paths:

Diff [purge]

Loading diff…

Status & tagging log

  • 09:33, 8 December 2011 Tim Starling (talk | contribs) changed the status of r93067 [removed: new added: deferred]
  • 18:11, 23 October 2011 Jack Phoenix (talk | contribs) changed the status of r93067 [removed: deferred added: new]
  • 01:42, 22 October 2011 Reedy (talk | contribs) changed the status of r93067 [removed: new added: deferred]
  • 14:57, 6 August 2011 Jack Phoenix (talk | contribs) changed the status of r93067 [removed: deferred added: new]
  • 23:10, 5 August 2011 Reedy (talk | contribs) changed the status of r93067 [removed: new added: deferred]