MediaWiki r83240 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r83239‎ | r83240 (on ViewVC)‎ | r83241 >
Date:20:16, 4 March 2011
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
* (bug 27763) Article::getParserOutput() no longer throws a fatal given when an incorrect revision ID is passed
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r83304Follow-up r83240: seems people prefer returning false than the current versio...ialex17:55, 5 March 2011

Comments

#Comment by Platonides (talk | contribs)   23:07, 4 March 2011

I don't think this is right

$text = $this->getRawText();

It should return false, and extensions/LiquidThreads/classes/View.php:1233 handle it properly to make showPostBody() return false.

#Comment by IAlex (talk | contribs)   17:56, 5 March 2011

Done in r83304; will fix LiquidTherads later.

Status & tagging log

  • 14:39, 6 March 2011 Platonides (talk | contribs) changed the status of r83240 [removed: fixme added: resolved]
  • 23:07, 4 March 2011 Platonides (talk | contribs) changed the status of r83240 [removed: new added: fixme]