MediaWiki r83218 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r83217‎ | r83218 (on ViewVC)‎ | r83219 >
Date:15:38, 4 March 2011
Author:btongminh
Status:resolved (Comments)
Tags:
Comment:
(bug 26995) File size is now checked before uploading in HTML5 browsers
* Exposed $wgMaxUploadSize to JS
* Exposed message largefileserver to JS
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r83314Follow-up r83218: Fix bug# per http://www.mediawiki.org/wiki/Special:Code/Med...raymond19:28, 5 March 2011
r83318Follow-up r83218: Added var declarations. Html escape the largefileserver mes...btongminh19:47, 5 March 2011

Comments

#Comment by Bryan (talk | contribs)   15:40, 4 March 2011

Wrong number, correct one is bug 26217.

#Comment by Catrope (talk | contribs)   19:32, 5 March 2011
+			sizes = mw.config.get( 'wgMaxUploadSize' );

Use var sizes = ... , otherwise sizes will be defined as a global variable. Same for maxsize and error further down.

+			error = $( '<p class="error mw-upload-source-error" id="wpSourceTypeFile-error">' + 
+					mw.msg( 'largefileserver', file.size, maxSize ) + '</p>' );
Use $( '

' ).text( mw.msg( .... ) );
so the i18n message isn't interpreted as HTML.
#Comment by Bryan (talk | contribs)   19:47, 5 March 2011

Done in r83318, but differently.

Status & tagging log

  • 22:24, 5 March 2011 Catrope (talk | contribs) changed the status of r83218 [removed: new added: resolved]
  • 19:47, 5 March 2011 Bryan (talk | contribs) changed the status of r83218 [removed: fixme added: new]
  • 19:32, 5 March 2011 Catrope (talk | contribs) changed the status of r83218 [removed: new added: fixme]