MediaWiki r75621 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r75620‎ | r75621 (on ViewVC)‎ | r75622 >
Date:19:20, 28 October 2010
Author:btongminh
Status:resolved (Comments)
Tags:
Comment:
(bug 25648) API discovery information has been added as RSD link in page <head> and by providing an API module action=rsd. Added hook ApiRsdServiceApis for extensions to add their own service to the services list.

Patch by Brion Vibber and Bryan Tong Minh.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r75631Followup r75621, svn:keywords Idreedy22:02, 28 October 2010
r75632Minor followup to r75621, add whitespace...reedy22:56, 28 October 2010
r75648Follow-up r75621: Check for $wgEnableAPI before adding the RSD link to the headbtongminh16:19, 29 October 2010
r75669r75621 copy-paste failbtongminh20:33, 29 October 2010
r76195Follow up r75621: Use setContent and setIndexedTagName methodsbtongminh15:57, 6 November 2010

Comments

#Comment by Reedy (talk | contribs)   10:44, 29 October 2010

Just a thought... Should we take notice of Manual:$wgEnableAPI?

Obviously if it's false, the API isn't runnable, so we don't want to be giving false discovery information, or at least, information that is of no use...

#Comment by Bryan (talk | contribs)   12:49, 29 October 2010

Yes

#Comment by Reedy (talk | contribs)   13:34, 29 October 2010

Marking fixme. Are you going to do it..?

#Comment by Bryan (talk | contribs)   13:36, 29 October 2010

Maybe later today or tomorrow. You can if you want to.

#Comment by Bryan (talk | contribs)   16:20, 29 October 2010
#Comment by Reedy (talk | contribs)   17:42, 29 October 2010

Cheers :)

#Comment by UV (talk | contribs)   19:31, 29 October 2010

Inaccurate/misleading class documentation comment in file /trunk/phase3/includes/api/ApiRsd.php: "API interface for page purging"

#Comment by UV (talk | contribs)   20:56, 29 October 2010

Thank you for r75669, which fixes this

#Comment by Catrope (talk | contribs)   20:18, 31 October 2010
+			 'engineName' => array(
+				 '*' => 'MediaWiki'
+			 ),
[...]
+				$data['settings']['_element'] = 'setting';

We avoid hardcoding '*' and '_element', use ApiResult::setContent() and setIndexedTagName().

Status & tagging log

  • 11:40, 8 November 2010 Catrope (talk | contribs) changed the status of r75621 [removed: new added: resolved]
  • 16:09, 6 November 2010 Bryan (talk | contribs) changed the status of r75621 [removed: fixme added: new]
  • 20:18, 31 October 2010 Catrope (talk | contribs) changed the status of r75621 [removed: new added: fixme]
  • 16:20, 29 October 2010 Bryan (talk | contribs) changed the status of r75621 [removed: fixme added: new]
  • 13:34, 29 October 2010 Reedy (talk | contribs) changed the status of r75621 [removed: new added: fixme]