MediaWiki r69337 - Code Review

Jump to: navigation, search
Revision:r69336‎ | r69337 (on ViewVC)‎ | r69338 >
Date:18:50, 14 July 2010
Status:reverted (Comments)
Remove 'minordefault' preference completely

See bug 24313. The preference encourages people to mark changes minor
by mistake, but it's better to have minor changes not marked minor than
non-minor changes marked minor. enwiki users at [[Help talk:Minor
edit]] seemed to think it was a good idea. Plus, I'm always in favor of
removing user preferences where possible.

The only likely fallout of note is some bot operators who didn't notice
this suddenly find their bot not marking anything minor. I doubt it
will cause major problems, though.
Modified paths:

Follow-up revisions

Rev.Commit summaryAuthorDate
r75815Revert r69337 (Removal of minordefault preference)overlordq18:58, 1 November 2010


#Comment by Simetrical (talk | contribs)   18:53, 14 July 2010

Discussed in #mediawiki beforehand, no objections. Marking with 1.16wmf4 so bug 24313 can be resolved (in lieu of changing $wgHiddenPrefs or such).

#Comment by Nemo bis (talk | contribs)   15:40, 24 August 2010
#Comment by Simetrical (talk | contribs)   17:01, 24 August 2010

(starting at 18:27:29)

#Comment by Gurch (talk | contribs)   22:10, 14 July 2010

Great, now I have to tick a box every time I edit again. Giving serious thought to writing a complete MediaWiki UI replacement for myself...

#Comment by Simetrical (talk | contribs)   22:16, 14 July 2010

If you're editing efficiently, you're probably using Alt-S to save already. Hitting Alt-I first shouldn't be so hard.

#Comment by Gurch (talk | contribs)   11:03, 15 July 2010

Alt-Shift-I on Firefox, you try hitting that with one hand :D

#Comment by Simetrical (talk | contribs)   15:04, 15 July 2010

Easy, with your right hand. If you've just finished filling out the edit summary, you have both hands on the keyboard anyway.

#Comment by Mike.lifeguard (talk | contribs)   15:11, 15 July 2010

You assume the right side of the keyboard has a (working) alt and shift key :D

#Comment by Platonides (talk | contribs)   18:48, 15 July 2010

Which many keyboards don't have.

#Comment by Simetrical (talk | contribs)   18:59, 15 July 2010

So use two hands (= normal typing position), or use a JS one-liner.

#Comment by Platonides (talk | contribs)   23:13, 14 July 2010

Just add to your monobook.js/vector.js

 addOnloadHook(function() { if (wgAction=="edit") document.getElementById("wpMinoredit").checked=true; });
#Comment by Nemo bis (talk | contribs)   18:25, 1 November 2010

Per bug 24313 comment 22 by Tim, someone should revert this and change configuration only...

Status & tagging log

  • 02:59, 8 February 2011 😂 (talk | contribs) changed the tags for r69337 [removed: 1.16wmf4]
  • 19:00, 1 November 2010 OverlordQ (talk | contribs) changed the status of r69337 [removed: ok added: reverted]
  • 10:04, 31 August 2010 Tim Starling (talk | contribs) changed the status of r69337 [removed: new added: ok]
  • 18:53, 14 July 2010 Simetrical (talk | contribs) changed the tags for r69337 [added: 1.16wmf4]