MediaWiki r58377 - Code Review

Jump to: navigation, search
Revision:r58376‎ | r58377 (on ViewVC)‎ | r58378 >
Date:21:41, 30 October 2009
Status:resolved (Comments)
(bug 3340) Allow configuring of /16 limit on range blocks
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r60643Clarify comment on $wgBlockCIDRLimit, larger not below (r58377)tstarling05:08, 5 January 2010
r60644Split rangeblock error message, allow configuring max size of IPv6 blocks as ...overlordq05:44, 5 January 2010


#Comment by Tim Starling (talk | contribs)   05:10, 5 January 2010

Splitting the error message would be useful, since it can no longer be localised to say that blocks larger than /16 will be rejected. The error message should have $wgBlockCIDRLimit passed as a parameter.

#Comment by 😂 (talk | contribs)   10:03, 5 January 2010

Looks good from r60644.

Status & tagging log

  • 10:03, 5 January 2010 😂 (talk | contribs) changed the status of r58377 [removed: fixme added: resolved]
  • 05:10, 5 January 2010 Tim Starling (talk | contribs) changed the status of r58377 [removed: new added: fixme]