MediaWiki r45734 - Code Review

Jump to: navigation, search
Revision:r45733‎ | r45734 (on ViewVC)‎ | r45735 >
Date:17:54, 14 January 2009
Status:ok (Comments)
(bug 16852) padleft and padright now handle multibyte characters and multicharacter pad strings

Patch by RememberTheDot, with adjustments to comments by me
Modified paths:

Diff [purge]

Loading diff…


#Comment by Brion VIBBER (talk | contribs)   21:28, 20 January 2009

Looks ok... :D

#Comment by Plustgarten (talk | contribs)   21:17, 13 April 2009

What if the padding character in padleft or padright is an HTML character code? In particular, it sure would be useful if it could be (or include) an   (which should count as one character). Could we get this effect by judicious application of something like html_entity_decode() to the padding string, before measuring it?

#Comment by Simetrical (talk | contribs)   21:51, 13 April 2009

Would be sensible. Patches are welcome, post them on Bugzilla if you'd like.

Status & tagging log